Conversion between normalized Ultraspherical and Jacobi (#157)

* normalized Ultraspherical Jacobi conversion

* version bump to v0.5.19

Author: jishnub

Project.toml

@@ -1,6 +1,6 @@
 name = "ApproxFunOrthogonalPolynomials"
 uuid = "b70543e2-c0d9-56b8-a290-0d4d6d4de211"
-version = "0.5.18"
+version = "0.5.19"
 
 [deps]
 ApproxFunBase = "fbd15aa5-315a-5a7d-a8a4-24992e37be05"

src/Spaces/Jacobi/Jacobi.jl

@@ -21,10 +21,8 @@ Jacobi(b,a) = Jacobi(b,a,ChebyshevInterval())
 Jacobi(A::Ultraspherical) = Jacobi(order(A)-0.5,order(A)-0.5,domain(A))
 Jacobi(A::Chebyshev) = Jacobi(-0.5,-0.5,domain(A))
 
-NormalizedJacobi(b,a,d) = NormalizedPolynomialSpace(Jacobi(b,a,d))
-NormalizedJacobi(b,a) = NormalizedPolynomialSpace(Jacobi(b,a))
-NormalizedLegendre(d) = NormalizedPolynomialSpace(Legendre(d))
-NormalizedLegendre() = NormalizedPolynomialSpace(Legendre())
+NormalizedJacobi(s...) = NormalizedPolynomialSpace(Jacobi(s...))
+NormalizedLegendre(d...) = NormalizedPolynomialSpace(Legendre(d...))
 
 normalization(::Type{T}, sp::Jacobi, k::Int) where T = FastTransforms.Anαβ(k, sp.a, sp.b)
 
@@ -35,6 +33,10 @@ function Ultraspherical(J::Jacobi)
         error("Cannot construct Ultraspherical with a=$(J.a) and b=$(J.b)")
     end
 end
+NormalizedUltraspherical(NS::NormalizedPolynomialSpace{<:Jacobi}) =
+    NormalizedPolynomialSpace(Ultraspherical(NS.space))
+NormalizedJacobi(NS::NormalizedPolynomialSpace{<:Union{Ultraspherical, Chebyshev}}) =
+    NormalizedPolynomialSpace(Jacobi(NS.space))
 
 Base.promote_rule(::Type{Jacobi{D,R1}},::Type{Jacobi{D,R2}}) where {D,R1,R2} =
     Jacobi{D,promote_type(R1,R2)}

src/Spaces/Ultraspherical/Ultraspherical.jl

@@ -31,6 +31,7 @@ NormalizedUltraspherical(m,d) = NormalizedPolynomialSpace(Ultraspherical(m,d))
 
 
 order(S::Ultraspherical) = S.order
+order(N::NormalizedPolynomialSpace{<:Ultraspherical}) = order(N.space)
 setdomain(S::Ultraspherical,d::Domain) = Ultraspherical(order(S),d)
 
 

test/JacobiTest.jl

@@ -47,42 +47,6 @@ using StaticArrays: SVector
         testtransforms(Jacobi(-0.5,-0.5))
         @test norm(Fun(Fun(exp),Jacobi(-.5,-.5))-Fun(exp,Jacobi(-.5,-.5))) < 300eps()
 
-        @testset "inplace transform" begin
-            @testset for T in (Float32, Float64), ET in (T, complex(T))
-                v = Array{ET}(undef, 10)
-                v2 = similar(v)
-                @testset for a in 0:0.5:3, b in 0:0.5:3, d in ((), (0..1,))
-                    J = Jacobi(a, b, d...)
-                    Slist = (J, NormalizedPolynomialSpace(J))
-                    @testset for S in Slist
-                        test_transform!(v, v2, S)
-                    end
-                end
-                v = Array{ET}(undef, 10, 10)
-                v2 = similar(v)
-                @testset for a in 0:0.5:3, b in 0:0.5:3, d in ((), (0..1,))
-                    J = Jacobi(a, b, d...)
-                    Slist = (J, NormalizedPolynomialSpace(J))
-                    @testset for S1 in Slist, S2 in Slist
-                        S = S1 ⊗ S2
-                        test_transform!(v, v2, S)
-                    end
-                    @testset for S1 in Slist
-                        S = S1 ⊗ Chebyshev(d...)
-                        test_transform!(v, v2, S)
-                        S = S1 ⊗ Chebyshev()
-                        test_transform!(v, v2, S)
-                    end
-                    @testset for S2 in Slist
-                        S = Chebyshev(d...) ⊗ S2
-                        test_transform!(v, v2, S)
-                        S = Chebyshev() ⊗ S2
-                        test_transform!(v, v2, S)
-                    end
-                end
-            end
-        end
-
         @testset for d in [-1..1, 0..1]
             f = Fun(x->x^2, Chebyshev(d))
             C = space(f)
@@ -96,6 +60,53 @@ using StaticArrays: SVector
                 end
             end
         end
+
+        @testset "conversion between spaces" begin
+            for u in (Ultraspherical(1), Chebyshev())
+                @test NormalizedPolynomialSpace(Jacobi(u)) ==
+                    NormalizedJacobi(NormalizedPolynomialSpace(u))
+            end
+            for j in (Legendre(), Jacobi(1,1))
+                @test NormalizedPolynomialSpace(Ultraspherical(j)) ==
+                    NormalizedUltraspherical(NormalizedPolynomialSpace(j))
+            end
+        end
+    end
+
+    @testset "inplace transform" begin
+        @testset for T in (Float32, Float64), ET in (T, complex(T))
+            v = Array{ET}(undef, 10)
+            v2 = similar(v)
+            @testset for a in 0:0.5:3, b in 0:0.5:3, d in ((), (0..1,))
+                J = Jacobi(a, b, d...)
+                Slist = (J, NormalizedPolynomialSpace(J))
+                @testset for S in Slist
+                    test_transform!(v, v2, S)
+                end
+            end
+            v = Array{ET}(undef, 10, 10)
+            v2 = similar(v)
+            @testset for a in 0:0.5:3, b in 0:0.5:3, d in ((), (0..1,))
+                J = Jacobi(a, b, d...)
+                Slist = (J, NormalizedPolynomialSpace(J))
+                @testset for S1 in Slist, S2 in Slist
+                    S = S1 ⊗ S2
+                    test_transform!(v, v2, S)
+                end
+                @testset for S1 in Slist
+                    S = S1 ⊗ Chebyshev(d...)
+                    test_transform!(v, v2, S)
+                    S = S1 ⊗ Chebyshev()
+                    test_transform!(v, v2, S)
+                end
+                @testset for S2 in Slist
+                    S = Chebyshev(d...) ⊗ S2
+                    test_transform!(v, v2, S)
+                    S = Chebyshev() ⊗ S2
+                    test_transform!(v, v2, S)
+                end
+            end
+        end
     end
 
     @testset "Derivative" begin