setdomain for NormalizedPolynomialSpace (#74)

* setdomain for NormalizedPolynomialSpace

* pass domsinspace to jacobi calculus wrappers

* Add tests

Author: jishnub

Project.toml

@@ -21,7 +21,7 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
 
 [compat]
 AbstractFFTs = "0.5, 1"
-ApproxFunBase = "0.5, 0.6"
+ApproxFunBase = "0.6.14"
 BandedMatrices = "0.16, 0.17"
 BlockArrays = "0.14, 0.15, 0.16"
 BlockBandedMatrices = "0.10, 0.11"

src/Spaces/Jacobi/JacobiOperators.jl

@@ -96,7 +96,13 @@ end
 
 ## Derivative
 
-Derivative(J::Jacobi,k::Integer)=k==1 ? ConcreteDerivative(J,1) : DerivativeWrapper(TimesOperator(Derivative(Jacobi(J.b+1,J.a+1,J.domain),k-1),ConcreteDerivative(J,1)),k)
+function Derivative(J::Jacobi,k::Integer)
+    k==1 ? ConcreteDerivative(J,1) :
+        DerivativeWrapper(
+            TimesOperator(
+                Derivative(Jacobi(J.b+1,J.a+1,J.domain),k-1),ConcreteDerivative(J,1)),
+        J, k)
+end
 
 
 
@@ -114,14 +120,14 @@ getindex(T::ConcreteDerivative{J},k::Integer,j::Integer) where {J<:Jacobi} =
 function Integral(J::Jacobi,k::Integer)
     if k > 1
         Q=Integral(J,1)
-        IntegralWrapper(TimesOperator(Integral(rangespace(Q),k-1),Q),k)
+        IntegralWrapper(TimesOperator(Integral(rangespace(Q),k-1),Q),J,k)
     elseif J.a > 0 && J.b > 0   # we have a simple definition
         ConcreteIntegral(J,1)
     else   # convert and then integrate
         sp=Jacobi(J.b+1,J.a+1,domain(J))
         C=Conversion(J,sp)
         Q=Integral(sp,1)
-        IntegralWrapper(TimesOperator(Q,C),1)
+        IntegralWrapper(TimesOperator(Q,C),J,1)
     end
 end
 

src/Spaces/PolynomialSpace.jl

@@ -346,6 +346,7 @@ end
 
 domain(S::NormalizedPolynomialSpace) = domain(S.space)
 canonicalspace(S::NormalizedPolynomialSpace) = S.space
+setdomain(NS::NormalizedPolynomialSpace, d::Domain) = NormalizedPolynomialSpace(setdomain(canonicalspace(NS), d))
 
 NormalizedPolynomialSpace(space::PolynomialSpace{D,R}) where {D,R} = NormalizedPolynomialSpace{typeof(space),D,R}(space)
 

test/ChebyshevTest.jl

@@ -102,6 +102,10 @@ import ApproxFunOrthogonalPolynomials: forwardrecurrence
         r=rand(100) .+ 1
         @test maximum(abs,ef.(r)-exp.(r))<400eps()
         @test maximum(abs,ecf.(r).-cos.(r).*exp.(r))<100eps()
+
+        @testset "setdomain" begin
+            @test setdomain(NormalizedChebyshev(0..1), 1..2) == NormalizedChebyshev(1..2)
+        end
     end
 
     @testset "Other interval" begin
@@ -237,5 +241,18 @@ import ApproxFunOrthogonalPolynomials: forwardrecurrence
                 end
             end
         end
+
+        @testset "derivative in normalized space" begin
+            s1 = NormalizedChebyshev(-1..1)
+            s2 = NormalizedChebyshev()
+            @test s1 == s2
+            D1 = Derivative(s1)
+            D2 = Derivative(s2)
+            f = x -> 3x^2 + 5x
+            f1 = Fun(f, s1)
+            f2 = Fun(f, s2)
+            @test f1 == f2
+            @test D1 * f1 == D2 * f2
+        end
     end
 end

test/JacobiTest.jl

@@ -60,6 +60,16 @@ import ApproxFunOrthogonalPolynomials: jacobip
     @testset "Derivative" begin
         D=Derivative(Jacobi(0.,1.,Segment(1.,0.)))
         @time testbandedoperator(D)
+
+        @testset for S1 in Any[Jacobi(0,0),
+            Jacobi(0,0,1..2), Jacobi(2,2,1..2), Jacobi(0.5,2.5,1..2)],
+                S in Any[S1, NormalizedPolynomialSpace(S1)]
+            f = Fun(x->x^3 + 4x^2 + 2x + 6, S)
+            @test Derivative(S) * f ≈ Fun(x->3x^2 + 8x + 2, S)
+            @test Derivative(S)^2 * f ≈ Fun(x->6x+8, S)
+            @test Derivative(S)^3 * f ≈ Fun(x->6, S)
+            @test Derivative(S)^4 * f ≈ zeros(S)
+        end
     end
 
     @testset "identity Fun for interval domains" begin