Use atol as default ztol in isapprox

Author: blegat

src/comparison.jl

@@ -110,7 +110,11 @@ isapproxzero(p::APL; kwargs...) = all(isapproxzero.(terms(p); kwargs...))
 isapproxzero(p::RationalPoly; kwargs...) = isapproxzero(p.num; kwargs...)
 
 Base.isapprox(t1::AbstractTerm, t2::AbstractTerm; kwargs...) = isapprox(coefficient(t1), coefficient(t2); kwargs...) && monomial(t1) == monomial(t2)
-Base.isapprox(p1::AbstractPolynomial, p2::AbstractPolynomial; ztol::Real=1e-6, kwargs...) = compare_terms(p1, p2, t -> isapproxzero(t; ztol=ztol), (x, y) -> isapprox(x, y; kwargs...))
+function Base.isapprox(p1::AbstractPolynomial{S}, p2::AbstractPolynomial{T};
+                       atol=0, ztol::Real=iszero(atol) ? Base.rtoldefault(S, T, 0) : atol, kwargs...) where {S, T}
+    return compare_terms(p1, p2, t -> isapproxzero(t; ztol=ztol),
+                         (x, y) -> isapprox(x, y; atol=atol, kwargs...))
+end
 
 Base.isapprox(p::RationalPoly, q::RationalPoly; kwargs...) = isapprox(p.num*q.den, q.num*p.den; kwargs...)
 Base.isapprox(p::RationalPoly, q::APL; kwargs...) = isapprox(p.num, q*p.den; kwargs...)

test/REQUIRE

@@ -1,3 +1,3 @@
 BenchmarkTools
-DynamicPolynomials 0.1.3
+DynamicPolynomials 0.1.4
 TypedPolynomials 0.2

test/comparison.jl

@@ -50,7 +50,9 @@
             @test isapprox((2-1e-3)*x*y + (3+1e-3)*y^2, 3*y^2 + 2*y*x, rtol=1e-2)
             @test !isapprox((2-1e-3)*x*y + (3+1e-1)*y^2, 3*y^2 + 2*y*x, rtol=1e-2)
             @test isapprox(1e-3*x*y + 3*y^2 + x^2, x^2 + 3*y^2, rtol=1e-2, ztol=1e-2)
+            @test isapprox(1e-3*x*y + 3*y^2 + x^2, x^2 + 3*y^2, rtol=1e-2, atol=1e-2)
             @test isapprox(3*y^2 + x^2, x^2 + 1e-3*x*y + 3*y^2, rtol=1e-2, ztol=1e-2)
+            @test isapprox(3*y^2 + x^2, x^2 + 1e-3*x*y + 3*y^2, rtol=1e-2, atol=1e-2)
             @test !isapprox(3*y^2 + x^2, x^2 + 1e-1*x*y + 3*y^2, rtol=1e-2, ztol=1e-2)
             @test !isapprox(3.0*y^2 + x + x^2, x + 3*y^2, rtol=1e-2, ztol=1e-2)
             @test isapprox(x+1-x, 1+1e-8, rtol=1e-7)