Remove allocations of isapproxzero (#224)

Author: blegat

src/comparison.jl

@@ -119,7 +119,7 @@ end
 
 isapproxzero(m::AbstractMonomialLike; kwargs...) = false
 isapproxzero(t::AbstractTermLike; kwargs...) = isapproxzero(coefficient(t); kwargs...)
-isapproxzero(p::APL; kwargs...) = all(isapproxzero.(terms(p); kwargs...))
+isapproxzero(p::APL; kwargs...) = all(term -> isapproxzero(term; kwargs...), terms(p))
 isapproxzero(p::RationalPoly; kwargs...) = isapproxzero(p.num; kwargs...)
 
 Base.isapprox(t1::AbstractTerm, t2::AbstractTerm; kwargs...) = isapprox(coefficient(t1), coefficient(t2); kwargs...) && monomial(t1) == monomial(t2)

test/allocations.jl

@@ -13,6 +13,8 @@ function runtests()
 end
 
 using MutableArithmetics
+import MultivariatePolynomials
+const MP = MultivariatePolynomials
 using TypedPolynomials
 
 function test_polynomial_merge()
@@ -28,5 +30,34 @@ function test_polynomial_merge()
     end
 end
 
+function test_isapproxzero()
+    @polyvar x y
+    p = x * y + x + y + 1
+    alloc_test(0) do
+        isapproxzero(p)
+    end
+    q = 1e-10 * x * y + 1e-12 * x
+    alloc_test(0) do
+        isapproxzero(q)
+    end
+    alloc_test(0) do
+        isapproxzero(q; ztol = 1e-8)
+    end
+end
+
+function _test_gcd(T)
+    o = one(T)
+    @polyvar x y
+    t1 = o * x * y
+    t2 = o * x
+    alloc_test(0) do
+        gcd(t1, t2)
+    end
+end
+
+function test_gcd()
+    _test_gcd(Int)
+end
+
 end
 TestAllocations.runtests()