Fix quadratic form with non-symmetric matrix and non-commutative variables

Author: blegat

Project.toml

@@ -1,7 +1,7 @@
 name = "DynamicPolynomials"
 uuid = "7c1d4256-1411-5781-91ec-d7bc3513ac07"
 repo = "https://github.com/JuliaAlgebra/DynamicPolynomials.jl.git"
-version = "0.3.13"
+version = "0.3.14"
 
 [deps]
 DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"

src/poly.jl

@@ -228,13 +228,12 @@ function MP.polynomial(Q::AbstractMatrix, mv::MonomialVector{C}, ::Type{T}) wher
                 # for j in 1:n wouldn't be cache friendly for Q
                 for j in i:n
                     k = trimap(i, j, n)
-                    q = Q[i, j]
                     x[offset+k] = mv[i] * mv[j]
-                    a[offset+k] = q
+                    a[offset+k] = Q[i, j]
                     if i != j
                         offset += 1
                         x[offset+k] = mv[j] * mv[i]
-                        a[offset+k] = q
+                        a[offset+k] = Q[j, i]
                     end
                 end
             end

test/runtests.jl

@@ -3,6 +3,15 @@ using MultivariatePolynomials
 using Test
 using LinearAlgebra
 
+# TODO move to MP
+@testset "Noncommutative quadratic" begin
+    @ncpolyvar x[1:2]
+    Q = Hermitian([1 2 + 3im; 2 - 3im 4])
+    p = 1x[1]^2 + (2 + 3im) * x[1] * x[2] + (2 - 3im) * x[2] * x[1] + 4x[2]^2
+    @test polynomial(Q, x) == p
+    @test polynomial(Q, monovec(x)) == p
+end
+
 include("mono.jl")
 include("poly.jl")
 include("comp.jl")