remove sonar violations

Author: Z7oussem

src/main/java/io/asfjava/ui/core/generators/ComboBoxGenerator.java

@@ -44,16 +44,19 @@ public void generate(ObjectNode fieldFormDefinition, Field field) {
 				fieldFormDefinition.set("titleMap", titlesMap);
 			} catch (InstantiationException | IllegalAccessException e) {
 				ASFUILogger.getLogger().error(e.getMessage());
+				throw new RuntimeException(e);
 			}
 		}
 
 	}
 
 	private void buildValueDefinition(ObjectMapper comboMapper, ArrayNode titlesMap, String value) {
 		ObjectNode entry = comboMapper.createObjectNode();
-		if (value.equals(value.toUpperCase())) {
+		String upperCasedValue = value.toUpperCase();
+		String lowerCasedValue = value.toLowerCase();
+		if (value.equals(upperCasedValue)) {
 			entry.put("name", value.toLowerCase());
-		} else if (value.equals(value.toLowerCase())) {
+		} else if (value.equals(lowerCasedValue)) {
 			entry.put("name", value.replace(value.substring(0, 1), value.substring(0, 1).toUpperCase()));
 		} else {
 			entry.put("name", value);

src/main/java/io/asfjava/ui/core/generators/RadioBoxGenerator.java

@@ -21,7 +21,7 @@ public void generate(ObjectNode fieldFormDefinition, Field field) {
 		fieldFormDefinition.put("readOnly", annotation.readOnly());
 		fieldFormDefinition.put("type", "radios");
 
-		JsonNode radioFieldFormDefinition = ((JsonNode) fieldFormDefinition);
+		JsonNode radioFieldFormDefinition = fieldFormDefinition;
 
 		ObjectMapper radioMapper = new ObjectMapper();
 
@@ -41,6 +41,7 @@ public void generate(ObjectNode fieldFormDefinition, Field field) {
 			}
 		} catch (InstantiationException | IllegalAccessException e) {
 			ASFUILogger.getLogger().error(e.getMessage());
+			throw new RuntimeException(e);
 		}
 
 		((ObjectNode) radioFieldFormDefinition).set("titleMap", titlesMap);

src/main/java/io/asfjava/ui/core/logging/ASFUILogger.java

@@ -9,4 +9,8 @@ public final class ASFUILogger {
 	public static Logger getLogger(){
 		return LOGGER;
 	}
+	
+	private ASFUILogger() {
+	}
+
 }