Merge pull request #389 from tilo/create-bang-methods

adding create!, update_attributes!, update! methods

Author: gaorlov

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- [#389](https://github.com/JsonApiClient/json_api_client/pull/389)-adding create!, update_attributes!, update! methods
+
 ## 1.19.0
 - [#382](https://github.com/JsonApiClient/json_api_client/pull/382) - Add extra error classes to hande server errors.
 

lib/json_api_client/errors.rb

@@ -103,5 +103,16 @@ def initialize(code, uri)
         super nil, msg
       end
     end
+
+    class RecordNotSaved < ServerError
+      attr_reader :record
+
+      def initialize(message = nil, record = nil)
+        @record = record
+      end
+      def message
+        "Record not saved"
+      end
+    end
   end
 end

lib/json_api_client/resource.rb

@@ -172,6 +172,12 @@ def create(attributes = {})
         end
       end
 
+      def create!(attributes = {})
+        new(attributes).tap do |resource|
+          raise(Errors::RecordNotSaved.new("Failed to save the record", resource)) unless resource.save
+        end
+      end
+
       # Within the given block, add these headers to all requests made by
       # the resource class
       #
@@ -376,6 +382,11 @@ def update_attributes(attrs = {})
       save
     end
 
+    def update_attributes!(attrs = {})
+      self.attributes = attrs
+      save ? true : raise(Errors::RecordNotSaved.new("Failed to update the record", self))
+    end
+
     # Alias to update_attributes
     #
     # @param attrs [Hash] Attributes to update
@@ -384,6 +395,10 @@ def update(attrs = {})
       update_attributes(attrs)
     end
 
+    def update!(attrs = {})
+      update_attributes!(attrs)
+    end
+
     # Mark the record as persisted
     def mark_as_persisted!
       @persisted = true

test/unit/creation_test.rb

@@ -66,6 +66,23 @@ def test_can_create_with_class_method
     assert_equal "Rails is Omakase", article.title
   end
 
+  def test_failed_create!
+    stub_request(:post, "http://example.com/users")
+      .to_return(headers: {content_type: "application/vnd.api+json"}, body: {
+        errors: [
+          {
+            status: "400",
+            title: "Error"
+          }
+        ]
+      }.to_json)
+
+    exception = assert_raises JsonApiClient::Errors::RecordNotSaved do
+      User.create!(name: 'Hans')
+    end
+    assert_equal "Record not saved", exception.message
+  end
+
   def test_changed_attributes_empty_after_create_with_class_method
     stub_simple_creation
     article = Article.create({
@@ -206,7 +223,65 @@ def test_can_create_with_new_record_with_relationships_and_save
     assert article.persisted?
     assert_equal article.comments.length, 1
     assert_equal "1", article.id
+  end
 
+  def test_can_create_with_new_record_with_associated_relationships_and_save
+    stub_request(:post, "http://example.com/articles")
+      .with(headers: {content_type: "application/vnd.api+json", accept: "application/vnd.api+json"}, body: {
+        data: {
+          type: "articles",
+          relationships: {
+            author: {
+              data: {
+                id: 1,
+                type: "authors"
+              }
+            }
+          },
+          attributes: {
+            title: "Rails is Omakase"
+          }
+        }
+      }.to_json)
+      .to_return(headers: {content_type: "application/vnd.api+json"}, body: {
+        data: {
+          type: "articles",
+          id: "1",
+          attributes: {
+            title: "Rails is Omakase"
+          },
+          relationships: {
+            author: {
+              data: [
+                {
+                  id: "1",
+                  type: "comments"
+                }
+              ]
+            }
+          }
+        },
+        included: [
+          {
+            id: "1",
+            type: "authors",
+          }
+        ]
+      }.to_json)
+
+    author_hash = {
+      author: {
+        data: {
+          id: 1,
+          type: 'authors'
+        }
+      }
+    }
+    article = Article.new({title: "Rails is Omakase", "relationships" => author_hash})
+
+    assert article.save
+    assert article.persisted?
+    assert_equal "1", article.id
   end
 
   def test_correct_create_with_nil_attribute_value

test/unit/updating_test.rb

@@ -36,6 +36,36 @@ def stub_simple_fetch
       }.to_json)
   end
 
+  def test_failed_update!
+    stub_simple_fetch
+    articles = Article.find(1)
+    article = articles.first
+
+    stub_request(:patch, "http://example.com/articles/1")
+      .with(headers: {content_type: "application/vnd.api+json", accept: "application/vnd.api+json"}, body: {
+          data: {
+            id: "1",
+            type: "articles",
+            attributes: {
+              title: "Modified title",
+            }
+          }
+        }.to_json)
+      .to_return(headers: {content_type: "application/vnd.api+json"}, body: {
+        errors: [
+          {
+            status: "400",
+            title: "Error"
+          }
+        ]
+      }.to_json)
+
+    exception = assert_raises JsonApiClient::Errors::RecordNotSaved do
+      article.update!(title: 'Modified title')
+    end
+    assert_equal "Record not saved", exception.message
+  end
+
   def test_can_update_found_record
     stub_simple_fetch
     articles = Article.find(1)