Merge pull request #311 from jamesstonehill/raise-on-misc-client-error

Raise client error for unhandled 4xx responses

Author: gaorlov

CHANGELOG.md

@@ -2,6 +2,8 @@
 
 ## Unreleased
 
+- [#311](https://githup.com/JsonApiClient/json_api_client/pull/311) - Raise JsonApiClient::Errors::ClientError for unhandled 4xx responses
+
 ## v1.6.1
 
 - [#297](https://githup.com/JsonApiClient/json_api_client/pull/297) - Fix test_helper

lib/json_api_client/middleware/status.rb

@@ -29,7 +29,7 @@ def handle_status(code, env)
         when 409
           raise Errors::Conflict, env
         when 400..499
-          # some other error
+          raise Errors::ClientError, env
         when 500..599
           raise Errors::ServerError, env
         else

test/unit/status_test.rb

@@ -56,4 +56,17 @@ def test_server_responding_with_404_status_meta
     end
   end
 
+  def test_server_responding_with_408_status
+    stub_request(:get, "http://example.com/users/1")
+      .to_return(headers: {content_type: "application/vnd.api+json"}, body: {
+        meta: {
+          status: 408,
+          message: "Request timeout"
+        }
+      }.to_json)
+
+    assert_raises JsonApiClient::Errors::ClientError do
+      User.find(1)
+    end
+  end
 end