Emit a DeprecationWarning for the old dict-like access to the return value of validate_email and remove some internal uses of it

Author: JoshData

CHANGELOG.md

@@ -15,6 +15,7 @@ There are no significant changes to which email addresses are considered valid/i
 * The tests have been reorganized and expanded. Deliverability tests now mostly use captured DNS responses so they can be run off-line.
 * The __main__ tool now reads options to validate_email from environment variables.
 * Type annotations have been added to the exported methods and the ValidatedEmail class and some internal methods.
+* The old dict-like pattern for the return value of validate_email is deprecated.
 
 Version 1.3.1 (January 21, 2023)
 --------------------------------

email_validator/exceptions_types.py

@@ -1,3 +1,4 @@
+import warnings
 from typing import Optional
 
 
@@ -72,6 +73,7 @@ def __repr__(self):
     """For backwards compatibility, some fields are also exposed through a dict-like interface. Note
     that some of the names changed when they became attributes."""
     def __getitem__(self, key):
+        warnings.warn("dict-like access to the return value of validate_email is deprecated and may not be supported in the future.", DeprecationWarning, stacklevel=2)
         if key == "email":
             return self.email
         if key == "email_ascii":

email_validator/validate_email.py

@@ -173,7 +173,7 @@ def validate_email(
         # Lazy load `deliverability` as it is slow to import (due to dns.resolver)
         from .deliverability import validate_email_deliverability
         deliverability_info = validate_email_deliverability(
-            ret["domain"], ret["domain_i18n"], timeout, dns_resolver
+            ret.ascii_domain, ret.domain, timeout, dns_resolver
         )
         for key, value in deliverability_info.items():
             setattr(ret, key, value)