Fix venv check by inverting exit code and adding more info

Author: JohT

.github/workflows/internal-check-python-venv-support.yml

@@ -32,10 +32,19 @@ jobs:
       env: 
         USE_VIRTUAL_PYTHON_ENVIRONMENT_VENV: "true"
       # 1.  Run the script under test to create, activate and install the virtual environment
-      # 2a. Run pip in dry-run mode without installing or resolving dependencies
-      # 2b. Suppress all pip output (stderr)
-      # 2c. Check if pip *would install* anything using grep
-      # 2d. If there are missing dependencies and the environment is incomplete, return 1 (indicates all requirements already satisfied)
+      # 2.  Start with an overall check with pip
+      # 3.  Run pip in dry-mode with full output first to get all infos and fail on missing packages.
+      # 4a. The leading exclamation mark tells the shell to invert the returned exit code. 
+      #     Failing because "Would install" is missing leads to a successful execution. 
+      # 5b. Run pip in dry-run mode without installing or resolving dependencies
+      # 5c. Suppress all pip output (stderr)
+      # 5d. Check if pip *would install* anything using grep
+      # 5e. If there are missing dependencies and the environment is incomplete, fail with code 1 (indicates all requirements already satisfied)
+      # TODO remove:
+      # pip install --dry-run --ignore-installed --requirement "./requirements.txt"
+      # ! pip install --dry-run --no-deps --no-cache-dir --no-index --requirement "./requirements.txt" 2>/dev/null | grep -q "Would install"
       run: |
         ./scripts/activatePythonEnvironment.sh
-        pip install --dry-run --no-deps --requirement "./requirements.txt" 2>/dev/null | grep -q "Would install" || return 1
+        source .venv/bin/activate
+        echo "Currently activated environment: ${VIRTUAL_ENV}"
+        ! pip install --dry-run --no-deps --ignore-installed --requirement requirements.txt  2>/dev/null