fix(js): “irritating visual clutter when typing” with opened hint and state autoComplete enabled (#66)

zoobestik · AlexanderPrendota · commit c0f67954bffa · 2019-09-07T16:12:10.000+02:00
diff --git a/src/executable-code/executable-fragment.js b/src/executable-code/executable-fragment.js
@@ -518,7 +518,7 @@ export default class ExecutableFragment extends ExecutableCodeTemplate {
      */
     this.codemirror.on("keypress", debounce((cm, event) => {
       if (event.keyCode !== KEY_CODES.R && !event.ctrlKey) {
-        if (this.state.autoComplete) {
+        if (this.state.autoComplete && !cm.state.completionActive) {
           CodeMirror.showHint(cm, CodeMirror.hint.kotlin, {completeSingle: false});
         }
       }

Original file line number	Diff line number	Diff line change
`@@ -518,7 +518,7 @@ export default class ExecutableFragment extends ExecutableCodeTemplate {`
`518`	`518`	`*/`
`519`	`519`	`this.codemirror.on("keypress", debounce((cm, event) => {`
`520`	`520`	`if (event.keyCode !== KEY_CODES.R && !event.ctrlKey) {`
`521`		`- if (this.state.autoComplete) {`
	`521`	`+ if (this.state.autoComplete && !cm.state.completionActive) {`
`522`	`522`	`CodeMirror.showHint(cm, CodeMirror.hint.kotlin, {completeSingle: false});`
`523`	`523`	`}`
`524`	`524`	`}`