docs: Add @let block entry to the API

Author: JeanMeche

goldens/public-api/compiler-cli/compiler_options.api.md

@@ -56,6 +56,7 @@ export interface LegacyNgcOptions {
 // @public
 export interface MiscOptions {
     compileNonExportedClasses?: boolean;
+    disableImageImports?: boolean;
     disableTypeScriptVersionCheck?: boolean;
     forbidOrphanComponents?: boolean;
 }

packages/bazel/src/ng_module/ng_module.bzl

@@ -165,6 +165,7 @@ def _ngc_tsconfig(ctx, files, srcs, **kwargs):
         "fullTemplateTypeCheck": ctx.attr.type_check,
         "strictTemplates": ctx.attr.strict_templates,
         "compilationMode": compilation_mode,
+        "disableImageImports": ctx.attr.disable_impage_imports,
         # In Google3 we still want to use the symbol factory re-exports in order to
         # not break existing apps inside Google. Unlike Bazel, Google3 does not only
         # enforce strict dependencies of source files, but also for generated files
@@ -461,6 +462,7 @@ NG_MODULE_ATTRIBUTES = {
     "type_check": attr.bool(default = True),
     "strict_templates": attr.bool(default = False),
     "inline_resources": attr.bool(default = True),
+    "disable_impage_imports": attr.bool(default = True),
     "no_i18n": attr.bool(default = False),
     "compiler": attr.label(
         doc = """Sets a different ngc compiler binary to use for this library.

packages/bazel/src/ngc-wrapped/index.ts

@@ -92,6 +92,7 @@ export async function runOneBuild(
     'onlyExplicitDeferDependencyImports',
     'generateExtraImportsInLocalMode',
     '_enableLetSyntax',
+    'disableImageImports',
   ]);
 
   const userOverrides = Object.entries(userOptions)

packages/compiler-cli/linker/src/file_linker/partial_linkers/partial_component_linker_1.ts

@@ -120,6 +120,7 @@ export class PartialComponentLinkerVersion1<TStatement, TExpression>
       i18nNormalizeLineEndingsInICUs: isInline,
       enableBlockSyntax,
       enableLetSyntax,
+      disableImageImports: false /* TODO **/,
     });
     if (template.errors !== null) {
       const errors = template.errors.map((err) => err.toString()).join('\n');
@@ -239,6 +240,7 @@ export class PartialComponentLinkerVersion1<TStatement, TExpression>
       relativeContextFilePath: this.sourceUrl,
       i18nUseExternalIds: false,
       declarations,
+      disableImageImports: false /** TODO */,
     };
   }
 

packages/compiler-cli/src/ngtsc/annotations/component/src/handler.ts

@@ -249,6 +249,7 @@ export class ComponentDecoratorHandler
     private readonly forbidOrphanRendering: boolean,
     private readonly enableBlockSyntax: boolean,
     private readonly enableLetSyntax: boolean,
+    private readonly disableImageImports: boolean,
     private readonly localCompilationExtraImportsTracker: LocalCompilationExtraImportsTracker | null,
     private readonly jitDeclarationRegistry: JitDeclarationRegistry,
   ) {
@@ -258,6 +259,7 @@ export class ComponentDecoratorHandler
       usePoisonedData: this.usePoisonedData,
       enableBlockSyntax: this.enableBlockSyntax,
       enableLetSyntax: this.enableLetSyntax,
+      disableImageImports: this.disableImageImports,
     };
   }
 
@@ -278,6 +280,7 @@ export class ComponentDecoratorHandler
     usePoisonedData: boolean;
     enableBlockSyntax: boolean;
     enableLetSyntax: boolean;
+    disableImageImports: boolean;
   };
 
   readonly precedence = HandlerPrecedence.PRIMARY;
@@ -629,6 +632,7 @@ export class ComponentDecoratorHandler
           usePoisonedData: this.usePoisonedData,
           enableBlockSyntax: this.enableBlockSyntax,
           enableLetSyntax: this.enableLetSyntax,
+          disableImageImports: this.disableImageImports,
         },
         this.compilationMode,
       );
@@ -794,6 +798,7 @@ export class ComponentDecoratorHandler
           i18nUseExternalIds: this.i18nUseExternalIds,
           relativeContextFilePath,
           rawImports: rawImports !== null ? new o.WrappedNodeExpr(rawImports) : undefined,
+          disableImageImports: this.disableImageImports,
         },
         typeCheckMeta: extractDirectiveTypeCheckMeta(node, inputs, this.reflector),
         classMetadata: this.includeClassMetadata
@@ -1536,6 +1541,7 @@ export class ComponentDecoratorHandler
       ...analysis.meta,
       ...resolution,
       defer: this.compileDeferBlocks(resolution),
+      disableImageImports: this.disableImageImports,
     };
     const fac = compileNgFactoryDefField(toFactoryMetadata(meta, FactoryTarget.Component));
 

packages/compiler-cli/src/ngtsc/annotations/component/src/resources.ts

@@ -133,6 +133,7 @@ export interface ExtractTemplateOptions {
   i18nNormalizeLineEndingsInICUs: boolean;
   enableBlockSyntax: boolean;
   enableLetSyntax: boolean;
+  disableImageImports: boolean;
 }
 
 export function extractTemplate(
@@ -270,6 +271,7 @@ function parseExtractedTemplate(
     escapedString,
     enableBlockSyntax: options.enableBlockSyntax,
     enableLetSyntax: options.enableLetSyntax,
+    disableImageImports: options.disableImageImports,
   };
 
   const parsedTemplate = parseTemplate(sourceStr, sourceMapUrl ?? '', {

packages/compiler-cli/src/ngtsc/annotations/component/test/component_spec.ts

@@ -145,6 +145,7 @@ function setup(
     /* forbidOrphanRenderering */ false,
     /* enableBlockSyntax */ true,
     /* enableLetSyntax */ true,
+    /* disableImageImports */ false,
     /* localCompilationExtraImportsTracker */ null,
     jitDeclarationRegistry,
   );

packages/compiler-cli/src/ngtsc/core/api/src/public_options.ts

@@ -436,4 +436,9 @@ export interface MiscOptions {
    * another library without option set will not issue error if rendered in orphan way.
    */
   forbidOrphanComponents?: boolean;
+
+  /**
+   * Disables the generation of import statements for local images referenced by ngSrc
+   */
+  disableImageImports?: boolean;
 }

packages/compiler-cli/src/ngtsc/core/src/compiler.ts

@@ -389,6 +389,7 @@ export class NgCompiler {
   readonly enableTemplateTypeChecker: boolean;
   private readonly enableBlockSyntax: boolean;
   private readonly enableLetSyntax: boolean;
+  private readonly disableImageImports: boolean;
   private readonly angularCoreVersion: string | null;
 
   /**
@@ -462,6 +463,9 @@ export class NgCompiler {
     this.enableBlockSyntax = options['_enableBlockSyntax'] ?? true;
     this.enableLetSyntax = options['_enableLetSyntax'] ?? true;
     this.angularCoreVersion = options['_angularCoreVersion'] ?? null;
+
+    this.disableImageImports = options['disableImageImports'] === true;
+
     this.constructionDiagnostics.push(
       ...this.adapter.constructionDiagnostics,
       ...verifyCompatibleTypeCheckOptions(this.options),
@@ -1444,6 +1448,7 @@ export class NgCompiler {
         !!this.options.forbidOrphanComponents,
         this.enableBlockSyntax,
         this.enableLetSyntax,
+        this.disableImageImports,
         localCompilationExtraImportsTracker,
         jitDeclarationRegistry,
       ),

packages/compiler-cli/src/ngtsc/translator/src/api/import_generator.ts

@@ -41,6 +41,11 @@ export interface ImportRequest<TFile> {
    * with anything in the file.
    */
   unsafeAliasOverride?: string;
+
+  /**
+   * Attributes to add to the import statement
+   */
+  attributes?: Record<string, string> | null;
 }
 
 /**