Don't convert buffer to mutable if it not required

asmirnov82 · asmirnov82 · commit 6be198d5032c · 2023-05-25T09:37:44.000+03:00
# Conflicts:
#	src/Microsoft.Data.Analysis/PrimitiveDataFrameColumnArithmetic.cs
#	src/Microsoft.Data.Analysis/PrimitiveDataFrameColumnArithmetic.tt
diff --git a/src/Microsoft.Data.Analysis/PrimitiveDataFrameColumnArithmetic.cs b/src/Microsoft.Data.Analysis/PrimitiveDataFrameColumnArithmetic.cs
@@ -267,8 +267,7 @@ public void ElementwiseEquals(PrimitiveColumnContainer<bool> left, PrimitiveColu
         {
             for (int b = 0; b < left.Buffers.Count; b++)
             {
-                var mutableBuffer = left.Buffers.GetOrCreateMutable(b);
-                var span = mutableBuffer.Span;
+                var span = left.Buffers[b].ReadOnlySpan;
                 var otherSpan = right.Buffers[b].ReadOnlySpan;
                 for (int i = 0; i < span.Length; i++)
                 {
@@ -280,8 +279,7 @@ public void ElementwiseEquals(PrimitiveColumnContainer<bool> column, bool scalar
         {
             for (int b = 0; b < column.Buffers.Count; b++)
             {
-                var mutableBuffer = column.Buffers.GetOrCreateMutable(b);
-                var span = mutableBuffer.Span;
+                var span = column.Buffers[b].ReadOnlySpan;
                 for (int i = 0; i < span.Length; i++)
                 {
                     ret[i] = (span[i] == scalar);
@@ -292,8 +290,7 @@ public void ElementwiseNotEquals(PrimitiveColumnContainer<bool> left, PrimitiveC
         {
             for (int b = 0; b < left.Buffers.Count; b++)
             {
-                var mutableBuffer = left.Buffers.GetOrCreateMutable(b);
-                var span = mutableBuffer.Span;
+                var span = left.Buffers[b].ReadOnlySpan;
                 var otherSpan = right.Buffers[b].ReadOnlySpan;
                 for (int i = 0; i < span.Length; i++)
                 {
@@ -305,8 +302,7 @@ public void ElementwiseNotEquals(PrimitiveColumnContainer<bool> column, bool sca
         {
             for (int b = 0; b < column.Buffers.Count; b++)
             {
-                var mutableBuffer = column.Buffers.GetOrCreateMutable(b);
-                var span = mutableBuffer.Span;
+                var span = column.Buffers[b].ReadOnlySpan;
                 for (int i = 0; i < span.Length; i++)
                 {
                     ret[i] = (span[i] != scalar);
@@ -457,8 +453,7 @@ public void ElementwiseEquals(PrimitiveColumnContainer<DateTime> left, Primitive
         {
             for (int b = 0; b < left.Buffers.Count; b++)
             {
-                var mutableBuffer = left.Buffers.GetOrCreateMutable(b);
-                var span = mutableBuffer.Span;
+                var span = left.Buffers[b].ReadOnlySpan;
                 var otherSpan = right.Buffers[b].ReadOnlySpan;
                 for (int i = 0; i < span.Length; i++)
                 {
@@ -470,8 +465,7 @@ public void ElementwiseEquals(PrimitiveColumnContainer<DateTime> column, DateTim
         {
             for (int b = 0; b < column.Buffers.Count; b++)
             {
-                var mutableBuffer = column.Buffers.GetOrCreateMutable(b);
-                var span = mutableBuffer.Span;
+                var span = column.Buffers[b].ReadOnlySpan;
                 for (int i = 0; i < span.Length; i++)
                 {
                     ret[i] = (span[i] == scalar);
@@ -482,8 +476,7 @@ public void ElementwiseNotEquals(PrimitiveColumnContainer<DateTime> left, Primit
         {
             for (int b = 0; b < left.Buffers.Count; b++)
             {
-                var mutableBuffer = left.Buffers.GetOrCreateMutable(b);
-                var span = mutableBuffer.Span;
+                var span = left.Buffers[b].ReadOnlySpan;
                 var otherSpan = right.Buffers[b].ReadOnlySpan;
                 for (int i = 0; i < span.Length; i++)
                 {
@@ -495,8 +488,7 @@ public void ElementwiseNotEquals(PrimitiveColumnContainer<DateTime> column, Date
         {
             for (int b = 0; b < column.Buffers.Count; b++)
             {
-                var mutableBuffer = column.Buffers.GetOrCreateMutable(b);
-                var span = mutableBuffer.Span;
+                var span = column.Buffers[b].ReadOnlySpan;
                 for (int i = 0; i < span.Length; i++)
                 {
                     ret[i] = (span[i] != scalar);

Original file line number	Diff line number	Diff line change
`@@ -267,8 +267,7 @@ public void ElementwiseEquals(PrimitiveColumnContainer<bool> left, PrimitiveColu`
`267`	`267`	`{`
`268`	`268`	`for (int b = 0; b < left.Buffers.Count; b++)`
`269`	`269`	`{`
`270`		`- var mutableBuffer = left.Buffers.GetOrCreateMutable(b);`
`271`		`- var span = mutableBuffer.Span;`
	`270`	`+ var span = left.Buffers[b].ReadOnlySpan;`
`272`	`271`	`var otherSpan = right.Buffers[b].ReadOnlySpan;`
`273`	`272`	`for (int i = 0; i < span.Length; i++)`
`274`	`273`	`{`
`@@ -280,8 +279,7 @@ public void ElementwiseEquals(PrimitiveColumnContainer<bool> column, bool scalar`
`280`	`279`	`{`
`281`	`280`	`for (int b = 0; b < column.Buffers.Count; b++)`
`282`	`281`	`{`
`283`		`- var mutableBuffer = column.Buffers.GetOrCreateMutable(b);`
`284`		`- var span = mutableBuffer.Span;`
	`282`	`+ var span = column.Buffers[b].ReadOnlySpan;`
`285`	`283`	`for (int i = 0; i < span.Length; i++)`
`286`	`284`	`{`
`287`	`285`	`ret[i] = (span[i] == scalar);`
`@@ -292,8 +290,7 @@ public void ElementwiseNotEquals(PrimitiveColumnContainer<bool> left, PrimitiveC`
`292`	`290`	`{`
`293`	`291`	`for (int b = 0; b < left.Buffers.Count; b++)`
`294`	`292`	`{`
`295`		`- var mutableBuffer = left.Buffers.GetOrCreateMutable(b);`
`296`		`- var span = mutableBuffer.Span;`
	`293`	`+ var span = left.Buffers[b].ReadOnlySpan;`
`297`	`294`	`var otherSpan = right.Buffers[b].ReadOnlySpan;`
`298`	`295`	`for (int i = 0; i < span.Length; i++)`
`299`	`296`	`{`
`@@ -305,8 +302,7 @@ public void ElementwiseNotEquals(PrimitiveColumnContainer<bool> column, bool sca`
`305`	`302`	`{`
`306`	`303`	`for (int b = 0; b < column.Buffers.Count; b++)`
`307`	`304`	`{`
`308`		`- var mutableBuffer = column.Buffers.GetOrCreateMutable(b);`
`309`		`- var span = mutableBuffer.Span;`
	`305`	`+ var span = column.Buffers[b].ReadOnlySpan;`
`310`	`306`	`for (int i = 0; i < span.Length; i++)`
`311`	`307`	`{`
`312`	`308`	`ret[i] = (span[i] != scalar);`
`@@ -457,8 +453,7 @@ public void ElementwiseEquals(PrimitiveColumnContainer<DateTime> left, Primitive`
`457`	`453`	`{`
`458`	`454`	`for (int b = 0; b < left.Buffers.Count; b++)`
`459`	`455`	`{`
`460`		`- var mutableBuffer = left.Buffers.GetOrCreateMutable(b);`
`461`		`- var span = mutableBuffer.Span;`
	`456`	`+ var span = left.Buffers[b].ReadOnlySpan;`
`462`	`457`	`var otherSpan = right.Buffers[b].ReadOnlySpan;`
`463`	`458`	`for (int i = 0; i < span.Length; i++)`
`464`	`459`	`{`
`@@ -470,8 +465,7 @@ public void ElementwiseEquals(PrimitiveColumnContainer<DateTime> column, DateTim`
`470`	`465`	`{`
`471`	`466`	`for (int b = 0; b < column.Buffers.Count; b++)`
`472`	`467`	`{`
`473`		`- var mutableBuffer = column.Buffers.GetOrCreateMutable(b);`
`474`		`- var span = mutableBuffer.Span;`
	`468`	`+ var span = column.Buffers[b].ReadOnlySpan;`
`475`	`469`	`for (int i = 0; i < span.Length; i++)`
`476`	`470`	`{`
`477`	`471`	`ret[i] = (span[i] == scalar);`
`@@ -482,8 +476,7 @@ public void ElementwiseNotEquals(PrimitiveColumnContainer<DateTime> left, Primit`
`482`	`476`	`{`
`483`	`477`	`for (int b = 0; b < left.Buffers.Count; b++)`
`484`	`478`	`{`
`485`		`- var mutableBuffer = left.Buffers.GetOrCreateMutable(b);`
`486`		`- var span = mutableBuffer.Span;`
	`479`	`+ var span = left.Buffers[b].ReadOnlySpan;`
`487`	`480`	`var otherSpan = right.Buffers[b].ReadOnlySpan;`
`488`	`481`	`for (int i = 0; i < span.Length; i++)`
`489`	`482`	`{`
`@@ -495,8 +488,7 @@ public void ElementwiseNotEquals(PrimitiveColumnContainer<DateTime> column, Date`
`495`	`488`	`{`
`496`	`489`	`for (int b = 0; b < column.Buffers.Count; b++)`
`497`	`490`	`{`
`498`		`- var mutableBuffer = column.Buffers.GetOrCreateMutable(b);`
`499`		`- var span = mutableBuffer.Span;`
	`491`	`+ var span = column.Buffers[b].ReadOnlySpan;`
`500`	`492`	`for (int i = 0; i < span.Length; i++)`
`501`	`493`	`{`
`502`	`494`	`ret[i] = (span[i] != scalar);`