Skip to content

Commit 6ab22d9

Browse files
authored
Check RUN_TESTS parameter in GitHub Actions correctly (hazelcast#1352)
`RUN_TESTS` is a `String` parameter, so when we check it: https://github.com/hazelcast/hazelcast-cpp-client/blob/d06c1893dc89d1d8ed19f7534c4cedea7a924fb4/.github/actions/build-test/ubuntu-x86_64/action.yml#L56-L57 We are actually checking if it's _populated_, not if it's `true`.
1 parent c5edb71 commit 6ab22d9

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

.github/actions/build-test/ubuntu-i386/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ runs:
9292
./scripts/install-thrift.sh ${{ inputs.THRIFT_VERSION }}
9393
9494
- name: Configure Resources
95-
if: ${{ inputs.run_tests }}
95+
if: ${{ inputs.run_tests == 'true' }}
9696
shell: bash
9797
run: |
9898
ulimit -c unlimited

.github/actions/build-test/ubuntu-x86_64/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ runs:
5454
sudo ./scripts/install-thrift.sh ${{ inputs.THRIFT_VERSION }}
5555
5656
- name: Configure Resources
57-
if: ${{ inputs.run_tests }}
57+
if: ${{ inputs.run_tests == 'true' }}
5858
shell: bash
5959
run: |
6060
ulimit -c unlimited

.github/actions/build-test/unix/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ runs:
4949
-DBUILD_EXAMPLES=OFF
5050
5151
- name: Test
52-
if: ${{ inputs.run_tests }}
52+
if: ${{ inputs.run_tests == 'true' }}
5353
env:
5454
BUILD_DIR: build
5555
HAZELCAST_ENTERPRISE_KEY: ${{ inputs.HAZELCAST_ENTERPRISE_KEY }}

.github/actions/build-test/windows/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,7 @@ runs:
150150
-DBUILD_EXAMPLES=OFF
151151
152152
- name: Test
153-
if: ${{ inputs.run_tests }}
153+
if: ${{ inputs.run_tests == 'true' }}
154154
env:
155155
BUILD_DIR: build
156156
BUILD_CONFIGURATION: ${{ inputs.BUILD_TYPE }}

.github/actions/coverage-report/action.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ runs:
7272
-DBUILD_EXAMPLES=OFF
7373
7474
- name: Test
75-
if: ${{ inputs.run_tests }}
75+
if: ${{ inputs.run_tests == 'true' }}
7676
env:
7777
BUILD_DIR: build
7878
HAZELCAST_ENTERPRISE_KEY: ${{ inputs.HAZELCAST_ENTERPRISE_KEY }}

0 commit comments

Comments
 (0)