Hide SwiftPM warnings on non-mac platforms (flutter#178073)

Fixes flutter#162594.

## Pre-launch Checklist

- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel
on [Discord].

**Note**: The Flutter team is currently trialing the use of [Gemini Code
Assist for
GitHub](https://developers.google.com/gemini-code-assist/docs/review-github-code).
Comments from the `gemini-code-assist` bot should not be taken as
authoritative feedback from the Flutter team. If you find its comments
useful you can update your code accordingly, but if you are unsure or
disagree with the feedback, please feel free to wait for a Flutter team
member's review for guidance on which automated comments should be
addressed.

<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md

Author: vashworth

packages/flutter_tools/lib/src/flutter_plugins.dart

@@ -1312,6 +1312,7 @@ Future<void> injectPlugins(
           featureFlags: featureFlags,
           logger: globals.logger,
           analytics: globals.analytics,
+          platform: globals.platform,
         );
     if (iosPlatform) {
       await darwinDependencyManagerSetup.setUp(platform: FlutterDarwinPlatform.ios);

packages/flutter_tools/lib/src/macos/darwin_dependency_management.dart

@@ -7,6 +7,7 @@ import 'package:unified_analytics/unified_analytics.dart';
 import '../base/common.dart';
 import '../base/file_system.dart';
 import '../base/logger.dart';
+import '../base/platform.dart';
 import '../darwin/darwin.dart';
 import '../features.dart';
 import '../plugins.dart';
@@ -28,14 +29,16 @@ class DarwinDependencyManagement {
     required FeatureFlags featureFlags,
     required Logger logger,
     required Analytics analytics,
+    required Platform platform,
   }) : _project = project,
        _plugins = plugins,
        _cocoapods = cocoapods,
        _swiftPackageManager = swiftPackageManager,
        _fileSystem = fileSystem,
        _featureFlags = featureFlags,
        _logger = logger,
-       _analytics = analytics;
+       _analytics = analytics,
+       _hostPlatform = platform;
 
   final FlutterProject _project;
   final List<Plugin> _plugins;
@@ -45,6 +48,7 @@ class DarwinDependencyManagement {
   final FeatureFlags _featureFlags;
   final Logger _logger;
   final Analytics _analytics;
+  final Platform _hostPlatform;
 
   /// Generates/updates required files and project settings for Darwin
   /// Dependency Managers (CocoaPods and Swift Package Manager). Projects may
@@ -75,8 +79,15 @@ class DarwinDependencyManagement {
     if (_project.isModule) {
       return;
     }
-    final (:int totalCount, :int swiftPackageCount, :int podCount) =
-        await _evaluatePluginsAndPrintWarnings(platform: platform, xcodeProject: xcodeProject);
+    final (
+      :int totalCount,
+      :int swiftPackageCount,
+      :int podCount,
+    ) = await _evaluatePluginsAndPrintWarnings(
+      platform: platform,
+      xcodeProject: xcodeProject,
+      hostPlatformIsMacOS: _hostPlatform.isMacOS,
+    );
 
     final bool useCocoapods;
     if (xcodeProject.usesSwiftPackageManager) {
@@ -115,18 +126,19 @@ class DarwinDependencyManagement {
     _analytics.send(event);
   }
 
-  /// Returns count of total number of plugins, number of Swift Package Manager
-  /// compatible plugins, and number of CocoaPods compatible plugins. A plugin
-  /// can be both Swift Package Manager and CocoaPods compatible.
+  /// Returns count of total number of plugins, number of Swift Package Manager compatible plugins,
+  /// and number of CocoaPods compatible plugins. A plugin can be both Swift Package Manager and
+  /// CocoaPods compatible.
   ///
-  /// Prints warnings when using a plugin incompatible with the available Darwin
-  /// Dependency Manager (Swift Package Manager or CocoaPods).
+  /// If [hostPlatformIsMacOS], prints warnings when using a plugin incompatible with the available
+  /// Darwin Dependency Manager (Swift Package Manager or CocoaPods).
   ///
-  /// Prints message prompting the user to deintegrate CocoaPods if using all
-  /// Swift Package plugins.
+  /// If [hostPlatformIsMacOS], prints message prompting the user to deintegrate CocoaPods if
+  /// using all Swift Package plugins.
   Future<({int totalCount, int swiftPackageCount, int podCount})> _evaluatePluginsAndPrintWarnings({
     required FlutterDarwinPlatform platform,
     required XcodeBasedProject xcodeProject,
+    required bool hostPlatformIsMacOS,
   }) async {
     var pluginCount = 0;
     var swiftPackageCount = 0;
@@ -165,7 +177,8 @@ class DarwinDependencyManagement {
       // If not using Swift Package Manager and plugin does not have podspec
       // but does have a Package.swift, throw an error. Otherwise, it'll error
       // when it builds.
-      if (!xcodeProject.usesSwiftPackageManager &&
+      if (hostPlatformIsMacOS &&
+          !xcodeProject.usesSwiftPackageManager &&
           !cocoaPodsCompatible &&
           swiftPackageManagerCompatible) {
         throwToolExit(
@@ -197,7 +210,8 @@ class DarwinDependencyManagement {
             '${_podIncludeInConfigWarning(xcodeProject, 'Debug')}'
             '${_podIncludeInConfigWarning(xcodeProject, 'Release')}';
 
-        if (xcodeProject.podfile.readAsStringSync() == podfileTemplate.readAsStringSync()) {
+        if (hostPlatformIsMacOS &&
+            xcodeProject.podfile.readAsStringSync() == podfileTemplate.readAsStringSync()) {
           _logger.printWarning(
             'All plugins found for ${platform.name} are Swift Packages, but your '
             'project still has CocoaPods integration. To remove CocoaPods '
@@ -207,7 +221,7 @@ class DarwinDependencyManagement {
             '$configWarning\n'
             "Removing CocoaPods integration will improve the project's build time.",
           );
-        } else {
+        } else if (hostPlatformIsMacOS) {
           // If all plugins are Swift Packages, but the Podfile has custom logic,
           // recommend migrating manually.
           _logger.printWarning(

packages/flutter_tools/test/general.shard/macos/darwin_dependency_management_test.dart

@@ -5,6 +5,7 @@
 import 'package:file/file.dart';
 import 'package:file/memory.dart';
 import 'package:flutter_tools/src/base/logger.dart';
+import 'package:flutter_tools/src/base/platform.dart';
 import 'package:flutter_tools/src/darwin/darwin.dart';
 import 'package:flutter_tools/src/macos/cocoapods.dart';
 import 'package:flutter_tools/src/macos/darwin_dependency_management.dart';
@@ -61,6 +62,7 @@ void main() {
                 featureFlags: TestFeatureFlags(isSwiftPackageManagerEnabled: true),
                 logger: testLogger,
                 analytics: fakeAnalytics,
+                platform: FakePlatform(operatingSystem: 'macos'),
               );
               await dependencyManagement.setUp(platform: platform);
               expect(swiftPackageManager.generated, isTrue);
@@ -127,6 +129,7 @@ void main() {
                   featureFlags: TestFeatureFlags(isSwiftPackageManagerEnabled: true),
                   logger: testLogger,
                   analytics: testAnalytics,
+                  platform: FakePlatform(operatingSystem: 'macos'),
                 );
                 await dependencyManagement.setUp(platform: platform);
                 expect(swiftPackageManager.generated, isTrue);
@@ -195,6 +198,7 @@ void main() {
                   featureFlags: TestFeatureFlags(isSwiftPackageManagerEnabled: true),
                   logger: testLogger,
                   analytics: testAnalytics,
+                  platform: FakePlatform(operatingSystem: 'macos'),
                 );
                 await dependencyManagement.setUp(platform: platform);
                 expect(swiftPackageManager.generated, isTrue);
@@ -266,6 +270,7 @@ void main() {
                   featureFlags: TestFeatureFlags(isSwiftPackageManagerEnabled: true),
                   logger: testLogger,
                   analytics: testAnalytics,
+                  platform: FakePlatform(operatingSystem: 'macos'),
                 );
                 await dependencyManagement.setUp(platform: platform);
                 expect(swiftPackageManager.generated, isTrue);
@@ -353,6 +358,7 @@ void main() {
                   featureFlags: TestFeatureFlags(isSwiftPackageManagerEnabled: true),
                   logger: testLogger,
                   analytics: testAnalytics,
+                  platform: FakePlatform(operatingSystem: 'macos'),
                 );
                 await dependencyManagement.setUp(platform: platform);
                 expect(swiftPackageManager.generated, isTrue);
@@ -449,6 +455,7 @@ void main() {
                 featureFlags: TestFeatureFlags(isSwiftPackageManagerEnabled: true),
                 logger: testLogger,
                 analytics: testAnalytics,
+                platform: FakePlatform(operatingSystem: 'macos'),
               );
               await dependencyManagement.setUp(platform: platform);
               expect(swiftPackageManager.generated, isTrue);
@@ -515,6 +522,7 @@ void main() {
                 featureFlags: TestFeatureFlags(isSwiftPackageManagerEnabled: true),
                 logger: testLogger,
                 analytics: testAnalytics,
+                platform: FakePlatform(operatingSystem: 'macos'),
               );
               await dependencyManagement.setUp(platform: platform);
               expect(swiftPackageManager.generated, isTrue);
@@ -568,6 +576,7 @@ void main() {
                 featureFlags: TestFeatureFlags(),
                 logger: testLogger,
                 analytics: testAnalytics,
+                platform: FakePlatform(operatingSystem: 'macos'),
               );
               await dependencyManagement.setUp(platform: platform);
               expect(swiftPackageManager.generated, isFalse);
@@ -621,6 +630,7 @@ void main() {
                 featureFlags: TestFeatureFlags(),
                 logger: testLogger,
                 analytics: testAnalytics,
+                platform: FakePlatform(operatingSystem: 'macos'),
               );
               await expectLater(
                 () => dependencyManagement.setUp(platform: platform),
@@ -637,6 +647,46 @@ void main() {
               expect(testAnalytics.sentEvents, isEmpty);
             });
 
+            testWithoutContext(
+              'with only Swift Package Manager plugins does not throw error on non-mac',
+              () async {
+                final testFileSystem = MemoryFileSystem.test();
+                final testLogger = BufferLogger.test();
+                final FakeAnalytics testAnalytics = getInitializedFakeAnalyticsInstance(
+                  fs: testFileSystem,
+                  fakeFlutterVersion: FakeFlutterVersion(),
+                );
+                final File swiftPackagePluginPodspec = testFileSystem.file(
+                  '/path/to/cocoapod_plugin_1/darwin/cocoapod_plugin_1/Package.swift',
+                )..createSync(recursive: true);
+                final plugins = <Plugin>[
+                  FakePlugin(
+                    name: 'swift_package_plugin_1',
+                    platforms: <String, PluginPlatform>{platform.name: FakePluginPlatform()},
+                    pluginSwiftPackageManifestPath: swiftPackagePluginPodspec.path,
+                  ),
+                ];
+                final swiftPackageManager = FakeSwiftPackageManager(expectedPlugins: plugins);
+                final cocoaPods = FakeCocoaPods();
+
+                final dependencyManagement = DarwinDependencyManagement(
+                  project: FakeFlutterProject(fileSystem: testFileSystem),
+                  plugins: plugins,
+                  cocoapods: cocoaPods,
+                  swiftPackageManager: swiftPackageManager,
+                  fileSystem: testFileSystem,
+                  featureFlags: TestFeatureFlags(),
+                  logger: testLogger,
+                  analytics: testAnalytics,
+                  platform: FakePlatform(operatingSystem: 'windows'),
+                );
+                await dependencyManagement.setUp(platform: platform);
+                expect(swiftPackageManager.generated, isFalse);
+                expect(cocoaPods.podfileSetup, isTrue);
+                expect(testAnalytics.sentEvents, isNotEmpty);
+              },
+            );
+
             testWithoutContext('when project is a module', () async {
               final testFileSystem = MemoryFileSystem.test();
               final testLogger = BufferLogger.test();
@@ -666,6 +716,7 @@ void main() {
                 featureFlags: TestFeatureFlags(),
                 logger: testLogger,
                 analytics: testAnalytics,
+                platform: FakePlatform(operatingSystem: 'macos'),
               );
               await dependencyManagement.setUp(platform: platform);
               expect(swiftPackageManager.generated, isFalse);