Fix AUT issue where multiple users are created and merge (#899)

Co-authored-by: Megha <megha.pithadiya@iterable.com>
Co-authored-by: Evan Greer <evan.greer@evan.greer>

Author: 3 people

swift-sdk/Internal/AnonymousUserManager.swift

@@ -28,6 +28,7 @@ public class AnonymousUserManager: AnonymousUserManagerProtocol {
     private let notificationStateProvider: NotificationStateProviderProtocol
     private var config: IterableConfig
     private(set) var lastCriteriaFetch: Double = 0
+    private var isCriteriaMatched = false
 
     /// Tracks an anonymous event and store it locally
     public func trackAnonEvent(name: String, dataFields: [AnyHashable: Any]?) {
@@ -182,6 +183,7 @@ public class AnonymousUserManager: AnonymousUserManagerProtocol {
                 dataFields: self.localStorage.anonymousUserUpdate,
                 requestJson: anonSessions
             ).onError { error in
+                self.isCriteriaMatched = false
                 if error.httpStatusCode == 409 {
                     self.getAnonCriteria() // refetch the criteria
                 }
@@ -229,7 +231,8 @@ public class AnonymousUserManager: AnonymousUserManagerProtocol {
             processAndStoreEvent(type: type, data: data)
         }
 
-        if let criteriaId = evaluateCriteriaAndReturnID() {
+        if let criteriaId = evaluateCriteriaAndReturnID(), !isCriteriaMatched {
+            isCriteriaMatched = true
             createAnonymousUser(criteriaId)
         }
     }

tests/unit-tests/IterableApiCriteriaFetchTests.swift

@@ -49,7 +49,7 @@ class IterableApiCriteriaFetchTests: XCTestCase {
 
         let config = IterableConfig()
         config.enableAnonActivation = true
-        config.enableOnForegroundCriteriaFetching = true
+        config.enableForegroundCriteriaFetch = true
 
         IterableAPI.initializeForTesting(apiKey: IterableApiCriteriaFetchTests.apiKey,
                                          config: config,
@@ -85,7 +85,7 @@ class IterableApiCriteriaFetchTests: XCTestCase {
 
         let config = IterableConfig()
         config.enableAnonActivation = true
-        config.enableOnForegroundCriteriaFetching = false
+        config.enableForegroundCriteriaFetch = false
 
         internalApi = InternalIterableAPI.initializeForTesting(
             config: config,
@@ -124,7 +124,7 @@ class IterableApiCriteriaFetchTests: XCTestCase {
 
         let config = IterableConfig()
         config.enableAnonActivation = true
-        config.enableOnForegroundCriteriaFetching = true
+        config.enableForegroundCriteriaFetch = true
 
         IterableAPI.initializeForTesting(apiKey: IterableApiCriteriaFetchTests.apiKey,
                                          config: config,

tests/unit-tests/UserMergeScenariosTests.swift

@@ -974,6 +974,49 @@ class UserMergeScenariosTests: XCTestCase, AuthProvider {
 
         waitForExpectations(timeout: 5, handler: nil)
     }
+    
+    func testCriteriaMetTwice() {
+        let config = IterableConfig()
+        config.enableAnonActivation = true
+        
+        let mockSession = MockNetworkSession()
+        
+        IterableAPI.initializeForTesting(apiKey: UserMergeScenariosTests.apiKey,
+                                         config: config,
+                                         networkSession: mockSession,
+                                         localStorage: localStorage)
+        
+        IterableAPI.logoutUser()
+        guard let jsonData = mockData.data(using: .utf8) else { return }
+        localStorage.criteriaData = jsonData
+        
+        IterableAPI.track(event: "testEvent")
+        IterableAPI.track(event: "testEvent")
+        
+        waitForDuration(seconds: 3)
+        
+        if let anonUser = localStorage.userIdAnnon {
+            XCTAssertFalse(anonUser.isEmpty, "Expected anon user nil")
+        } else {
+            XCTFail("Expected anon user nil but found")
+        }
+        
+        // Verify that anon session request was made exactly once
+        let anonSessionRequest = mockSession.getRequest(withEndPoint: Const.Path.trackAnonSession)
+        XCTAssertNotNil(anonSessionRequest, "Anonymous session request should not be nil")
+        
+        // Count total requests with anon session endpoint
+        let anonSessionRequests = mockSession.requests.filter { request in
+            request.url?.absoluteString.contains(Const.Path.trackAnonSession) == true
+        }
+        XCTAssertEqual(anonSessionRequests.count, 1, "Anonymous session should be called exactly once")
+
+        // Verify track events were made
+        let trackRequests = mockSession.requests.filter { request in
+            request.url?.absoluteString.contains(Const.Path.trackEvent) == true
+        }
+        XCTAssertEqual(trackRequests.count, 2, "Track event should be called twice")
+    }
 }