driver: bugfix

Using maybeToList will cause the accumulator to hold the trailing
bytes twice. This will result in the annotator grabbing the wrong
fragments in raw format. The messages will decode properly; however
if these raw fragments are forwarded to other peers, they will be
rejected and the remote will close the connection.

Author: crocodile-dentist

ouroboros-network-framework/changelog.d/20251003_091438_crocodile-dentist_bugfix_runannotateddecoder.md

@@ -0,0 +1,17 @@
+<!--
+A new scriv changelog fragment.
+
+Uncomment the section that is right (remove the HTML comment wrapper).
+For top level release notes, leave all the headers commented out.
+-->
+
+<!--
+### Breaking
+
+- A bullet item for the Breaking category.
+
+-->
+
+### Non-Breaking
+
+- bugfix `runAnnotatedDecoderWithChannel`

ouroboros-network-framework/src/Ouroboros/Network/Driver/Simple.hs

@@ -50,7 +50,6 @@ import Control.Monad.Class.MonadFork
 import Control.Monad.Class.MonadThrow
 import Control.Tracer (Tracer (..), contramap, traceWith)
 import Data.Functor.Identity (Identity (..))
-import Data.Maybe (maybeToList)
 
 
 -- $intro
@@ -327,7 +326,7 @@ runAnnotatedDecoderWithChannel
   -> DecodeStep bytes failure m (bytes -> a)
   -> m (Either failure (a, Maybe bytes))
 
-runAnnotatedDecoderWithChannel Channel{recv} bs0 = go (maybeToList bs0) bs0
+runAnnotatedDecoderWithChannel Channel{recv} = go []
   where
     go :: [bytes]
        -> Maybe bytes