Skip to content

[Peras 5] Adapt the HFC time translation layer for Peras #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Peras 5] Adapt the HFC time translation layer for Peras #1681

wants to merge 2 commits into from

Conversation

@tbagrel1
Copy link
Contributor

@tbagrel1 tbagrel1 commented Sep 12, 2025 •
edited by geo2a
Loading

Fixes tweag/cardano-peras#65

Changes

  • Changes in the HFC types:
    • EraParams now keeps track of an optional Peras round length.
    • Bound now keeps track of an optional Peras round number.
    • In the Serialise instances for EraParams and Bound, the encoders generate different CBOR depending on whether of not the Peras-relate components are present. The decoders act differently depending on the length of the CBOR list.
    • The EraSummary, while not modified directly, is now Peras-aware via EraParams and Bound:
      • in a valid summary, Peras round length must divide the epoch size. See the changes in EraSummarys haddock and in invariantSummary's implementation.
  • Changes in the HFC time translation queries:

    • Two new top-level queries are exposed from Ouroboros.Consensus.HardFork.History.Qry:

      perasRoundNoToSlot :: PerasRoundNo -> Qry SlotNo
slotToPerasRoundNo :: SlotNo -> Qry PerasRoundNo

    • add a roundtrip test that ensures that converting Peras round number to a slot and then back is an identity is added into the Test.Consensus.HardFork.Summary module.

    • add a Peras-specific test into Test.Consensus.HardFork.History module.

Suggested review order

Even though this PR affects many files, the bulk of the changes is localised. I suggest the following review order:

  • First review the datatype and codec changes in ouroboros-consensus/Ouroboros/Consensus/HardFork/History/EraParams.hs and ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/History/Summary.hs
  • Proceed to review the time translation query changes in ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/HardFork/History/Qry.hs
  • Then review the newly added tests in consensus-test/Test/Consensus/HardFork/History.hs and consensus-test/Test/Consensus/HardFork/Summary.hs

@tbagrel1 tbagrel1 changed the base branch from main to main-pr/object-diffusion September 12, 2025 14:34
@tbagrel1 tbagrel1 changed the title [Peras #5] Add new NodeToNode version and adapt the HFC time translation layer for Peras [Peras #5] Adapt the HFC time translation layer for Peras Sep 12, 2025
@amesgen amesgen added the peras label Sep 12, 2025
@tbagrel1 tbagrel1 force-pushed the main-pr/object-diffusion branch 3 times, most recently from 37a9f85 to 222f4be Compare September 18, 2025 09:25
@tbagrel1 tbagrel1 force-pushed the main-pr/hfc-era-peras branch 3 times, most recently from 3237d2a to c2b6bbf Compare September 18, 2025 09:47
@tbagrel1 tbagrel1 force-pushed the main-pr/object-diffusion branch from 222f4be to d47c331 Compare September 19, 2025 08:04
@tbagrel1 tbagrel1 force-pushed the main-pr/hfc-era-peras branch 2 times, most recently from c077a49 to 66e4657 Compare September 19, 2025 08:26
@tbagrel1 tbagrel1 changed the title [Peras #5] Adapt the HFC time translation layer for Peras [Peras 5] Adapt the HFC time translation layer for Peras Sep 25, 2025
@tbagrel1 tbagrel1 force-pushed the main-pr/object-diffusion branch from d47c331 to 918307c Compare September 26, 2025 13:47
@tbagrel1 tbagrel1 force-pushed the main-pr/object-diffusion branch 4 times, most recently from d9c165b to bef68f5 Compare October 22, 2025 11:20
@tbagrel1 tbagrel1 force-pushed the main-pr/object-diffusion branch from bef68f5 to 0c3b30f Compare November 7, 2025 13:42
@tbagrel1 tbagrel1 force-pushed the main-pr/hfc-era-peras branch from 66e4657 to 513188c Compare November 7, 2025 14:07
@tbagrel1 tbagrel1 force-pushed the main-pr/object-diffusion branch from 0c3b30f to 2e7a690 Compare November 7, 2025 17:58
@tbagrel1 tbagrel1 force-pushed the main-pr/hfc-era-peras branch from 513188c to f669223 Compare November 7, 2025 18:01
@tbagrel1 tbagrel1 force-pushed the main-pr/object-diffusion branch from 2e7a690 to 09669d1 Compare November 7, 2025 18:06
@tbagrel1 tbagrel1 force-pushed the main-pr/hfc-era-peras branch from f669223 to b0b9e89 Compare November 7, 2025 18:06
@tbagrel1 tbagrel1 force-pushed the main-pr/object-diffusion branch 2 times, most recently from 785b903 to 4188b8f Compare November 27, 2025 10:30
Base automatically changed from main-pr/object-diffusion to main November 27, 2025 16:18
@agustinmista agustinmista force-pushed the main-pr/hfc-era-peras branch 3 times, most recently from ea8fb7d to 000c0f8 Compare December 1, 2025 11:09
@agustinmista agustinmista marked this pull request as ready for review December 1, 2025 14:27
geo2a and others added 2 commits December 1, 2025 15:29
@geo2a @agustinmista
@amesgen @tbagrel1 @nbacquey @Niols
Adapt the HFC time translation layer for Peras
ebe9304 
- Add `PerasRoundLength`
- introduce the `PerasEnabled` datatype to track values
  are only used when Peras is enabled
- HFC: translate between Peras rounds and slots

Co-authored-by: Agustin Mista <agustin.mista@moduscreate.com>
Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
Co-authored-by: Georgy Lukyanov <georgy.lukyanov@iohk.io>
Co-authored-by: Thomas BAGREL <thomas.bagrel@tweag.io>
Co-authored-by: Nicolas BACQUEY <nicolas.bacquey@tweag.io>
Co-authored-by: Nicolas "Niols" Jeannerod <nicolas.jeannerod@moduscreate.com>
@tbagrel1 @agustinmista
@amesgen @geo2a @nbacquey @Niols
Add changelog entry
b7e6e1c 
Co-authored-by: Agustin Mista <agustin.mista@moduscreate.com>
Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io>
Co-authored-by: Georgy Lukyanov <georgy.lukyanov@iohk.io>
Co-authored-by: Thomas BAGREL <thomas.bagrel@tweag.io>
Co-authored-by: Nicolas BACQUEY <nicolas.bacquey@tweag.io>
Co-authored-by: Nicolas "Niols" Jeannerod <nicolas.jeannerod@moduscreate.com>
@agustinmista agustinmista force-pushed the main-pr/hfc-era-peras branch from 000c0f8 to b7e6e1c Compare December 1, 2025 14:30
@agustinmista agustinmista mentioned this pull request Dec 1, 2025
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nfrisby nfrisby Awaiting requested review from nfrisby nfrisby is a code owner

@jasagredo jasagredo Awaiting requested review from jasagredo jasagredo is a code owner

@amesgen amesgen Awaiting requested review from amesgen amesgen is a code owner

@fraser-iohk fraser-iohk Awaiting requested review from fraser-iohk fraser-iohk is a code owner

@dnadales dnadales Awaiting requested review from dnadales dnadales is a code owner

@geo2a geo2a Awaiting requested review from geo2a geo2a is a code owner

@bladyjoker bladyjoker Awaiting requested review from bladyjoker bladyjoker is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

peras

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tbagrel1 @amesgen @geo2a