Skip to content

Commit 44db8f1

Browse files
tbagrel1agustinmistaamesgengeo2anbacquey
committed
Change s-r-p for ouroboros-network to add ObjectDiffusion support
Also use defaultMiniProtocolParameters instead of hardcoded value in unstable-diffusion-testlib to account for newly defined parameters in the new `ouroboros-network` version. Also integrate `NodeToNodeV_16`. Co-authored-by: Agustin Mista <agustin.mista@moduscreate.com> Co-authored-by: Alexander Esgen <alexander.esgen@iohk.io> Co-authored-by: Georgy Lukyanov <georgy.lukyanov@iohk.io> Co-authored-by: Thomas BAGREL <thomas.bagrel@tweag.io> Co-authored-by: Nicolas BACQUEY <nicolas.bacquey@tweag.io> Co-authored-by: Nicolas "Niols" Jeannerod <nicolas.jeannerod@moduscreate.com>
1 parent 8eefcba commit 44db8f1

File tree

4 files changed

+15
-11
lines changed

4 files changed

+15
-11
lines changed

cabal.project

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,12 +80,20 @@ source-repository-package
8080
eras/byron/ledger/impl
8181
eras/byron/crypto
8282

83-
-- Backported version of https://github.com/IntersectMBO/ouroboros-network/pull/5161
83+
allow-newer:
84+
-- https://github.com/phadej/vec/issues/121
85+
, ral:QuickCheck
86+
, fin:QuickCheck
87+
, bin:QuickCheck
88+
89+
-- Using https://github.com/IntersectMBO/ouroboros-network/tree/peras-staging/pr-5202-v2
8490
source-repository-package
8591
type: git
8692
location: https://github.com/IntersectMBO/ouroboros-network
87-
tag: 1385b53cefb81e79553b6b0252537455833ea9c4
88-
--sha256: sha256-zZ7WsMfRs1fG16bmvI5vIh4fhQ8RGyEvYGLSWlrxpg0=
93+
tag: 0db8669b67982cba755e80bf2e413527def41244
94+
--sha256: sha256-vEO721Xab0RTVKFQFKal5VCV5y+OUzELo8+7Z8TETJQ=
8995
subdir:
96+
ouroboros-network
97+
ouroboros-network-protocols
9098
ouroboros-network-api
9199
ouroboros-network

ouroboros-consensus-cardano/src/ouroboros-consensus-cardano/Ouroboros/Consensus/Cardano/Node.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -430,6 +430,7 @@ instance
430430
Map.fromList $
431431
[ (NodeToNodeV_14, CardanoNodeToNodeVersion2)
432432
, (NodeToNodeV_15, CardanoNodeToNodeVersion2)
433+
, (NodeToNodeV_16, CardanoNodeToNodeVersion2)
433434
]
434435

435436
supportedNodeToClientVersions _ =

ouroboros-consensus-cardano/src/shelley/Ouroboros/Consensus/Shelley/Ledger/NetworkProtocolVersion.hs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ instance SupportedNetworkProtocolVersion (ShelleyBlock proto era) where
4848
Map.fromList
4949
[ (NodeToNodeV_14, ShelleyNodeToNodeVersion1)
5050
, (NodeToNodeV_15, ShelleyNodeToNodeVersion1)
51+
, (NodeToNodeV_16, ShelleyNodeToNodeVersion1)
5152
]
5253
supportedNodeToClientVersions _ =
5354
Map.fromList

ouroboros-consensus-diffusion/src/unstable-diffusion-testlib/Test/ThreadNet/Network.hs

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -123,8 +123,8 @@ import Ouroboros.Network.NodeToNode
123123
( ConnectionId (..)
124124
, ExpandedInitiatorContext (..)
125125
, IsBigLedgerPeer (..)
126-
, MiniProtocolParameters (..)
127126
, ResponderContext (..)
127+
, defaultMiniProtocolParameters
128128
)
129129
import Ouroboros.Network.PeerSelection.Governor
130130
( makePublicPeerSelectionStateVar
@@ -1056,13 +1056,7 @@ runThreadNetwork
10561056
, mempoolCapacityOverride = NoMempoolCapacityBytesOverride
10571057
, keepAliveRng = kaRng
10581058
, peerSharingRng = psRng
1059-
, miniProtocolParameters =
1060-
MiniProtocolParameters
1061-
{ chainSyncPipeliningHighMark = 4
1062-
, chainSyncPipeliningLowMark = 2
1063-
, blockFetchPipeliningMax = 10
1064-
, txSubmissionMaxUnacked = 1000 -- TODO ?
1065-
}
1059+
, miniProtocolParameters = defaultMiniProtocolParameters
10661060
, blockFetchConfiguration =
10671061
BlockFetchConfiguration
10681062
{ bfcMaxConcurrencyBulkSync = 1

0 commit comments

Comments
 (0)