Remove the failing test

Author: aniketd

eras/shelley/test-suite/test/Test/Cardano/Ledger/Shelley/RulesTests.hs

@@ -9,35 +9,19 @@
 module Test.Cardano.Ledger.Shelley.RulesTests (
   chainExamples,
   multisigExamples,
-  testTickF,
 ) where
 
-import Cardano.Ledger.BaseTypes (Network (..), StrictMaybe (..))
+import Cardano.Ledger.BaseTypes (Network (..))
 import Cardano.Ledger.Coin (Coin (..))
 import Cardano.Ledger.Core (hashScript)
 import Cardano.Ledger.Credential (pattern ScriptHashObj)
 import Cardano.Ledger.Keys (asWitness, hashKey)
 import Cardano.Ledger.Shelley (ShelleyEra)
-import Cardano.Ledger.Shelley.API (ShelleyTICK, ShelleyTICKF)
-import Cardano.Ledger.Shelley.LedgerState (
-  EpochState (..),
-  LedgerState (..),
-  NewEpochState (..),
-  UTxOState (..),
-  totalObligation,
-  utxosGovStateL,
- )
-import Cardano.Ledger.Shelley.RewardUpdate (PulsingRewUpdate (..), RewardUpdate (..))
 import Cardano.Ledger.Shelley.Rules (ShelleyUtxowPredFailure (..))
 import Cardano.Ledger.Shelley.TxBody (RewardAccount (..), Withdrawals (..))
-import Cardano.Ledger.Slot (EpochNo (..))
-import Cardano.Protocol.TPraos.API (GetLedgerView (..))
-import Control.State.Transition.Extended (TRC (..))
 import Data.Either (isRight)
 import qualified Data.Map.Strict as Map
-import Data.Maybe (fromMaybe)
 import qualified Data.Set as Set
-import Lens.Micro ((^.))
 import Test.Cardano.Ledger.Core.KeyPair (vKey)
 import Test.Cardano.Ledger.Shelley.Examples (testCHAINExample)
 import qualified Test.Cardano.Ledger.Shelley.Examples.Cast as Cast
@@ -62,10 +46,8 @@ import Test.Cardano.Ledger.Shelley.MultiSigExamples (
  )
 import Test.Cardano.Ledger.Shelley.Serialisation.EraIndepGenerators ()
 import Test.Cardano.Ledger.Shelley.Serialisation.Generators ()
-import Test.Cardano.Ledger.Shelley.Utils
 import Test.Tasty (TestTree, testGroup)
 import Test.Tasty.HUnit (Assertion, assertBool, testCase, (@?=))
-import Test.Tasty.QuickCheck (Property, discard, testProperty, (===))
 
 chainExamples :: TestTree
 chainExamples =
@@ -488,54 +470,3 @@ testRwdAliceSignsAlone''' =
         (Coin 0)
         [asWitness Cast.alicePay, asWitness Cast.bobPay]
     wits = Set.singleton $ hashScript @ShelleyEra bobOnly
-
--- | The reward aggregation bug described in the Shelley ledger spec in
--- section 17.4 (in the Errata) resulted in needing to use 'aggregatedRewards' to change
--- the behavior of how rewards are collected starting at protocol version 3.
--- Instead of collecting a `Coin` for each stake credential, we collect 'Set Reward'.
--- In major protocol version 2, it is impossible for this set to be empty, but sadly this
--- property is not enforced in the types. For this reason, the property test
--- 'propTickfPerservesLedgerView' removes these empty sets from an otherwise arbitrary
--- 'NewEpochState'.
-filterEmptyRewards :: NewEpochState ShelleyEra -> NewEpochState ShelleyEra
-filterEmptyRewards (NewEpochState el bprev bcur es ru pd stash) =
-  NewEpochState el bprev bcur es ru' pd stash
-  where
-    removeEmptyRewards = Map.filter $ not . Set.null
-    ru' = case ru of
-      SNothing -> SNothing
-      SJust (Pulsing _ _) -> SNothing
-      SJust (Complete rewardUpdate) ->
-        SJust . Complete $ rewardUpdate {rs = removeEmptyRewards (rs rewardUpdate)}
-
-setDepositsToObligation :: NewEpochState ShelleyEra -> NewEpochState ShelleyEra
-setDepositsToObligation nes = nes {nesEs = es {esLState = ls {lsUTxOState = utxoState}}}
-  where
-    es = nesEs nes
-    ls = esLState es
-    utxoState =
-      (lsUTxOState ls)
-        { utxosDeposited =
-            totalObligation
-              (lsCertState ls)
-              (utxoState ^. utxosGovStateL)
-        }
-
--- | This property test checks the correctness of the TICKF transation.
--- TICKF is used by the consensus layer to get a ledger view in a computationally
--- cheaper way than using the TICK rule.
--- Therefore TICKF and TICK need to compute the same ledger view.
-propTickfPerservesLedgerView :: NewEpochState ShelleyEra -> Property
-propTickfPerservesLedgerView nes =
-  let (EpochNo e) = nesEL nes
-      slot = slotFromEpoch (EpochNo $ e + 1)
-      nes' = setDepositsToObligation (filterEmptyRewards nes)
-      tickNes = runShelleyBase $ applySTSTest @(ShelleyTICK ShelleyEra) (TRC ((), nes', slot))
-      tickFNes = runShelleyBase $ applySTSTest @(ShelleyTICKF ShelleyEra) (TRC ((), nes', slot))
-   in fromMaybe discard $ do
-        Right tickNes' <- pure tickNes
-        Right tickFNes' <- pure tickFNes
-        pure $ currentLedgerView tickNes' === currentLedgerView tickFNes'
-
-testTickF :: TestTree
-testTickF = testProperty "TICKF properties" propTickfPerservesLedgerView

eras/shelley/test-suite/test/Tests.hs

@@ -16,7 +16,6 @@ import qualified Test.Cardano.Ledger.Shelley.Rules.Deposits as Deposits (tests)
 import qualified Test.Cardano.Ledger.Shelley.RulesTests as RulesTests (
   chainExamples,
   multisigExamples,
-  testTickF,
  )
 import qualified Test.Cardano.Ledger.Shelley.SafeHash as SafeHash (safeHashTest)
 import qualified Test.Cardano.Ledger.Shelley.Serialisation as Serialisation
@@ -52,7 +51,6 @@ defaultTests =
     , Serialisation.tests
     , RulesTests.chainExamples
     , RulesTests.multisigExamples
-    , RulesTests.testTickF
     , UnitTests.unitTests
     , SafeHash.safeHashTest
     ]