Off-by-one in the interpretation of the event length (#1585)

Author: rmkaplan

library/tedit/TEDIT-SELECTION

@@ -1,12 +1,12 @@
 (DEFINE-FILE-INFO PACKAGE "INTERLISP" READTABLE "INTERLISP" BASE 10)
 
-
(FILECREATED " 5-Mar-2024 15:07:12" {WMEDLEY}<library>tedit>TEDIT-SELECTION.;426
 125601 
+
(FILECREATED "16-Mar-2024 16:31:03" {MEDLEY}<library>tedit>TEDIT-SELECTION.;76
 125706 
 
       :EDIT-BY rmk
 
-      :CHANGES-TO (FNS \TEDIT.UPDATE.SEL)
+      :CHANGES-TO (FNS \SELPIECES)
 
-      :PREVIOUS-DATE " 4-Mar-2024 22:48:20" {WMEDLEY}<library>tedit>TEDIT-SELECTION.;425)
+      :PREVIOUS-DATE " 5-Mar-2024 15:07:12" {MEDLEY}<library>tedit>TEDIT-SELECTION.;75)
 
 
 (PRETTYCOMPRINT TEDIT-SELECTIONCOMS)
@@ -1851,7 +1851,8 @@
 (DEFINEQ
 
 (\SELPIECES

-  [LAMBDA (SEL/FIRSTCHAR LASTCHAR TEXTOBJ)
                   (* ; "Edited  4-Mar-2024 22:47 by rmk")


+  [LAMBDA (SEL/FIRSTCHAR LASTCHAR TEXTOBJ)
                   (* ; "Edited 16-Mar-2024 16:30 by rmk")


+                                                             (* ; "Edited  4-Mar-2024 22:47 by rmk")


                                                              (* ; "Edited 12-Dec-2023 12:06 by rmk")


                                                              (* ; "Edited 11-Dec-2023 10:05 by rmk")


                                                              (* ; "Edited  2-Jun-2023 20:36 by rmk")


@@ -1885,7 +1886,7 @@
                                      (SUB1 (FGETSEL SEL/FIRSTCHAR CHLIM)))]
            elseif
 (type?
 TEDITHISTORYEVENT SEL/FIRSTCHAR)
              then
 (SETQ FIRSTCHAR (GETTH SEL/FIRSTCHAR THCH#))
-                  (SETQ LASTCHAR (GETTH SEL/FIRSTCHAR THCHLIM))
+                  (SETQ LASTCHAR (SUB1 (GETTH SEL/FIRSTCHAR THCHLIM)))
            else
 (SETQ FIRSTCHAR SEL/FIRSTCHAR))
 
          (* ;; "Do the right first so that we retain the center piece when FIRTCHAR and LASTCHAR are in the same original piece.")

@@ -2111,23 +2112,23 @@
               (SHOULDNT)) finally
 (RETURN RESULT])
 )
 (DECLARE%: DONTCOPY
-  (FILEMAP (NIL (12813 14678 (\TEDIT.SELECTION.DEFPRINT 12823 . 14676)) (14679 15800 (
-\TEDIT.SET.GLOBAL.SELECTIONS 14689 . 15798)) (15837 24072 (TEDIT.SEL.AS.STRING 15847 . 17434) (
-TEDIT.SEL.AS.SEXPR 17436 . 18422) (TEDIT.SELECTALL 18424 . 18754) (TEDIT.SELECTED.PIECES 18756 . 20100
-) (\TEDIT.FIND.PROTECTED.END 20102 . 21591) (\TEDIT.FIND.PROTECTED.START 21593 . 23407) (
-\TEDIT.WORD.BOUND 23409 . 24070)) (24206 55670 (\TEDIT.EXTEND.SEL 24216 . 31192) (\TEDIT.SELECT 31194
- . 32576) (\TEDIT.SCAN.LINE 32578 . 40579) (\TEDIT.SCAN.LINE.WORD 40581 . 44701) (
-\TEDIT.SELECT.LINE.SCANNER 44703 . 51752) (\TEDIT.SELECT.OBJECT 51754 . 55668)) (55671 70565 (\FIXSEL 
-55681 . 66203) (\TEDIT.CHTOX 66205 . 69192) (\TEDIT.COLLECTSELS 69194 . 70245) (\TEDIT.SELECTION.UNSET
- 70247 . 70563)) (70566 73705 (TEDIT.RESET.EXTEND.PENDING.DELETE 70576 . 71413) (\TEDIT.SET.SEL.LOOKS 
-71415 . 73703)) (73706 95087 (\SHOWSEL 73716 . 77434) (\TEDIT.SHOWSEL.HILIGHT 77436 . 80949) (
-\TEDIT.UPDATE.SHOWSEL 80951 . 87264) (\TEDIT.REFRESH.SHOWSEL 87266 . 89502) (\TEDIT.UPDATE.SEL 89504
- . 92626) (\TEDIT.SEL.L1 92628 . 92916) (\TEDIT.SEL.LN 92918 . 93206) (\TEDIT.SEL.DELETEDCHARS 93208
- . 95085)) (95088 98176 (\COPYSEL 95098 . 96786) (\TEDIT.SEL.CHANGED? 96788 . 98174)) (98229 108797 (
-TEDIT.GETPOINT 98239 . 99188) (TEDIT.GETSEL 99190 . 99510) (TEDIT.GETSEL.PARA 99512 . 100461) (
-TEDIT.MAKESEL 100463 . 101445) (TEDIT.SCANSEL 101447 . 102121) (TEDIT.SET.SEL.LOOKS 102123 . 103004) (
-TEDIT.SETSEL 103006 . 107972) (TEDIT.SHOWSEL 107974 . 108795)) (108825 125578 (\SELPIECES 108835 . 
-111812) (\SELPIECES.COPY 111814 . 113683) (\SELPIECES.CONCAT 113685 . 115558) (
-\SELPIECES.CHARTRANSFORM 115560 . 118580) (\SELPIECES.FROM.STRING 118582 . 123497) (
-\SELPIECES.TO.STRING 123499 . 125576)))))
+  (FILEMAP (NIL (12802 14667 (\TEDIT.SELECTION.DEFPRINT 12812 . 14665)) (14668 15789 (
+\TEDIT.SET.GLOBAL.SELECTIONS 14678 . 15787)) (15826 24061 (TEDIT.SEL.AS.STRING 15836 . 17423) (
+TEDIT.SEL.AS.SEXPR 17425 . 18411) (TEDIT.SELECTALL 18413 . 18743) (TEDIT.SELECTED.PIECES 18745 . 20089
+) (\TEDIT.FIND.PROTECTED.END 20091 . 21580) (\TEDIT.FIND.PROTECTED.START 21582 . 23396) (
+\TEDIT.WORD.BOUND 23398 . 24059)) (24195 55659 (\TEDIT.EXTEND.SEL 24205 . 31181) (\TEDIT.SELECT 31183
+ . 32565) (\TEDIT.SCAN.LINE 32567 . 40568) (\TEDIT.SCAN.LINE.WORD 40570 . 44690) (
+\TEDIT.SELECT.LINE.SCANNER 44692 . 51741) (\TEDIT.SELECT.OBJECT 51743 . 55657)) (55660 70554 (\FIXSEL 
+55670 . 66192) (\TEDIT.CHTOX 66194 . 69181) (\TEDIT.COLLECTSELS 69183 . 70234) (\TEDIT.SELECTION.UNSET
+ 70236 . 70552)) (70555 73694 (TEDIT.RESET.EXTEND.PENDING.DELETE 70565 . 71402) (\TEDIT.SET.SEL.LOOKS 
+71404 . 73692)) (73695 95076 (\SHOWSEL 73705 . 77423) (\TEDIT.SHOWSEL.HILIGHT 77425 . 80938) (
+\TEDIT.UPDATE.SHOWSEL 80940 . 87253) (\TEDIT.REFRESH.SHOWSEL 87255 . 89491) (\TEDIT.UPDATE.SEL 89493
+ . 92615) (\TEDIT.SEL.L1 92617 . 92905) (\TEDIT.SEL.LN 92907 . 93195) (\TEDIT.SEL.DELETEDCHARS 93197
+ . 95074)) (95077 98165 (\COPYSEL 95087 . 96775) (\TEDIT.SEL.CHANGED? 96777 . 98163)) (98218 108786 (
+TEDIT.GETPOINT 98228 . 99177) (TEDIT.GETSEL 99179 . 99499) (TEDIT.GETSEL.PARA 99501 . 100450) (
+TEDIT.MAKESEL 100452 . 101434) (TEDIT.SCANSEL 101436 . 102110) (TEDIT.SET.SEL.LOOKS 102112 . 102993) (
+TEDIT.SETSEL 102995 . 107961) (TEDIT.SHOWSEL 107963 . 108784)) (108814 125683 (\SELPIECES 108824 . 
+111917) (\SELPIECES.COPY 111919 . 113788) (\SELPIECES.CONCAT 113790 . 115663) (
+\SELPIECES.CHARTRANSFORM 115665 . 118685) (\SELPIECES.FROM.STRING 118687 . 123602) (
+\SELPIECES.TO.STRING 123604 . 125681)))))
 STOP