Skip to content

Commit 3d09555

Browse files
committed
Removes assigned-but-not-used rval in DSK_getfilename and redundant test of current_len in conc_dir_and_name
1 parent 8ad8b4d commit 3d09555

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/dsk.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -965,7 +965,7 @@ LispPTR DSK_getfilename(LispPTR *args)
965965
dirp = 1;
966966
} else {
967967
conc_dir_and_name(dir, name, aname, sizeof(aname));
968-
if ((rval = true_name(aname, sizeof(aname))) == -1) {
968+
if (true_name(aname, sizeof(aname)) == -1) {
969969
strlcpy(vname, aname, sizeof(vname));
970970
dirp = 1;
971971
} else {
@@ -995,7 +995,7 @@ LispPTR DSK_getfilename(LispPTR *args)
995995
dirp = 0;
996996
} else {
997997
conc_dir_and_name(dir, name, aname, sizeof(aname));
998-
if ((rval = true_name(aname, sizeof(aname))) == -1) {
998+
if (true_name(aname, sizeof(aname)) == -1) {
999999
strlcpy(vname, aname, sizeof(vname));
10001000
dirp = 1;
10011001
} else {
@@ -2561,7 +2561,7 @@ void conc_dir_and_name(char *dir, char *name, char *fname, size_t fname_size)
25612561
current_len = strlen(fname);
25622562

25632563
/* Ensure the directory has a final slash */
2564-
if ((current_len == 0) || (current_len > 0 && fname[current_len - 1] != '/')) {
2564+
if ((current_len == 0) || (fname[current_len - 1] != '/')) {
25652565
strlcat(fname, "/", fname_size);
25662566
}
25672567

0 commit comments

Comments
 (0)