Prioritize batch rendering based on weight for smart glasses' overlay objects to fix rendering order issues. Add weight to object renderers and adjust transparency handling.

Author: SirEndii

src/main/java/de/srendi/advancedperipherals/client/ClientRegistry.java

@@ -20,6 +20,7 @@
 import net.minecraftforge.client.event.ModelEvent;
 import net.minecraftforge.client.event.RegisterGuiOverlaysEvent;
 import net.minecraftforge.client.event.RegisterKeyMappingsEvent;
+import net.minecraftforge.eventbus.api.EventPriority;
 import net.minecraftforge.eventbus.api.SubscribeEvent;
 import net.minecraftforge.fml.common.Mod;
 import net.minecraftforge.fml.event.lifecycle.FMLClientSetupEvent;
@@ -72,9 +73,9 @@ public static void registeringRenderers(EntityRenderersEvent.RegisterRenderers e
         event.registerBlockEntityRenderer(APBlockEntityTypes.DISTANCE_DETECTOR.get(), DistanceDetectorRenderer::new);
     }
 
-    @SubscribeEvent
+    @SubscribeEvent(priority = EventPriority.LOWEST)
     public static void registeringOverlays(RegisterGuiOverlaysEvent event) {
         event.registerAboveAll(SaddleTurtleScreen.ID, SADDLE_TURTLE_OVERLAY);
-        event.registerBelowAll(OverlayModuleOverlay.ID, OVERLAY_MODULE_OVERLAY);
+        event.registerAboveAll(OverlayModuleOverlay.ID, OVERLAY_MODULE_OVERLAY);
     }
 }

src/main/java/de/srendi/advancedperipherals/client/smartglasses/OverlayModuleOverlay.java

@@ -3,13 +3,16 @@
 import com.mojang.blaze3d.vertex.PoseStack;
 import de.srendi.advancedperipherals.client.smartglasses.objects.twodim.ITwoDObjectRenderer;
 import de.srendi.advancedperipherals.common.smartglasses.modules.overlay.objects.RenderableObject;
+import de.srendi.advancedperipherals.common.smartglasses.modules.overlay.objects.two_dim.RectangleObject;
+import de.srendi.advancedperipherals.common.smartglasses.modules.overlay.objects.two_dim.TextObject;
 import net.minecraftforge.client.gui.overlay.ForgeGui;
 import net.minecraftforge.client.gui.overlay.IGuiOverlay;
 
 import java.util.ArrayList;
 import java.util.HashMap;
 import java.util.List;
 import java.util.Map;
+import java.util.TreeMap;
 
 public class OverlayModuleOverlay implements IGuiOverlay {
     public static final String ID = "overlay_module_overlay";
@@ -18,28 +21,34 @@ public class OverlayModuleOverlay implements IGuiOverlay {
     public void render(ForgeGui gui, PoseStack poseStack, float partialTick, int screenWidth, int screenHeight) {
         poseStack.pushPose();
 
-        Map<Class<? extends RenderableObject>, List<RenderableObject>> batches = new HashMap<>();
+        Map<Integer, Map<Class<? extends RenderableObject>, List<RenderableObject>>> prioritizedBatches = new TreeMap<>();
 
         for (RenderableObject object : OverlayObjectHolder.getObjects()) {
-            if (!object.isEnabled() || !(object.getRenderObject() instanceof ITwoDObjectRenderer))
+            if (!object.isEnabled() || !(object.getRenderObject() instanceof ITwoDObjectRenderer)) {
                 continue;
+            }
 
+            // We need to sort the objects by their weight, some things can't be rendered before something else.
+            // For example, when texts are rendered before our circles, rectangles, etc., the other objects can't be transparent anymore
+            int weight = object.getRenderObject().getWeight();
             Class<? extends RenderableObject> objectClass = object.getClass();
 
-            if (batches.containsKey(objectClass)) {
-                batches.get(objectClass).add(object);
-                continue;
-            }
+            // Get or create the batch map for the current weight
+            Map<Class<? extends RenderableObject>, List<RenderableObject>> batchesForWeight = prioritizedBatches.computeIfAbsent(weight, k -> new HashMap<>());
 
-            List<RenderableObject> newBatchArray = new ArrayList<>();
-            newBatchArray.add(object);
-            batches.put(objectClass, newBatchArray);
-        }
+            List<RenderableObject> batch = batchesForWeight.computeIfAbsent(objectClass, k -> new ArrayList<>());
 
-        for (List<RenderableObject> batch : batches.values()) {
-            ((ITwoDObjectRenderer) batch.get(0).getRenderObject()).renderBatch(batch, gui, poseStack, partialTick, screenWidth, screenHeight);
+            batch.add(object);
         }
 
+        for (Map<Class<? extends RenderableObject>, List<RenderableObject>> batchesForWeight : prioritizedBatches.values()) {
+            for (List<RenderableObject> batch : batchesForWeight.values()) {
+
+                if (!batch.isEmpty()) {
+                    ((ITwoDObjectRenderer) batch.get(0).getRenderObject()).renderBatch(batch, gui, poseStack, partialTick, screenWidth, screenHeight);
+                }
+            }
+        }
         poseStack.popPose();
 
     }

src/main/java/de/srendi/advancedperipherals/client/smartglasses/objects/IObjectRenderer.java

@@ -1,4 +1,13 @@
 package de.srendi.advancedperipherals.client.smartglasses.objects;
 
 public interface IObjectRenderer {
+    /**
+     * Get the weight of the renderer. Lower weight means higher priority and it will render first.
+     * Some things need to be rendered before others to prevent color and opacity issues.
+     * @return the weight of the renderer.
+     */
+    default int getWeight() {
+        return 100;
+    }
+
 }

src/main/java/de/srendi/advancedperipherals/client/smartglasses/objects/twodim/RectangleRenderer.java

@@ -21,19 +21,24 @@ public class RectangleRenderer implements ITwoDObjectRenderer {
     public void renderBatch(List<RenderableObject> objects, ForgeGui gui, PoseStack poseStack, float partialTick, int screenWidth, int screenHeight) {
         RenderSystem.setShader(GameRenderer::getPositionColorShader);
         BufferBuilder bufferbuilder = Tesselator.getInstance().getBuilder();
-        Matrix4f matrix = poseStack.last().pose();
+
         bufferbuilder.begin(VertexFormat.Mode.QUADS, DefaultVertexFormat.POSITION_COLOR);
 
         for (RenderableObject obj : objects) {
+            poseStack.pushPose();
+            Matrix4f matrix = poseStack.last().pose();
+
             float alpha = obj.opacity;
             float red = RenderUtil.getRed(obj.color);
             float green = RenderUtil.getGreen(obj.color);
             float blue = RenderUtil.getBlue(obj.color);
 
-            bufferbuilder.vertex(matrix, obj.x, obj.maxY, obj.z).color(red, green, blue, 0.0001f).endVertex();
-            bufferbuilder.vertex(matrix, obj.maxX, obj.maxY, obj.z).color(red, green, blue, 0.00f).endVertex();
-            bufferbuilder.vertex(matrix, obj.maxX, obj.y, obj.z).color(red, green, blue, 0.0f).endVertex();
-            bufferbuilder.vertex(matrix, obj.x, obj.y, obj.z).color(red, green, blue, 0f).endVertex();
+            bufferbuilder.vertex(matrix, obj.x, obj.maxY, obj.z).color(red, green, blue, alpha).endVertex();
+            bufferbuilder.vertex(matrix, obj.maxX, obj.maxY, obj.z).color(red, green, blue, alpha).endVertex();
+            bufferbuilder.vertex(matrix, obj.maxX, obj.y, obj.z).color(red, green, blue, alpha).endVertex();
+            bufferbuilder.vertex(matrix, obj.x, obj.y, obj.z).color(red, green, blue, alpha).endVertex();
+            poseStack.popPose();
+
         }
 
         BufferUploader.drawWithShader(bufferbuilder.end());

src/main/java/de/srendi/advancedperipherals/client/smartglasses/objects/twodim/TextRenderer.java

@@ -24,13 +24,17 @@ public void renderBatch(List<RenderableObject> objects, ForgeGui gui, PoseStack
                 x -= (minecraft.font.width(text.content) * text.fontSize) / 2f;
             }
 
-            if (text.shadow) {
+            if (!text.shadow) {
                 minecraft.font.drawShadow(poseStack, text.content, x / text.fontSize, text.y / text.fontSize, text.color);
             } else {
                 minecraft.font.draw(poseStack, text.content, x / text.fontSize, text.y / text.fontSize, text.color);
             }
             poseStack.popPose();
         }
+    }
 
+    @Override
+    public int getWeight() {
+        return 110;
     }
 }