Merge pull request #78 from IntelPython/fix-plan

Raise NotImplementedError exception instead of ValueError for non-default plan parameters in scipy fft backend

Author: oleksandr-pavlyk

conda-recipe/meta.yaml

@@ -1,4 +1,4 @@
-{% set version = "1.3.3" %}
+{% set version = "1.3.4" %}
 {% set buildnumber = 0 %}
 
 package:

mkl_fft/_scipy_fft_backend.py

@@ -186,8 +186,8 @@ def _check_norm(norm):
 def _check_plan(plan):
     if plan is None:
         return
-    raise ValueError(
-        f"Value plan={plan} is currently not supported"
+    raise NotImplementedError(
+        f"Passing a precomputed plan with value={plan} is currently not supported"
     )
 
 

mkl_fft/_version.py

@@ -1 +1 @@
-__version__ = '1.3.3'
+__version__ = '1.3.4'

mkl_fft/tests/test_interfaces.py

@@ -136,6 +136,6 @@ def test_scipy_fft_arg_validate():
     with pytest.raises(ValueError):
         mfi.scipy_fft.fft([1,2,3,4], norm=b"invalid")
 
-    with pytest.raises(ValueError):
+    with pytest.raises(NotImplementedError):
         mfi.scipy_fft.fft([1,2,3,4], plan="magic")