Skip to content

Commit c652167

Browse files
committed
remove redundant bitwise function tests
1 parent 52ab452 commit c652167

File tree

6 files changed

+6
-258
lines changed

6 files changed

+6
-258
lines changed

dpctl/tests/elementwise/test_bitwise_and.py

Lines changed: 1 addition & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626

2727
@pytest.mark.parametrize("op_dtype", _integral_dtypes)
28-
def test_bitwise_and_dtype_matrix_contig(op_dtype):
28+
def test_bitwise_and_dtype_matrix(op_dtype):
2929
q = get_queue_or_skip()
3030
skip_if_dtype_not_supported(op_dtype, q)
3131

@@ -50,32 +50,6 @@ def test_bitwise_and_dtype_matrix_contig(op_dtype):
5050
assert (r_np == dpt.asnumpy(r)).all()
5151

5252

53-
@pytest.mark.parametrize("op_dtype", _integral_dtypes)
54-
def test_bitwise_and_dtype_matrix_strided(op_dtype):
55-
q = get_queue_or_skip()
56-
skip_if_dtype_not_supported(op_dtype, q)
57-
58-
sz = 11
59-
n = 2 * sz
60-
dt1 = dpt.dtype(op_dtype)
61-
dt2 = dpt.dtype(op_dtype)
62-
63-
x1_range_begin = -sz if dpt.iinfo(dt1).min < 0 else 0
64-
x1 = dpt.arange(x1_range_begin, x1_range_begin + n, dtype=dt1)[::2]
65-
66-
x2_range_begin = -(sz // 2) if dpt.iinfo(dt2).min < 0 else 0
67-
x2 = dpt.arange(x2_range_begin, x2_range_begin + n, dtype=dt1)[::-2]
68-
69-
r = dpt.bitwise_and(x1, x2)
70-
assert isinstance(r, dpt.usm_ndarray)
71-
72-
x1_np = np.arange(x1_range_begin, x1_range_begin + n, dtype=op_dtype)[::2]
73-
x2_np = np.arange(x2_range_begin, x2_range_begin + n, dtype=op_dtype)[::-2]
74-
r_np = np.bitwise_and(x1_np, x2_np)
75-
76-
assert (r_np == dpt.asnumpy(r)).all()
77-
78-
7953
def test_bitwise_and_bool():
8054
get_queue_or_skip()
8155

@@ -88,18 +62,6 @@ def test_bitwise_and_bool():
8862
assert dpt.all(dpt.equal(r_bw, r_lo))
8963

9064

91-
@pytest.mark.parametrize("dtype", ["?"] + _integral_dtypes)
92-
def test_bitwise_and_inplace_python_scalar(dtype):
93-
q = get_queue_or_skip()
94-
skip_if_dtype_not_supported(dtype, q)
95-
X = dpt.zeros((10, 10), dtype=dtype, sycl_queue=q)
96-
dt_kind = X.dtype.kind
97-
if dt_kind == "b":
98-
X &= False
99-
else:
100-
X &= int(0)
101-
102-
10365
@pytest.mark.parametrize("op1_dtype", ["?"] + _integral_dtypes)
10466
@pytest.mark.parametrize("op2_dtype", ["?"] + _integral_dtypes)
10567
def test_bitwise_and_inplace_dtype_matrix(op1_dtype, op2_dtype):

dpctl/tests/elementwise/test_bitwise_invert.py

Lines changed: 1 addition & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
import dpctl.tensor as dpt
2121
from dpctl.tests.helper import get_queue_or_skip, skip_if_dtype_not_supported
2222

23-
from .utils import _compare_dtypes, _integral_dtypes, _usm_types
23+
from .utils import _compare_dtypes, _integral_dtypes
2424

2525

2626
@pytest.mark.parametrize(
@@ -73,52 +73,6 @@ def test_bitwise_invert_dtype_matrix(op_dtype):
7373
assert dpt.all(dpt.equal(r, r3))
7474

7575

76-
@pytest.mark.parametrize("op_usm_type", _usm_types)
77-
def test_bitwise_invert_usm_type_matrix(op_usm_type):
78-
get_queue_or_skip()
79-
80-
sz = 128
81-
ar1 = dpt.asarray(
82-
np.random.randint(0, 2, sz), dtype="i4", usm_type=op_usm_type
83-
)
84-
85-
r = dpt.bitwise_invert(ar1)
86-
assert isinstance(r, dpt.usm_ndarray)
87-
assert r.usm_type == op_usm_type
88-
89-
90-
def test_bitwise_invert_order():
91-
get_queue_or_skip()
92-
93-
ar1 = dpt.ones((20, 20), dtype="i4", order="C")
94-
r1 = dpt.bitwise_invert(ar1, order="C")
95-
assert r1.flags.c_contiguous
96-
r2 = dpt.bitwise_invert(ar1, order="F")
97-
assert r2.flags.f_contiguous
98-
r3 = dpt.bitwise_invert(ar1, order="A")
99-
assert r3.flags.c_contiguous
100-
r4 = dpt.bitwise_invert(ar1, order="K")
101-
assert r4.flags.c_contiguous
102-
103-
ar1 = dpt.zeros((20, 20), dtype="i4", order="F")
104-
r1 = dpt.bitwise_invert(ar1, order="C")
105-
assert r1.flags.c_contiguous
106-
r2 = dpt.bitwise_invert(ar1, order="F")
107-
assert r2.flags.f_contiguous
108-
r3 = dpt.bitwise_invert(ar1, order="A")
109-
assert r3.flags.f_contiguous
110-
r4 = dpt.bitwise_invert(ar1, order="K")
111-
assert r4.flags.f_contiguous
112-
113-
ar1 = dpt.ones((40, 40), dtype="i4", order="C")[:20, ::-2]
114-
r4 = dpt.bitwise_invert(ar1, order="K")
115-
assert r4.strides == (20, -1)
116-
117-
ar1 = dpt.zeros((40, 40), dtype="i4", order="C")[:20, ::-2].mT
118-
r4 = dpt.bitwise_invert(ar1, order="K")
119-
assert r4.strides == (-1, 20)
120-
121-
12276
def test_bitwise_invert_large_boolean():
12377
get_queue_or_skip()
12478

dpctl/tests/elementwise/test_bitwise_left_shift.py

Lines changed: 1 addition & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
@pytest.mark.parametrize("op1_dtype", _integral_dtypes)
2828
@pytest.mark.parametrize("op2_dtype", _integral_dtypes)
29-
def test_bitwise_left_shift_dtype_matrix_contig(op1_dtype, op2_dtype):
29+
def test_bitwise_left_shift_dtype_matrix(op1_dtype, op2_dtype):
3030
q = get_queue_or_skip()
3131
skip_if_dtype_not_supported(op1_dtype, q)
3232
skip_if_dtype_not_supported(op2_dtype, q)
@@ -56,38 +56,6 @@ def test_bitwise_left_shift_dtype_matrix_contig(op1_dtype, op2_dtype):
5656
assert (dpt.asnumpy(r) == r_np).all()
5757

5858

59-
@pytest.mark.parametrize("op1_dtype", _integral_dtypes)
60-
@pytest.mark.parametrize("op2_dtype", _integral_dtypes)
61-
def test_bitwise_left_shift_dtype_matrix_strided(op1_dtype, op2_dtype):
62-
q = get_queue_or_skip()
63-
skip_if_dtype_not_supported(op1_dtype, q)
64-
skip_if_dtype_not_supported(op2_dtype, q)
65-
66-
if op1_dtype != op2_dtype and "u8" in [op1_dtype, op2_dtype]:
67-
return
68-
69-
sz = 11
70-
n = 2 * sz
71-
dt1 = dpt.dtype(op1_dtype)
72-
dt2 = dpt.dtype(op2_dtype)
73-
74-
x1_range_begin = -sz if dpt.iinfo(dt1).min < 0 else 0
75-
x1 = dpt.arange(x1_range_begin, x1_range_begin + n, dtype=dt1)[::-2]
76-
x2 = dpt.arange(0, n, dtype=dt2)[::2]
77-
78-
r = dpt.bitwise_left_shift(x1, x2)
79-
assert isinstance(r, dpt.usm_ndarray)
80-
assert r.sycl_queue == x1.sycl_queue
81-
assert r.sycl_queue == x2.sycl_queue
82-
83-
x1_np = np.arange(x1_range_begin, x1_range_begin + n, dtype=dt1)[::-2]
84-
x2_np = np.arange(0, n, dtype=dt2)[::2]
85-
r_np = np.left_shift(x1_np, x2_np)
86-
87-
assert r.dtype == r_np.dtype
88-
assert (dpt.asnumpy(r) == r_np).all()
89-
90-
9159
@pytest.mark.parametrize("op_dtype", _integral_dtypes)
9260
def test_bitwise_left_shift_range(op_dtype):
9361
q = get_queue_or_skip()
@@ -100,14 +68,6 @@ def test_bitwise_left_shift_range(op_dtype):
10068
assert dpt.all(dpt.equal(z, 0))
10169

10270

103-
@pytest.mark.parametrize("dtype", _integral_dtypes)
104-
def test_bitwise_left_shift_inplace_python_scalar(dtype):
105-
q = get_queue_or_skip()
106-
skip_if_dtype_not_supported(dtype, q)
107-
X = dpt.zeros((10, 10), dtype=dtype, sycl_queue=q)
108-
X <<= int(0)
109-
110-
11171
@pytest.mark.parametrize("op1_dtype", _integral_dtypes)
11272
@pytest.mark.parametrize("op2_dtype", _integral_dtypes)
11373
def test_bitwise_left_shift_inplace_dtype_matrix(op1_dtype, op2_dtype):

dpctl/tests/elementwise/test_bitwise_or.py

Lines changed: 1 addition & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626

2727
@pytest.mark.parametrize("op_dtype", _integral_dtypes)
28-
def test_bitwise_or_dtype_matrix_contig(op_dtype):
28+
def test_bitwise_or_dtype_matrix(op_dtype):
2929
q = get_queue_or_skip()
3030
skip_if_dtype_not_supported(op_dtype, q)
3131

@@ -50,32 +50,6 @@ def test_bitwise_or_dtype_matrix_contig(op_dtype):
5050
assert (r_np == dpt.asnumpy(r)).all()
5151

5252

53-
@pytest.mark.parametrize("op_dtype", _integral_dtypes)
54-
def test_bitwise_or_dtype_matrix_strided(op_dtype):
55-
q = get_queue_or_skip()
56-
skip_if_dtype_not_supported(op_dtype, q)
57-
58-
sz = 11
59-
n = 2 * sz
60-
dt1 = dpt.dtype(op_dtype)
61-
dt2 = dpt.dtype(op_dtype)
62-
63-
x1_range_begin = -sz if dpt.iinfo(dt1).min < 0 else 0
64-
x1 = dpt.arange(x1_range_begin, x1_range_begin + n, dtype=dt1)[::2]
65-
66-
x2_range_begin = -(sz // 2) if dpt.iinfo(dt2).min < 0 else 0
67-
x2 = dpt.arange(x2_range_begin, x2_range_begin + n, dtype=dt1)[::-2]
68-
69-
r = dpt.bitwise_or(x1, x2)
70-
assert isinstance(r, dpt.usm_ndarray)
71-
72-
x1_np = np.arange(x1_range_begin, x1_range_begin + n, dtype=op_dtype)[::2]
73-
x2_np = np.arange(x2_range_begin, x2_range_begin + n, dtype=op_dtype)[::-2]
74-
r_np = np.bitwise_or(x1_np, x2_np)
75-
76-
assert (r_np == dpt.asnumpy(r)).all()
77-
78-
7953
def test_bitwise_or_bool():
8054
get_queue_or_skip()
8155

@@ -88,18 +62,6 @@ def test_bitwise_or_bool():
8862
assert dpt.all(dpt.equal(r_bw, r_lo))
8963

9064

91-
@pytest.mark.parametrize("dtype", ["?"] + _integral_dtypes)
92-
def test_bitwise_or_inplace_python_scalar(dtype):
93-
q = get_queue_or_skip()
94-
skip_if_dtype_not_supported(dtype, q)
95-
X = dpt.zeros((10, 10), dtype=dtype, sycl_queue=q)
96-
dt_kind = X.dtype.kind
97-
if dt_kind == "b":
98-
X |= False
99-
else:
100-
X |= int(0)
101-
102-
10365
@pytest.mark.parametrize("op1_dtype", ["?"] + _integral_dtypes)
10466
@pytest.mark.parametrize("op2_dtype", ["?"] + _integral_dtypes)
10567
def test_bitwise_or_inplace_dtype_matrix(op1_dtype, op2_dtype):

dpctl/tests/elementwise/test_bitwise_right_shift.py

Lines changed: 1 addition & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626

2727
@pytest.mark.parametrize("op1_dtype", _integral_dtypes)
2828
@pytest.mark.parametrize("op2_dtype", _integral_dtypes)
29-
def test_bitwise_right_shift_dtype_matrix_contig(op1_dtype, op2_dtype):
29+
def test_bitwise_right_shift_dtype_matrix(op1_dtype, op2_dtype):
3030
q = get_queue_or_skip()
3131
skip_if_dtype_not_supported(op1_dtype, q)
3232
skip_if_dtype_not_supported(op2_dtype, q)
@@ -56,58 +56,6 @@ def test_bitwise_right_shift_dtype_matrix_contig(op1_dtype, op2_dtype):
5656
assert (dpt.asnumpy(r) == r_np).all()
5757

5858

59-
@pytest.mark.parametrize("op1_dtype", _integral_dtypes)
60-
@pytest.mark.parametrize("op2_dtype", _integral_dtypes)
61-
def test_bitwise_right_shift_dtype_matrix_strided(op1_dtype, op2_dtype):
62-
q = get_queue_or_skip()
63-
skip_if_dtype_not_supported(op1_dtype, q)
64-
skip_if_dtype_not_supported(op2_dtype, q)
65-
66-
if op1_dtype != op2_dtype and "u8" in [op1_dtype, op2_dtype]:
67-
return
68-
69-
sz = 11
70-
n = 2 * sz
71-
dt1 = dpt.dtype(op1_dtype)
72-
dt2 = dpt.dtype(op2_dtype)
73-
74-
x1_range_begin = -sz if dpt.iinfo(dt1).min < 0 else 0
75-
x1 = dpt.arange(x1_range_begin, x1_range_begin + n, dtype=dt1)[::-2]
76-
x2 = dpt.arange(0, n, dtype=dt2)[::2]
77-
78-
r = dpt.bitwise_right_shift(x1, x2)
79-
assert isinstance(r, dpt.usm_ndarray)
80-
assert r.sycl_queue == x1.sycl_queue
81-
assert r.sycl_queue == x2.sycl_queue
82-
83-
x1_np = np.arange(x1_range_begin, x1_range_begin + n, dtype=dt1)[::-2]
84-
x2_np = np.arange(0, n, dtype=dt2)[::2]
85-
r_np = np.right_shift(x1_np, x2_np)
86-
87-
assert r.dtype == r_np.dtype
88-
assert (dpt.asnumpy(r) == r_np).all()
89-
90-
91-
@pytest.mark.parametrize("op_dtype", _integral_dtypes)
92-
def test_bitwise_right_shift_range(op_dtype):
93-
q = get_queue_or_skip()
94-
skip_if_dtype_not_supported(op_dtype, q)
95-
96-
x = dpt.ones(255, dtype=op_dtype)
97-
y = dpt.asarray(64, dtype=op_dtype)
98-
99-
z = dpt.bitwise_right_shift(x, y)
100-
assert dpt.all(dpt.equal(z, 0))
101-
102-
103-
@pytest.mark.parametrize("dtype", _integral_dtypes)
104-
def test_bitwise_right_shift_inplace_python_scalar(dtype):
105-
q = get_queue_or_skip()
106-
skip_if_dtype_not_supported(dtype, q)
107-
X = dpt.zeros((10, 10), dtype=dtype, sycl_queue=q)
108-
X >>= int(0)
109-
110-
11159
@pytest.mark.parametrize("op1_dtype", _integral_dtypes)
11260
@pytest.mark.parametrize("op2_dtype", _integral_dtypes)
11361
def test_bitwise_right_shift_inplace_dtype_matrix(op1_dtype, op2_dtype):

dpctl/tests/elementwise/test_bitwise_xor.py

Lines changed: 1 addition & 39 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@
2525

2626

2727
@pytest.mark.parametrize("op_dtype", _integral_dtypes)
28-
def test_bitwise_xor_dtype_matrix_contig(op_dtype):
28+
def test_bitwise_xor_dtype_matrix(op_dtype):
2929
q = get_queue_or_skip()
3030
skip_if_dtype_not_supported(op_dtype, q)
3131

@@ -50,32 +50,6 @@ def test_bitwise_xor_dtype_matrix_contig(op_dtype):
5050
assert (r_np == dpt.asnumpy(r)).all()
5151

5252

53-
@pytest.mark.parametrize("op_dtype", _integral_dtypes)
54-
def test_bitwise_xor_dtype_matrix_strided(op_dtype):
55-
q = get_queue_or_skip()
56-
skip_if_dtype_not_supported(op_dtype, q)
57-
58-
sz = 11
59-
n = 2 * sz
60-
dt1 = dpt.dtype(op_dtype)
61-
dt2 = dpt.dtype(op_dtype)
62-
63-
x1_range_begin = -sz if dpt.iinfo(dt1).min < 0 else 0
64-
x1 = dpt.arange(x1_range_begin, x1_range_begin + n, dtype=dt1)[::2]
65-
66-
x2_range_begin = -(sz // 2) if dpt.iinfo(dt2).min < 0 else 0
67-
x2 = dpt.arange(x2_range_begin, x2_range_begin + n, dtype=dt1)[::-2]
68-
69-
r = dpt.bitwise_xor(x1, x2)
70-
assert isinstance(r, dpt.usm_ndarray)
71-
72-
x1_np = np.arange(x1_range_begin, x1_range_begin + n, dtype=op_dtype)[::2]
73-
x2_np = np.arange(x2_range_begin, x2_range_begin + n, dtype=op_dtype)[::-2]
74-
r_np = np.bitwise_xor(x1_np, x2_np)
75-
76-
assert (r_np == dpt.asnumpy(r)).all()
77-
78-
7953
def test_bitwise_xor_bool():
8054
get_queue_or_skip()
8155

@@ -88,18 +62,6 @@ def test_bitwise_xor_bool():
8862
assert dpt.all(dpt.equal(r_bw, r_lo))
8963

9064

91-
@pytest.mark.parametrize("dtype", ["?"] + _integral_dtypes)
92-
def test_bitwise_xor_inplace_python_scalar(dtype):
93-
q = get_queue_or_skip()
94-
skip_if_dtype_not_supported(dtype, q)
95-
X = dpt.zeros((10, 10), dtype=dtype, sycl_queue=q)
96-
dt_kind = X.dtype.kind
97-
if dt_kind == "b":
98-
X ^= False
99-
else:
100-
X ^= int(0)
101-
102-
10365
@pytest.mark.parametrize("op1_dtype", ["?"] + _integral_dtypes)
10466
@pytest.mark.parametrize("op2_dtype", ["?"] + _integral_dtypes)
10567
def test_bitwise_xor_inplace_dtype_matrix(op1_dtype, op2_dtype):

0 commit comments

Comments
 (0)