Merge pull request #2097 from IntelPython/resolve-gh-1046

Resolve gh-1046

Author: ndgrigorian

dpctl/tensor/_ctors.py

@@ -111,8 +111,6 @@ def _asarray_from_usm_ndarray(
         raise TypeError(
             f"Expected dpctl.tensor.usm_ndarray, got {type(usm_ndary)}"
         )
-    if dtype is None:
-        dtype = usm_ndary.dtype
     if usm_type is None:
         usm_type = usm_ndary.usm_type
     if sycl_queue is not None:
@@ -122,6 +120,8 @@ def _asarray_from_usm_ndarray(
         copy_q = normalize_queue_device(sycl_queue=sycl_queue, device=exec_q)
     else:
         copy_q = usm_ndary.sycl_queue
+    if dtype is None:
+        dtype = _map_to_device_dtype(usm_ndary.dtype, copy_q)
     # Conditions for zero copy:
     can_zero_copy = copy is not True
     #    dtype is unchanged

dpctl/tests/test_tensor_asarray.py

@@ -623,3 +623,27 @@ def test_asarray_support_for_usm_ndarray_protocol(usm_type):
     assert x.dtype == y3.dtype
     assert y3.usm_data.reference_obj is None
     assert dpt.all(x[dpt.newaxis, :] == y3)
+
+
+@pytest.mark.parametrize("dt", [dpt.float16, dpt.float64, dpt.complex128])
+def test_asarray_to_device_with_unsupported_dtype(dt):
+    aspect = "fp16" if dt == dpt.float16 else "fp64"
+    try:
+        d0 = dpctl.select_device_with_aspects(aspect)
+    except dpctl.SyclDeviceCreationError:
+        pytest.skip("No device with aspect for test")
+    d1 = None
+    for d in dpctl.get_devices():
+        if d.default_selector_score < 0:
+            pass
+        try:
+            d1 = dpctl.select_device_with_aspects(
+                d.device_type.name, excluded_aspects=[aspect]
+            )
+        except dpctl.SyclDeviceCreationError:
+            pass
+    if d1 is None:
+        pytest.skip("No device with missing aspect for test")
+    x = dpt.ones(10, dtype=dt, device=d0)
+    y = dpt.asarray(x, device=d1)
+    assert y.sycl_device == d1