Skip to content

Commit 4a3ab99

Browse files
committed
update gen_coverage script to align with build_locally
1 parent 365cd43 commit 4a3ab99

File tree

3 files changed

+239
-201
lines changed

3 files changed

+239
-201
lines changed

scripts/_build_helper.py

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -70,25 +70,20 @@ def resolve_compilers(
7070

7171

7272
def make_cmake_args(
73-
build_type="Release",
7473
c_compiler=None,
7574
cxx_compiler=None,
7675
level_zero=True,
7776
glog=False,
78-
generator=None,
7977
verbose=False,
8078
other_opts="",
8179
):
8280
args = [
83-
f"-DCMAKE_BUILD_TYPE={build_type}",
8481
f"-DCMAKE_C_COMPILER:PATH={c_compiler}" if c_compiler else "",
8582
f"-DCMAKE_CXX_COMPILER:PATH={cxx_compiler}" if cxx_compiler else "",
8683
f"-DDPCTL_ENABLE_L0_PROGRAM_CREATION={'ON' if level_zero else 'OFF'}",
8784
f"-DDPTL_ENABLE_GLOG:BOOL={'ON' if glog else 'OFF'}",
8885
]
8986

90-
if generator:
91-
args.append(f"-G{generator}")
9287
if verbose:
9388
args.append("-DCMAKE_VERBOSE_MAKEFILE:BOOL=ON")
9489
if other_opts:
@@ -97,9 +92,18 @@ def make_cmake_args(
9792
return " ".join(filter(None, args))
9893

9994

100-
def build_extension(setup_dir, env):
95+
def build_extension(
96+
setup_dir, env, cmake_executable=None, generator=None, build_type=None
97+
):
98+
cmd = [sys.executable, "setup.py", "build_ext", "--inplace"]
99+
if cmake_executable:
100+
cmd.append(f"--cmake-executable={cmake_executable}")
101+
if generator:
102+
cmd.append(f"--generator={generator}")
103+
if build_type:
104+
cmd.append(f"--build-type={build_type}")
101105
run(
102-
[sys.executable, "setup.py", "build_ext", "--inplace"],
106+
cmd,
103107
env=env,
104108
cwd=setup_dir,
105109
)

scripts/build_locally.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,12 +161,10 @@ def main():
161161
level_zero_enabled = True
162162

163163
cmake_args = make_cmake_args(
164-
build_type=args.build_type,
165164
c_compiler=c_compiler,
166165
cxx_compiler=cxx_compiler,
167166
level_zero=level_zero_enabled,
168167
glog=args.glog,
169-
generator=args.generator,
170168
verbose=args.verbose,
171169
other_opts=args.cmake_opts,
172170
)
@@ -198,7 +196,13 @@ def main():
198196

199197
print("[build_locally] Building extensions in-place...")
200198

201-
build_extension(setup_dir, env)
199+
build_extension(
200+
setup_dir,
201+
env,
202+
cmake_executable=args.cmake_executable,
203+
generator=args.generator,
204+
build_type=args.build_type,
205+
)
202206
if not args.skip_editable:
203207
install_editable(setup_dir, env)
204208
else:

0 commit comments

Comments
 (0)