Refactor tests

Author: ethanhann

IntegrationEngine.Core.Tests/Storage/ElasticsearchRepositoryTest.cs

@@ -14,10 +14,21 @@ namespace IntegrationEngine.Core.Tests.Storage
 {
     public class ElasticsearchRepositoryTest : TestBase<ElasticsearchRepository>
     {
+        Mock<StubElasticClient> ElasticClient { get; set; }
+        Mock<ILog> Log { get; set; }
+
+        [SetUp]
+        public void Setup()
+        {
+            ElasticClient = new Mock<StubElasticClient>();
+            Subject.ElasticClient = ElasticClient.Object;
+            Log = new Mock<ILog>();
+            Subject.Log = Log.Object;
+        }
+
         [Test]
         public void ShouldReturnListOfDocumentsWithIdsFromElasticsearch()
         {
-            var elasticClient = new Mock<StubElasticClient>();
             var searchResponse = new Mock<StubSearchResponse<CronTrigger>>();
             var hits = new List<IHit<CronTrigger>>();
             var cronTrigger = new CronTrigger();
@@ -27,48 +38,44 @@ public void ShouldReturnListOfDocumentsWithIdsFromElasticsearch()
             hit.SetupGet(x => x.Id).Returns(() => expectedId);
             hits.Add(hit.Object);
             searchResponse.SetupGet(x => x.Hits).Returns(() => hits);
-            elasticClient.Setup(x => x.Search<CronTrigger>(It.IsAny<Func<SearchDescriptor<CronTrigger>, SearchDescriptor<CronTrigger>>>()))
+            ElasticClient.Setup(x => x.Search<CronTrigger>(It.IsAny<Func<SearchDescriptor<CronTrigger>, SearchDescriptor<CronTrigger>>>()))
                 .Returns(searchResponse.Object);
-            Subject.ElasticClient = elasticClient.Object;
+
 
             var actual = Subject.SelectAll<CronTrigger>();
 
             Assert.That(actual, Is.Not.Empty);
             Assert.That(actual.First().Id, Is.EqualTo(expectedId));
-            elasticClient.Verify(x => x.Search(It.IsAny<Func<SearchDescriptor<CronTrigger>, SearchDescriptor<CronTrigger>>>()), Times.Once);
+            ElasticClient.Verify(x => x.Search(It.IsAny<Func<SearchDescriptor<CronTrigger>, SearchDescriptor<CronTrigger>>>()), Times.Once);
         }
 
         [Test]
         public void ShouldReturnNullIfDocumentIsNotFoundById()
         {
-            var elasticClient = new Mock<StubElasticClient>();
             var getResponse = new Mock<StubGetResponse<CronTrigger>>();
-            elasticClient.Setup(x => x.Get(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()))
+            ElasticClient.Setup(x => x.Get(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()))
                 .Returns(getResponse.Object);
-            Subject.ElasticClient = elasticClient.Object;
 
             var actual = Subject.SelectById<CronTrigger>("1");
 
             Assert.That(actual, Is.Null);
-            elasticClient.Verify(x => x.Get(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()), Times.Once);
+            ElasticClient.Verify(x => x.Get(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()), Times.Once);
         }
 
         [Test]
         public void ShouldReturnSingleDocumentGivenAnId()
         {
-            var elasticClient = new Mock<StubElasticClient>();
             var getResponse = new Mock<StubGetResponse<CronTrigger>>();
             var expectedId = "1";
             getResponse.SetupGet(x => x.Id).Returns(() => expectedId);
             getResponse.SetupGet(x => x.Source).Returns(() => new CronTrigger());
-            elasticClient.Setup(x => x.Get(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()))
+            ElasticClient.Setup(x => x.Get(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()))
                 .Returns(getResponse.Object);
-            Subject.ElasticClient = elasticClient.Object;
 
             var actual = Subject.SelectById<CronTrigger>(expectedId);
 
             Assert.That(actual.Id, Is.EqualTo(expectedId));
-            elasticClient.Verify(x => x.Get(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()), Times.Once);
+            ElasticClient.Verify(x => x.Get(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()), Times.Once);
         }
 
         [Test]
@@ -77,22 +84,20 @@ public void ShouldInsertAndReturnDocument()
             var expected = new CronTrigger() {
                 Id = "1",
             };
-            var elasticClient = new Mock<StubElasticClient>();
             var getResponse = new Mock<StubGetResponse<CronTrigger>>();
             getResponse.SetupGet(x => x.Id).Returns(() => expected.Id);
             getResponse.SetupGet(x => x.Source).Returns(() => new CronTrigger());
-            elasticClient.Setup(x => x.Get<CronTrigger>(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()))
+            ElasticClient.Setup(x => x.Get<CronTrigger>(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()))
                 .Returns(getResponse.Object);
             var indexResponse = new Mock<StubIndexResponse>();
             indexResponse.SetupGet(x => x.Id).Returns(() => expected.Id);
-            elasticClient.Setup(x => x.Index(expected, It.IsAny<Func<IndexDescriptor<CronTrigger>, IndexDescriptor<CronTrigger>>>()))
+            ElasticClient.Setup(x => x.Index(expected, It.IsAny<Func<IndexDescriptor<CronTrigger>, IndexDescriptor<CronTrigger>>>()))
                 .Returns(indexResponse.Object);
-            Subject.ElasticClient = elasticClient.Object;
 
             var actual = Subject.Insert(expected);
 
             Assert.That(actual.Id, Is.EqualTo(expected.Id));
-            elasticClient.Verify(x => x.Index(expected, It.IsAny<Func<IndexDescriptor<CronTrigger>, IndexDescriptor<CronTrigger>>>()), Times.Once);
+            ElasticClient.Verify(x => x.Index(expected, It.IsAny<Func<IndexDescriptor<CronTrigger>, IndexDescriptor<CronTrigger>>>()), Times.Once);
         }
 
         [Test]
@@ -101,22 +106,20 @@ public void ShouldUpdateAndReturnDocument()
             var expected = new CronTrigger() {
                 Id = "1",
             };
-            var elasticClient = new Mock<StubElasticClient>();
             var getResponse = new Mock<StubGetResponse<CronTrigger>>();
             getResponse.SetupGet(x => x.Id).Returns(() => expected.Id);
             getResponse.SetupGet(x => x.Source).Returns(() => new CronTrigger());
-            elasticClient.Setup(x => x.Get<CronTrigger>(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()))
+            ElasticClient.Setup(x => x.Get<CronTrigger>(It.IsAny<Func<GetDescriptor<CronTrigger>, GetDescriptor<CronTrigger>>>()))
                 .Returns(getResponse.Object);
             var updateResponse = new Mock<StubUpdateResponse>();
             updateResponse.SetupGet(x => x.Id).Returns(() => expected.Id);
-            elasticClient.Setup(x => x.Update<CronTrigger>(It.IsAny<Func<UpdateDescriptor<CronTrigger, CronTrigger>, UpdateDescriptor<CronTrigger, CronTrigger>>>()))
+            ElasticClient.Setup(x => x.Update<CronTrigger>(It.IsAny<Func<UpdateDescriptor<CronTrigger, CronTrigger>, UpdateDescriptor<CronTrigger, CronTrigger>>>()))
                 .Returns(updateResponse.Object);
-            Subject.ElasticClient = elasticClient.Object;
 
             var actual = Subject.Update(expected);
 
             Assert.That(actual.Id, Is.EqualTo(expected.Id));
-            elasticClient.Verify(
+            ElasticClient.Verify(
                 x => x.Update<CronTrigger>(It.IsAny<Func<UpdateDescriptor<CronTrigger, CronTrigger>, UpdateDescriptor<CronTrigger, CronTrigger>>>()), 
                 Times.Once);
         }
@@ -125,25 +128,21 @@ public void ShouldUpdateAndReturnDocument()
         public void ShouldDeleteDocument()
         {
             var id = "1";
-            var elasticClient = new Mock<StubElasticClient>();
-            elasticClient.Setup(x => x.Delete(It.IsAny<Func<DeleteDescriptor<CronTrigger>, DeleteDescriptor<CronTrigger>>>()));
-            Subject.ElasticClient = elasticClient.Object;
+            ElasticClient.Setup(x => x.Delete(It.IsAny<Func<DeleteDescriptor<CronTrigger>, DeleteDescriptor<CronTrigger>>>()));
 
             Subject.Delete<CronTrigger>(id);
 
-            elasticClient.Verify(x => x.Delete(It.IsAny<Func<DeleteDescriptor<CronTrigger>, DeleteDescriptor<CronTrigger>>>()), Times.Once);
+            ElasticClient.Verify(x => x.Delete(It.IsAny<Func<DeleteDescriptor<CronTrigger>, DeleteDescriptor<CronTrigger>>>()), Times.Once);
         }
 
         [Test]
         public void ShouldShouldReturnTrueIfServerIsAvailable()
         {
-            var elasticClient = new Mock<StubElasticClient>();
             var elasticsearchResponse = new Mock<StubElasticsearchResponse>();
             elasticsearchResponse.SetupGet(x => x.Success).Returns(() => true);
             var pingResponse = new Mock<StubPingResponse>();
             pingResponse.SetupGet(x => x.ConnectionStatus).Returns(() => elasticsearchResponse.Object);
-            elasticClient.Setup(x => x.Ping(It.IsAny<PingRequest>())).Returns(pingResponse.Object);
-            Subject.ElasticClient = elasticClient.Object;
+            ElasticClient.Setup(x => x.Ping(It.IsAny<PingRequest>())).Returns(pingResponse.Object);
 
             var actual = Subject.IsServerAvailable();
 
@@ -153,13 +152,11 @@ public void ShouldShouldReturnTrueIfServerIsAvailable()
         [Test]
         public void ShouldShouldReturnFalseIfServerIsUnavailable()
         {
-            var elasticClient = new Mock<StubElasticClient>();
             var elasticsearchResponse = new Mock<StubElasticsearchResponse>();
             elasticsearchResponse.SetupGet(x => x.Success).Returns(() => false);
             var pingResponse = new Mock<StubPingResponse>();
             pingResponse.SetupGet(x => x.ConnectionStatus).Returns(() => elasticsearchResponse.Object);
-            elasticClient.Setup(x => x.Ping(It.IsAny<PingRequest>())).Returns(pingResponse.Object);
-            Subject.ElasticClient = elasticClient.Object;
+            ElasticClient.Setup(x => x.Ping(It.IsAny<PingRequest>())).Returns(pingResponse.Object);
 
             var actual = Subject.IsServerAvailable();
 
@@ -169,17 +166,13 @@ public void ShouldShouldReturnFalseIfServerIsUnavailable()
         [Test]
         public void ShouldShouldReturnFalseIfServerIsUnavailableBecauseExceptionOccured()
         {
-            var elasticClient = new Mock<StubElasticClient>();
-            elasticClient.Setup(x => x.Ping(It.IsAny<PingRequest>())).Returns<PingResponse>(null);
-            Subject.ElasticClient = elasticClient.Object;
-            var log = new Mock<ILog>();
-            log.Setup(x => x.Error(It.IsAny<Exception>()));
-            Subject.Log = log.Object;
+            ElasticClient.Setup(x => x.Ping(It.IsAny<PingRequest>())).Returns<PingResponse>(null);
+            Log.Setup(x => x.Error(It.IsAny<Exception>()));
 
             var actual = Subject.IsServerAvailable();
 
             Assert.That(actual, Is.False);
-            log.Verify(x => x.Error(It.IsAny<Exception>()), Times.Once);
+            Log.Verify(x => x.Error(It.IsAny<Exception>()), Times.Once);
         }
     }
 }