Refine logging internals and config

Author: ethanhann

IntegrationEngine.Core/Jobs/SqlJob.cs

@@ -29,7 +29,7 @@ public virtual IList<T> RunQuery<T>()
             } 
             catch(ArgumentException exception)
             {
-                Log.Error(exception.Message, exception);
+                Log.Error(exception);
             }
             return new List<T>();
         }

IntegrationEngine.Core/Mail/MailClient.cs

@@ -22,11 +22,13 @@ public MailClient (ILog log) : this()
         public void Send(MailMessage mailMessage)
         {
             ConfigureSmtpClient();
-            try {
-
+            try 
+            {
                 SmtpClient.Send(mailMessage);
-            } catch (Exception exception) {
-                Log.Error("Cannot send mail message", exception);
+            } 
+            catch (Exception exception) 
+            {
+                Log.Error(exception);
             }
         }
 

IntegrationEngine/EngineHostConfiguration.cs

@@ -38,8 +38,8 @@ public void Configure(IList<Assembly> assembliesWithJobs)
                         .SelectMany(x => x.GetTypes())
                         .Where(x => typeof(IIntegrationJob).IsAssignableFrom(x) && x.IsClass)
                         .ToList();
-            TryAndLogFailure("Loading Configuration", LoadConfiguration);
-            TryAndLogFailure("Setup Logging", SetupLogging);
+            LoadConfiguration();
+            SetupLogging();
             TryAndLogFailure("Setup Database Repository", SetupDatabaseRepository);
             TryAndLogFailure("Setup Mail Client", SetupMailClient);
             TryAndLogFailure("Setup Elastic Client", SetupElasticClient);
@@ -56,10 +56,10 @@ static void TryAndLogFailure(string description, Action action)
             {
                 action();
             }
-            catch (Exception ex)
+            catch (Exception exception)
             {
                 var log = Common.Logging.LogManager.GetLogger(typeof(EngineHost));
-                log.Error(description, ex);
+                log.Error(description, exception);
             }
         }
 
@@ -97,7 +97,6 @@ public void SetupMailClient()
                 MailConfiguration = Configuration.Mail,
                 Log = Container.Resolve<ILog>(),
             };
-
             Container.RegisterInstance<IMailClient>(mailClient);
         }
 

IntegrationEngine/MessageQueue/RabbitMqListener.cs

@@ -35,13 +35,13 @@ public void Listen()
                 var consumer = new QueueingBasicConsumer(channel);
                 channel.BasicConsume(MessageQueueConfiguration.QueueName, true, consumer);
 
-                Log.Info("Waiting for messages...");
+                Log.Info(x => x("Waiting for messages..."));
                 while (true)
                 {
                     var eventArgs = (BasicDeliverEventArgs)consumer.Queue.Dequeue();
                     var body = eventArgs.Body;
                     var message = Encoding.UTF8.GetString(body);
-                    Log.Info(string.Format("Received {0}", message));
+                    Log.Debug(x => x("Message queue listener received {0}", message));
                     if (IntegrationJobTypes != null && !IntegrationJobTypes.Any())
                         continue;
                     var type = IntegrationJobTypes.FirstOrDefault(t => t.FullName.Equals(message));

configuration/IntegrationEngine.nlog.xml

@@ -5,10 +5,12 @@
   <targets>
     <target name="logfile" xsi:type="File" fileName="IntegrationEngine.log.txt" />
     <target name="console" xsi:type="Console" />
+    <target name="mailServer" xsi:type="Mail" to="ethanhann@gmail.com" from="ethanhann@gmail.com" />
   </targets>
 
   <rules>
     <logger name="*" minlevel="Trace" writeTo="logfile" />
     <logger name="*" minlevel="Info" writeTo="console" />
+    <logger name="*" minlevel="Error" writeTo="mailServer" />
   </rules>
 </nlog>