Make plugin directory configurable

Author: ethanhann

src/InEngine.Core/InEngineSettings.cs

@@ -1,4 +1,5 @@
-using System.IO;
+using System.Collections.Generic;
+using System.IO;
 using InEngine.Core.Queue;
 using Microsoft.Extensions.Configuration;
 
@@ -8,6 +9,7 @@ public class InEngineSettings
     {
         public static string BasePath { get; set; } = Directory.GetCurrentDirectory();
         public static string ConfigurationFile { get; set; } = "appsettings.json";
+        public List<string> PluginDirectories { get; set; }
         public QueueSettings Queue { get; set; }
 
         public static InEngineSettings Make()

src/InEngine.Core/Plugin.cs

@@ -43,9 +43,14 @@ public List<T> Make<T>() where T : class, IPluginType
 
         public static List<Plugin> Discover<T>() where T : IPluginType
         {
-            var discoveredAssemblies = Directory
-                .GetFiles(".", "*.dll")
-                .Select(x => Assembly.LoadFrom(x));
+            var logger = LogManager.GetCurrentClassLogger();
+            var discoveredAssemblies = InEngineSettings.Make().PluginDirectories.SelectMany(x => {
+                if (!Directory.Exists(x)) {
+                    logger.Warn("Plugin directory does not exist: " + x);
+                    return new List<Assembly>();
+                }
+                return Directory.GetFiles(x, "*.dll").Select(y => Assembly.LoadFrom(y));                
+            });
             var pluginList = new List<Plugin>();
             foreach (var assembly in discoveredAssemblies)
             {
@@ -56,10 +61,10 @@ public static List<Plugin> Discover<T>() where T : IPluginType
                 }
                 catch (Exception exception)
                 {
-                    LogManager.GetCurrentClassLogger().Error(exception, "Error discovering plugins");
+                    logger.Error(exception, "Error discovering plugins");
                 }
             }
-            return pluginList;
+            return pluginList.OrderBy(x => x.Name).ToList();
         }
 
         public ICommand CreateCommandInstance(string fullCommandName)

src/InEngine/InEngine.csproj

@@ -6,6 +6,7 @@
   </PropertyGroup>
   <ItemGroup>
     <ProjectReference Include="..\InEngine.Core\InEngine.Core.csproj" />
+    <ProjectReference Include="..\InEngine.Commands\InEngine.Commands.csproj" />
   </ItemGroup>
   <ItemGroup>
     <PackageReference Include="NETStandard.Library" Version="2.0.1" />
@@ -33,6 +34,9 @@
     <None Update="appsettings.json">
       <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
     </None>
+    <None Update="Plugins\README.md">
+      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
+    </None>
   </ItemGroup>
   <ItemGroup>
     <Compile Include="..\SharedAssemblyInfo.cs">

src/InEngine/Plugins/.gitkeep

@@ -0,0 +1 @@
+This is the default location for 3rd party plugins.

src/InEngine/Plugins/README.md

@@ -1,6 +1,8 @@
 {
   "InEngine": {
+    "PluginDirectories": [ ".", "Plugins" ],
     "Queue": {
+      "CompressionEnabled": true,
       "PrimaryQueueConsumers":  16,
       "SecondaryQueueConsumers": 4,
       "QueueName": "InEngine:Queue",