Validate cron expression when updating CronTrigger

ethanhann · ethanhann · commit 6f927001dfa7 · 2015-01-15T22:09:39.000-05:00
diff --git a/IntegrationEngine/Api/Controllers/CronTriggerController.cs b/IntegrationEngine/Api/Controllers/CronTriggerController.cs
@@ -44,6 +44,8 @@ public IHttpActionResult PutCronTrigger(string id, CronTrigger trigger)
         {
             if (id != trigger.Id)
                 return BadRequest();
+            if (!trigger.CronExpressionString.IsValidCronExpression())
+                return BadRequest("Cron expression is not valid: " + trigger.CronExpressionString);
             Repository.Update(trigger);
             EngineScheduler.ScheduleJobWithCronTrigger(trigger);
             return StatusCode(HttpStatusCode.NoContent);

Original file line number	Diff line number	Diff line change
`@@ -44,6 +44,8 @@ public IHttpActionResult PutCronTrigger(string id, CronTrigger trigger)`
`44`	`44`	`{`
`45`	`45`	`if (id != trigger.Id)`
`46`	`46`	`return BadRequest();`
	`47`	`+ if (!trigger.CronExpressionString.IsValidCronExpression())`
	`48`	`+ return BadRequest("Cron expression is not valid: " + trigger.CronExpressionString);`
`47`	`49`	`Repository.Update(trigger);`
`48`	`50`	`EngineScheduler.ScheduleJobWithCronTrigger(trigger);`
`49`	`51`	`return StatusCode(HttpStatusCode.NoContent);`