Fix cron expression validation check

ethanhann · ethanhann · commit 0b6bfb6bcaa6 · 2015-01-15T22:05:39.000-05:00
diff --git a/IntegrationEngine/Api/Controllers/CronTriggerController.cs b/IntegrationEngine/Api/Controllers/CronTriggerController.cs
@@ -53,7 +53,7 @@ public IHttpActionResult PutCronTrigger(string id, CronTrigger trigger)
         [ResponseType(typeof(CronTrigger))]
         public IHttpActionResult PostCronTrigger(CronTrigger trigger)
         {
-            if (trigger.CronExpressionString.IsValidCronExpression())
+            if (!trigger.CronExpressionString.IsValidCronExpression())
                 return BadRequest("Cron expression is not valid: " + trigger.CronExpressionString);
             var triggerWithId = Repository.Insert(trigger);
             EngineScheduler.ScheduleJobWithCronTrigger(triggerWithId);

Original file line number	Diff line number	Diff line change
`@@ -53,7 +53,7 @@ public IHttpActionResult PutCronTrigger(string id, CronTrigger trigger)`
`53`	`53`	`[ResponseType(typeof(CronTrigger))]`
`54`	`54`	`public IHttpActionResult PostCronTrigger(CronTrigger trigger)`
`55`	`55`	`{`
`56`		`- if (trigger.CronExpressionString.IsValidCronExpression())`
	`56`	`+ if (!trigger.CronExpressionString.IsValidCronExpression())`
`57`	`57`	`return BadRequest("Cron expression is not valid: " + trigger.CronExpressionString);`
`58`	`58`	`var triggerWithId = Repository.Insert(trigger);`
`59`	`59`	`EngineScheduler.ScheduleJobWithCronTrigger(triggerWithId);`