-
Notifications
You must be signed in to change notification settings - Fork 156
fix(tabs): replace igx-icon with igc-icon in WC demo + fix theme parameters - 20.1.x #16416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 20.1.x
Are you sure you want to change the base?
Conversation
|
THEME: INDIGO |
|
@adrianptrv, the active background is still not working. I should be able to see the active background on the active tab in the idle state and the active hover background when I hover the active tab. igx-tabs,
igc-tabs {
@include css-vars-from-theme(
$theme: tabs-theme(
$schema: $schema,
$item-active-icon-color: green,
$item-active-hover-icon-color: blue,
$item-active-color: green,
$item-active-hover-color: blue,
$item-active-background: lightblue,
$item-active-hover-background: darkblue,
),
$name: 'ig-tabs',
);
} |
Closes 1915
Related WC PR: #1929
igx-iconwithigc-iconin the WC Tabs demo.$border-radiustheme parameter so it works correctly.$item-backgroundto apply only to Tab items instead of both Tab items and the Tab Header.Additional information (check all that apply):
Checklist:
feature/README.MDupdates for the feature docsREADME.MDCHANGELOG.MDupdates for newly added functionalityng updatemigrations for the breaking changes (migrations guidelines)