Define more broadcasting operations #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
- Coverage 78.76% 75.22% -3.55%
==========================================
Files 10 10
Lines 617 666 +49
==========================================
+ Hits 486 501 +15
- Misses 131 165 +34
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define more broadcasting operations. The strategy is to overload
Broadcast.broadcastedto canonicalize certain inputs involving linear algebra with scalars to map-compatible expressions. This helps fix issues when making block sparse arrays where blocks are Kronecker arrays, since blockwise broadcasting/mapping is defined by broadcasting across blocks as of ITensor/BlockSparseArrays.jl#150.Depends on ITensor/BlockSparseArrays.jl#152.