Skip to content

Conversation

@mtfishman
Copy link
Member

To do:

  • Generalize other operations.
  • Add tests.

@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 31.94444% with 49 lines in your changes missing coverage. Please review.

Project coverage is 7.38%. Comparing base (c297c03) to head (8bc96d1).
Report is 11 commits behind head on main.

Files with missing lines Patch % Lines
...ksparsearrayinterface/blocksparsearrayinterface.jl 7.69% 12 Missing ⚠️
src/blocksparsearray/blocksparsearray.jl 33.33% 10 Missing ⚠️
src/factorizations/svd.jl 0.00% 7 Missing ⚠️
...locksparsearray/wrappedabstractblocksparsearray.jl 68.75% 5 Missing ⚠️
src/blocksparsearrayinterface/arraylayouts.jl 0.00% 5 Missing ⚠️
...stractblocksparsearray/abstractblocksparsearray.jl 0.00% 3 Missing ⚠️
src/blocksparsearrayinterface/broadcast.jl 50.00% 3 Missing ⚠️
src/BlockArraysExtensions/blockedunitrange.jl 50.00% 2 Missing ⚠️
src/abstractblocksparsearray/map.jl 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (c297c03) and HEAD (8bc96d1). Click for more details.

HEAD has 7 uploads less than BASE
Flag BASE (c297c03) HEAD (8bc96d1)
docs 2 1
6 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #136       +/-   ##
==========================================
- Coverage   75.09%   7.38%   -67.71%     
==========================================
  Files          35      34        -1     
  Lines        1775    1800       +25     
==========================================
- Hits         1333     133     -1200     
- Misses        442    1667     +1225     
Flag Coverage Δ
docs 7.38% <31.94%> (+0.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mtfishman
Copy link
Member Author

This needs to be updated to reflect #137 and also can be simplified a bit once ITensor/TypeParameterAccessors.jl#51 lands.

Comment on lines +58 to +60
b = argmin(length, (brows[row], bcols[col]))
u_axes[col] = b
v_axes[col] = b
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to split this off into a separate PR.

@mtfishman
Copy link
Member Author

This has been split up into separate PRs so I'll close it.

@mtfishman mtfishman closed this Jun 19, 2025
@mtfishman mtfishman deleted the mf/kronecker_generalizations branch June 19, 2025 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants