Skip to content

Commit 6d7085d

Browse files
authored
Skip broken acoth tests (#180)
1 parent 1a474f5 commit 6d7085d

File tree

3 files changed

+10
-9
lines changed

3 files changed

+10
-9
lines changed

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,10 @@
99
.vscode/
1010
Manifest.toml
1111
benchmark/*.json
12+
dev/
13+
docs/LocalPreferences.toml
1214
docs/Manifest.toml
1315
docs/build/
1416
docs/src/index.md
17+
examples/LocalPreferences.toml
18+
test/LocalPreferences.toml

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
name = "BlockSparseArrays"
22
uuid = "2c9a651f-6452-4ace-a6ac-809f4280fbb4"
33
authors = ["ITensor developers <support@itensor.org> and contributors"]
4-
version = "0.10.5"
4+
version = "0.10.6"
55

66
[deps]
77
Adapt = "79e6a3ab-5dfb-504d-930d-738a2a938a0e"

test/test_factorizations.jl

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ using MatrixAlgebraKit:
3131
trunctol
3232
using Random: Random
3333
using StableRNGs: StableRNG
34-
using Test: @inferred, @test, @test_broken, @test_throws, @testset
34+
using Test: @inferred, @test, @test_throws, @testset
3535

3636
@testset "Matrix functions (T=$elt)" for elt in (Float32, Float64, ComplexF64)
3737
for matrixt in (Matrix, AbstractMatrix)
@@ -55,13 +55,10 @@ using Test: @inferred, @test, @test_broken, @test_throws, @testset
5555
for f in MATRIX_FUNCTIONS_LOW_ACCURACY
5656
@eval begin
5757
fa = $f($a)
58-
if !Sys.isapple() && ($elt <: Real)
59-
# `acoth` appears to be broken on this matrix on Windows and Ubuntu
60-
# for real matrices.
61-
@test_broken Matrix(fa) $f(Matrix($a)) rtol = eps(real($elt))
62-
else
63-
@test Matrix(fa) $f(Matrix($a)) rtol = eps(real($elt))
64-
end
58+
# `acoth` appears to be broken on this matrix on Windows and Ubuntu
59+
# for real matrices.
60+
skip = !Sys.isapple() && ($elt <: Real)
61+
@test Matrix(fa) $f(Matrix($a)) rtol = eps(real($elt)) skip = skip
6562
@test fa isa BlockSparseMatrix
6663
@test issetequal(eachblockstoredindex(fa), [Block(1, 1), Block(2, 2)])
6764
end

0 commit comments

Comments
 (0)