Remove fallback argument loading

Sem-Ver: api-break

Author: alvarolopez

deepaas/model/v2/wrapper.py

@@ -28,7 +28,6 @@
 
 from aiohttp import web
 import marshmallow
-from webargs import fields
 
 from oslo_config import cfg
 from oslo_log import log
@@ -324,57 +323,27 @@ def get_train_args(self):
 
         :param parser: an argparse like object
 
-        This method will call the wrapped model ``add_train_args``. If the
-        underlying methid implements the DEPRECATED way of passing arguments
-        we will try to load them from there.
+        This method will call the wrapped model ``add_train_args``.
         """
         try:
             args = self.model_obj.get_train_args()
-            args = self._convert_old_args(args)
-            return args
         except (NotImplementedError, AttributeError):
-            return {}
+            args = {}
+        return args
 
     def get_predict_args(self):
         """Add predict arguments into the predict parser.
 
         :param parser: an argparse like object
 
-        This method will call the wrapped model ``get_predict_args``. If the
-        method does not exist, but the wrapped model implements the DEPRECATED
-        ``get_test_args`` we will try to load the arguments from there.
+        This method will call the wrapped model ``get_predict_args``.
         """
         try:
             args = self.model_obj.get_predict_args()
         except (NotImplementedError, AttributeError):
-            try:
-                args = self.model_obj.get_test_args()
-                args = self._convert_old_args(args)
-            except (NotImplementedError, AttributeError):
-                args = {}
+            args = {}
         return args
 
-    def _convert_old_args(self, args):
-        aux = {}
-        for k, v in args.items():
-            if isinstance(v, dict):
-                LOG.warning("Loading arguments using the old and DEPRECATED "
-                            "return value (i.e. an plain Python dictionary. "
-                            "You should move to the new return value (i.e. a "
-                            "webargs.fields dictionary as soon as possible. "
-                            "All the loaded arguments will be converted to "
-                            "strings. This is only supported for backwards "
-                            "compatibility and may lead to unexpected errors. "
-                            "Argument raising this warningr: '%s'", k)
-
-                v = fields.Str(
-                    missing=v.get("default"),
-                    description=v.get("help"),
-                    required=v.get("required"),
-                )
-            aux[k] = v
-        return aux
-
 
 class NonDaemonProcess(multiprocessing.context.SpawnProcess):
     """Processes must use 'spawn' instead of 'fork' (which is the default

releasenotes/notes/remove-deprecated-get-args-166d8535f5b23c1e.yaml

@@ -0,0 +1,9 @@
+---
+prelude: >
+    Fallback loading of arguments (from V1 style) is now removed.
+upgrade:
+  - |
+    The old way of returning the arguments, to load the arguments using the old
+    ``get_*_args`` functions is now removed. If you were still relying on them
+    (check the logs) you must migrate to using the argument parser as soon as
+    possible.