- ensure <param> tag contains the 'by' attribute for val/ref.

- it was previously being passed in the <data> attribute.
- this is similar to how the 'io' attribute is handled.
- this allows service programs procedures that use the VALUE keyword to work with node

Signed-off-by: Dave Weissman <weissmad@gmail.com>

Author: jkdavew

lib/itoolkit.js

@@ -347,11 +347,9 @@ class iPgm {
       opt = type;
     else
       opt = options;
+
     if(!inDs) {  // In recursive mode, if it is an element in DS, then no <parm> or </parm> needed.
-      if(opt && opt.io)  
-        this.xml += i_xml.iXmlNodeParmOpen(opt.io);
-      else 
-        this.xml += i_xml.iXmlNodeParmOpen();
+      this.xml += i_xml.iXmlNodeParmOpen(opt);
     }
     if(__getClass(data) == "Array") {  // If it is a struct parameter, recursivly parse its children.
       if(opt)

lib/ixml.js

@@ -107,6 +107,7 @@ const I_XML_ATTR_KEY_DB = "db";
 const I_XML_ATTR_KEY_USERID = "uid";
 const I_XML_ATTR_KEY_PASSWORD = "pwd";
 const I_XML_ATTR_KEY_IO = "io";
+const I_XML_ATTR_KEY_BY = "by";
 const I_XML_ATTR_VALUE_IO = "both";
 const I_XML_ATTR_KEY_OFFSET = "offset";
 const I_XML_ATTR_KEY_TOP = "top";
@@ -173,9 +174,21 @@ const iXmlNodePgmClose = () => {
   return I_XML_NODE_PGM_CLOSE;
 }
 
-const iXmlNodeParmOpen = (xio) => {
+const iXmlNodeParmOpen = (opt) => {
+  if (!(opt && typeof opt==='object')){
+    return iXmlNodeOpen(I_XML_NODE_PARM_OPEN)
+    + I_XML_NODE_CLOSE;
+  }
+
+  let opt_io=(opt.io) ? iXmlAttrDefault(I_XML_ATTR_KEY_IO,opt.io,I_XML_ATTR_VALUE_OPTIONAL) : "";
+  let opt_by=(opt.by) ? iXmlAttrDefault(I_XML_ATTR_KEY_BY,opt.by,I_XML_ATTR_VALUE_OPTIONAL) : "";
+
+  delete opt.by;
+  delete opt.io;
+
   return iXmlNodeOpen(I_XML_NODE_PARM_OPEN)
-          + iXmlAttrDefault(I_XML_ATTR_KEY_IO,xio,I_XML_ATTR_VALUE_OPTIONAL)
+          + opt_io
+          + opt_by
           + I_XML_NODE_CLOSE;
 }