Skip to content

Commit 5d0fc3b

Browse files
authored
Fix plugin catalog and Test button (#1402)
Signed-off-by: Mihai Criveti <crivetimihai@gmail.com>
1 parent bb396e4 commit 5d0fc3b

File tree

5 files changed

+21
-10
lines changed

5 files changed

+21
-10
lines changed

deployment/knative/KNATIVE_SCALE_TO_ZERO.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,4 +281,4 @@ If you need to revert to a standard Kubernetes Deployment:
281281
- [Knative Autoscaling](https://knative.dev/docs/serving/autoscaling/)
282282
- [Knative Installation Guide](https://knative.dev/docs/install/)
283283
- [OpenShift Serverless Documentation](https://docs.openshift.com/serverless/)
284-
- [Kubernetes Secrets](https://kubernetes.io/docs/concepts/configuration/secret/)
284+
- [Kubernetes Secrets](https://kubernetes.io/docs/concepts/configuration/secret/)

deployment/knative/knative-serving.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,4 +75,3 @@ spec:
7575
metrics.backend-destination: "prometheus"
7676
# Enable profiling
7777
profiling.enable: "false"
78-

mcpgateway/services/plugin_service.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,9 @@ def get_all_plugins(self) -> List[Dict[str, Any]]:
7373
"description": plugin_config.description if plugin_config and plugin_config.description else "",
7474
"author": plugin_config.author if plugin_config and plugin_config.author else "Unknown",
7575
"version": plugin_config.version if plugin_config and plugin_config.version else "0.0.0",
76-
"mode": plugin_ref.mode.value if plugin_ref.mode else "disabled",
76+
"mode": plugin_ref.mode if isinstance(plugin_ref.mode, str) else plugin_ref.mode.value if plugin_ref.mode else "disabled",
7777
"priority": plugin_ref.priority,
78-
"hooks": [hook.value for hook in plugin_ref.hooks] if plugin_ref.hooks else [],
78+
"hooks": [hook if isinstance(hook, str) else hook.value for hook in plugin_ref.hooks] if plugin_ref.hooks else [],
7979
"tags": plugin_ref.tags or [],
8080
"kind": plugin_config.kind if plugin_config and plugin_config.kind else "",
8181
"namespace": plugin_config.namespace if plugin_config and plugin_config.namespace else "",
@@ -106,9 +106,9 @@ def get_all_plugins(self) -> List[Dict[str, Any]]:
106106
"description": plugin_config.description or "",
107107
"author": plugin_config.author or "Unknown",
108108
"version": plugin_config.version or "0.0.0",
109-
"mode": plugin_config.mode.value,
109+
"mode": plugin_config.mode if isinstance(plugin_config.mode, str) else plugin_config.mode.value,
110110
"priority": plugin_config.priority or 100,
111-
"hooks": [hook.value for hook in plugin_config.hooks] if plugin_config.hooks else [],
111+
"hooks": [hook if isinstance(hook, str) else hook.value for hook in plugin_config.hooks] if plugin_config.hooks else [],
112112
"tags": plugin_config.tags or [],
113113
"kind": plugin_config.kind or "",
114114
"namespace": plugin_config.namespace or "",
@@ -151,9 +151,9 @@ def get_plugin_by_name(self, name: str) -> Optional[Dict[str, Any]]:
151151
"description": plugin_config.description if plugin_config and plugin_config.description else "",
152152
"author": plugin_config.author if plugin_config and plugin_config.author else "Unknown",
153153
"version": plugin_config.version if plugin_config and plugin_config.version else "0.0.0",
154-
"mode": plugin_ref.mode.value if plugin_ref.mode else "disabled",
154+
"mode": plugin_ref.mode if isinstance(plugin_ref.mode, str) else plugin_ref.mode.value if plugin_ref.mode else "disabled",
155155
"priority": plugin_ref.priority,
156-
"hooks": [hook.value for hook in plugin_ref.hooks] if plugin_ref.hooks else [],
156+
"hooks": [hook if isinstance(hook, str) else hook.value for hook in plugin_ref.hooks] if plugin_ref.hooks else [],
157157
"tags": plugin_ref.tags or [],
158158
"kind": plugin_config.kind if plugin_config and plugin_config.kind else "",
159159
"namespace": plugin_config.namespace if plugin_config and plugin_config.namespace else "",

mcpgateway/templates/admin.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,7 +361,7 @@
361361
</div>
362362
</div>
363363

364-
364+
365365
</header>
366366

367367
<!-- Global notification container for flash messages -->
@@ -3502,7 +3502,7 @@ <h2 class="text-2xl font-bold dark:text-gray-200">MCP Prompts</h2>
35023502
<div id="prompts-pagination-controls"></div>
35033503
</div>
35043504

3505-
3505+
35063506

35073507
<div class="bg-white shadow rounded-lg p-6 dark:bg-gray-800">
35083508
<h3 class="text-lg font-bold mb-4 dark:text-gray-200">

mcpgateway/templates/prompts_partial.html

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,20 @@
2626
<td class="px-6 py-4 whitespace-nowrap text-sm w-12"><div class="relative group">{% set enabled = prompt.is_active %}<span class="px-2 inline-flex text-xs leading-5 font-semibold rounded-full {% if enabled %}bg-green-100 text-green-800{% else %}bg-red-100 text-red-800{% endif %}">{% if enabled %}Active{% else %}Inactive{% endif %}</span></div></td>
2727
<td class="px-6 py-4 whitespace-nowrap text-sm font-medium">
2828
<div class="grid grid-cols-2 gap-x-2 gap-y-0 max-w-48">
29+
<!-- Row 1: Test -->
30+
<button
31+
onclick="testPrompt('{{ prompt.id }}')"
32+
class="col-span-2 flex items-center justify-center px-2 py-1 text-xs font-medium rounded-md text-purple-600 hover:text-purple-900 hover:bg-purple-50 dark:text-purple-400 dark:hover:bg-purple-900/20 transition-colors"
33+
x-tooltip="'💡Test this Prompt with sample arguments'"
34+
>
35+
Test
36+
</button>
37+
38+
<!-- Row 2: View | Edit -->
2939
<button onclick="viewPrompt('{{ prompt.id }}')" class="flex items-center justify-center px-2 py-1 text-xs font-medium rounded-md text-indigo-600 hover:text-indigo-900 hover:bg-indigo-50 dark:text-indigo-400 dark:hover:bg-indigo-900/20 transition-colors">View</button>
3040
<button onclick="editPrompt('{{ prompt.id }}')" class="flex items-center justify-center px-2 py-1 text-xs font-medium rounded-md text-green-600 hover:text-green-900 hover:bg-green-50 dark:text-green-400 dark:hover:bg-green-900/20 transition-colors">Edit</button>
41+
42+
<!-- Row 3 & 4: Activate/Deactivate | Delete -->
3143
<div class="col-span-2 flex flex-col space-y-1">
3244
<form method="POST" action="{{ root_path }}/admin/prompts/{{ prompt.id }}/toggle" class="contents" onsubmit="return handleToggleSubmit(event, 'prompts')">
3345
<input type="hidden" name="activate" value="{{ 'false' if prompt.is_active else 'true' }}" />

0 commit comments

Comments
 (0)