From 4ff3ed58bc836e4da373e02bced35ec10e8d206e Mon Sep 17 00:00:00 2001 From: Jonathan Leitschuh Date: Sat, 19 Nov 2022 02:08:06 +0000 Subject: [PATCH] vuln-fix: Temporary File Information Disclosure This fixes temporary file information disclosure vulnerability due to the use of the vulnerable `File.createTempFile()` method. The vulnerability is fixed by using the `Files.createTempFile()` method which sets the correct posix permissions. Weakness: CWE-377: Insecure Temporary File Severity: Medium CVSSS: 5.5 Detection: CodeQL & OpenRewrite (https://public.moderne.io/recipes/org.openrewrite.java.security.SecureTempFileCreation) Reported-by: Jonathan Leitschuh Signed-off-by: Jonathan Leitschuh Bug-tracker: https://github.com/JLLeitschuh/security-research/issues/18 Co-authored-by: Moderne --- .../QueryExpansion/src/com/ibm/research/utils/OCUtils.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) mode change 100755 => 100644 QueryEngine/QueryExpansion/src/com/ibm/research/utils/OCUtils.java diff --git a/QueryEngine/QueryExpansion/src/com/ibm/research/utils/OCUtils.java b/QueryEngine/QueryExpansion/src/com/ibm/research/utils/OCUtils.java old mode 100755 new mode 100644 index 6d626c1..1795513 --- a/QueryEngine/QueryExpansion/src/com/ibm/research/utils/OCUtils.java +++ b/QueryEngine/QueryExpansion/src/com/ibm/research/utils/OCUtils.java @@ -17,6 +17,7 @@ import java.io.PrintWriter; import java.io.Reader; import java.io.StringWriter; +import java.nio.file.Files; import java.util.ArrayList; import java.util.HashMap; import java.util.HashSet; @@ -128,7 +129,7 @@ public static List createRandomAboxAxiomPartitionsAsFiles(OWLOntology ont, List onts = createRandomAboxAxiomPartitions(ont, numberOfPartitions, seed); List ret = new ArrayList(onts.size()); for (OWLOntology o : onts) { - File tempFile = File.createTempFile("ont", ".rdf"); + File tempFile = Files.createTempFile("ont", ".rdf").toFile(); saveRDFXML(o, tempFile); ret.add(tempFile); logger.debug("abox temp file: {}", tempFile.getAbsolutePath()); @@ -139,7 +140,7 @@ public static List createRandomAboxAxiomPartitionsAsFiles(OWLOntology ont, public static File createOWLThingTypeDeclForIndividualsAsFile(OWLOntology ont) throws OWLOntologyCreationException, IOException { - File tempFile = File.createTempFile("ont", ".ind.rdf"); + File tempFile = Files.createTempFile("ont", ".ind.rdf").toFile(); OWLOntology td = createOWLThingTypeDeclForIndividuals(ont); saveRDFXML(td, tempFile); logger.debug("owl thing type decl file: {}", tempFile.getAbsolutePath()); @@ -223,7 +224,7 @@ public static OWLOntology load(File... inputFiles) throws OWLOntologyCreationExc } public static OWLOntology load(Model tbox) throws IOException, OWLOntologyCreationException { - File tempFile = File.createTempFile("tboxmodel", ".ttl"); + File tempFile = Files.createTempFile("tboxmodel", ".ttl").toFile(); FileOutputStream out = new FileOutputStream(tempFile); tbox.write(out); out.flush();