From 5b932b9948e2c5ad68480cf1f2ebc61669f3c990 Mon Sep 17 00:00:00 2001 From: Saad Nadeem Date: Tue, 18 Nov 2025 09:31:40 -0500 Subject: [PATCH 1/6] fix: museum and garden options --- src/API/getSkyBlockProfiles.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/API/getSkyBlockProfiles.ts b/src/API/getSkyBlockProfiles.ts index c73dc9f58..939d1db20 100644 --- a/src/API/getSkyBlockProfiles.ts +++ b/src/API/getSkyBlockProfiles.ts @@ -19,8 +19,8 @@ class getSkyBlockProfiles extends Endpoint { if (!res.data.profiles || !res.data.profiles.length) throw new Error(Errors.NO_SKYBLOCK_PROFILES); const profiles: Map = new Map(); for (const profile of res.data.profiles) { - const garden = await this.handleGettingSkyBlockGarden(profile.profile_id); - const museum = await this.handleGettingSkyBlockMuseum(profile.profile_id); + const garden = options?.garden != false ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null; + const museum = options?.museum != false ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null; const parsedProfile = new SkyBlockProfile(profile, { uuid: query, garden, museum }); profiles.set(parsedProfile.profileName, parsedProfile); } From 81ce1f0bc8a6cfd44a38867863bed05832bd33a9 Mon Sep 17 00:00:00 2001 From: Saad Nadeem Date: Tue, 18 Nov 2025 09:35:39 -0500 Subject: [PATCH 2/6] pnpm lint --- src/API/getSkyBlockProfiles.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/API/getSkyBlockProfiles.ts b/src/API/getSkyBlockProfiles.ts index 939d1db20..39335a3dc 100644 --- a/src/API/getSkyBlockProfiles.ts +++ b/src/API/getSkyBlockProfiles.ts @@ -19,8 +19,8 @@ class getSkyBlockProfiles extends Endpoint { if (!res.data.profiles || !res.data.profiles.length) throw new Error(Errors.NO_SKYBLOCK_PROFILES); const profiles: Map = new Map(); for (const profile of res.data.profiles) { - const garden = options?.garden != false ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null; - const museum = options?.museum != false ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null; + const garden = options?.garden !== false ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null; + const museum = options?.museum !== false ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null; const parsedProfile = new SkyBlockProfile(profile, { uuid: query, garden, museum }); profiles.set(parsedProfile.profileName, parsedProfile); } From 1a2cfc8bc12a0672b7234d5914a2c4278fc5c9bd Mon Sep 17 00:00:00 2001 From: Saad Nadeem <88615188+BridgeSenseDev@users.noreply.github.com> Date: Wed, 19 Nov 2025 23:22:42 -0500 Subject: [PATCH 3/6] only fetch when options explicitly set to true Co-authored-by: Jacob --- src/API/getSkyBlockProfiles.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/API/getSkyBlockProfiles.ts b/src/API/getSkyBlockProfiles.ts index 39335a3dc..cdc65bf48 100644 --- a/src/API/getSkyBlockProfiles.ts +++ b/src/API/getSkyBlockProfiles.ts @@ -19,8 +19,8 @@ class getSkyBlockProfiles extends Endpoint { if (!res.data.profiles || !res.data.profiles.length) throw new Error(Errors.NO_SKYBLOCK_PROFILES); const profiles: Map = new Map(); for (const profile of res.data.profiles) { - const garden = options?.garden !== false ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null; - const museum = options?.museum !== false ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null; + const garden = options?.garden === true ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null; + const museum = options?.museum === true ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null; const parsedProfile = new SkyBlockProfile(profile, { uuid: query, garden, museum }); profiles.set(parsedProfile.profileName, parsedProfile); } From 5d556cfecb4d84338b11b1970ac12e7250859f9e Mon Sep 17 00:00:00 2001 From: Saad Nadeem Date: Wed, 19 Nov 2025 23:30:20 -0500 Subject: [PATCH 4/6] simplify ternary --- src/API/getSkyBlockProfiles.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/API/getSkyBlockProfiles.ts b/src/API/getSkyBlockProfiles.ts index cdc65bf48..840d72791 100644 --- a/src/API/getSkyBlockProfiles.ts +++ b/src/API/getSkyBlockProfiles.ts @@ -19,8 +19,8 @@ class getSkyBlockProfiles extends Endpoint { if (!res.data.profiles || !res.data.profiles.length) throw new Error(Errors.NO_SKYBLOCK_PROFILES); const profiles: Map = new Map(); for (const profile of res.data.profiles) { - const garden = options?.garden === true ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null; - const museum = options?.museum === true ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null; + const garden = options?.garden ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null; + const museum = options?.museum ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null; const parsedProfile = new SkyBlockProfile(profile, { uuid: query, garden, museum }); profiles.set(parsedProfile.profileName, parsedProfile); } From 42c74e3ec1990dbda0d84b278ff3efb9a74896f1 Mon Sep 17 00:00:00 2001 From: Saad Nadeem Date: Wed, 19 Nov 2025 23:31:01 -0500 Subject: [PATCH 5/6] also respect options in fetchSkyblockProfile --- src/API/getSkyBlockProfile.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/API/getSkyBlockProfile.ts b/src/API/getSkyBlockProfile.ts index 1a865eb6a..1afa61196 100644 --- a/src/API/getSkyBlockProfile.ts +++ b/src/API/getSkyBlockProfile.ts @@ -12,8 +12,8 @@ class getSkyBlockProfile extends Endpoint { const res = await this.client.requestHandler.request(`/skyblock/profile?profile=${profileId}`, options); if (res.options.raw) return res; if (!res.data.profile) throw new Error(Errors.NO_SKYBLOCK_PROFILES); - const garden = await this.handleGettingSkyBlockGarden(res.data.profile.profile_id); - const museum = await this.handleGettingSkyBlockMuseum(res.data.profile.profile_id); + const garden = options?.museum ? await this.handleGettingSkyBlockGarden(res.data.profile.profile_id) : null; + const museum = options?.museum ? await this.handleGettingSkyBlockMuseum(res.data.profile.profile_id) : null; const parsedProfile = new SkyBlockProfile(res.data.profile, { uuid: null, garden, museum }); return parsedProfile; } From aa314b4afe3c8cf88bedd9212d1f99ae5d702527 Mon Sep 17 00:00:00 2001 From: Jacob Date: Thu, 20 Nov 2025 12:47:52 +0800 Subject: [PATCH 6/6] fix(getSkyBlockProfile/s): garden & museum types --- src/API/getSkyBlockProfile.ts | 4 ++-- src/API/getSkyBlockProfiles.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/API/getSkyBlockProfile.ts b/src/API/getSkyBlockProfile.ts index 1afa61196..cc3bb4c0e 100644 --- a/src/API/getSkyBlockProfile.ts +++ b/src/API/getSkyBlockProfile.ts @@ -12,8 +12,8 @@ class getSkyBlockProfile extends Endpoint { const res = await this.client.requestHandler.request(`/skyblock/profile?profile=${profileId}`, options); if (res.options.raw) return res; if (!res.data.profile) throw new Error(Errors.NO_SKYBLOCK_PROFILES); - const garden = options?.museum ? await this.handleGettingSkyBlockGarden(res.data.profile.profile_id) : null; - const museum = options?.museum ? await this.handleGettingSkyBlockMuseum(res.data.profile.profile_id) : null; + const garden = options?.museum ? await this.handleGettingSkyBlockGarden(res.data.profile.profile_id) : undefined; + const museum = options?.museum ? await this.handleGettingSkyBlockMuseum(res.data.profile.profile_id) : undefined; const parsedProfile = new SkyBlockProfile(res.data.profile, { uuid: null, garden, museum }); return parsedProfile; } diff --git a/src/API/getSkyBlockProfiles.ts b/src/API/getSkyBlockProfiles.ts index 840d72791..72f228b60 100644 --- a/src/API/getSkyBlockProfiles.ts +++ b/src/API/getSkyBlockProfiles.ts @@ -19,8 +19,8 @@ class getSkyBlockProfiles extends Endpoint { if (!res.data.profiles || !res.data.profiles.length) throw new Error(Errors.NO_SKYBLOCK_PROFILES); const profiles: Map = new Map(); for (const profile of res.data.profiles) { - const garden = options?.garden ? await this.handleGettingSkyBlockGarden(profile.profile_id) : null; - const museum = options?.museum ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : null; + const garden = options?.garden ? await this.handleGettingSkyBlockGarden(profile.profile_id) : undefined; + const museum = options?.museum ? await this.handleGettingSkyBlockMuseum(profile.profile_id) : undefined; const parsedProfile = new SkyBlockProfile(profile, { uuid: query, garden, museum }); profiles.set(parsedProfile.profileName, parsedProfile); }