Skip to content

Commit 3371ed0

Browse files
committed
Use writableEnded instead of finished
After node.js v12.9.0 we should handle WritableStream as described here: https://nodejs.org/api/http.html#http_request_writableended PR-URL: #168
1 parent 8196bb4 commit 3371ed0

File tree

3 files changed

+4
-3
lines changed

3 files changed

+4
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ platform based on [Metarhia technology stack](https://github.com/metarhia) and
4343

4444
## Requirements
4545

46-
- Node.js v12.5.0 or later (v14 preferred)
46+
- Node.js v12.9.0 or later (v14 preferred)
4747
- Linux (tested on Fedora 30, Ubuntu 16, 18, 19 and 20, CentOS 7 and 8)
4848
- Postgresql 9.5 or later (v11.8 preferred)
4949
- OpenSSL v1.1.1 or later

lib/client.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ class Client {
3838
const fileExt = path.extname(filePath).substring(1);
3939
const mimeType = MIME_TYPES[fileExt] || MIME_TYPES.html;
4040
res.writeHead(200, { ...HEADERS, 'Content-Type': mimeType });
41+
if (res.writableEnded) return;
4142
const data = application.static.get(filePath);
4243
if (data) res.end(data);
4344
else this.error(404);
@@ -63,7 +64,7 @@ class Client {
6364
connection.send(result);
6465
return;
6566
}
66-
if (res.finished) return;
67+
if (res.writableEnded) return;
6768
res.writeHead(status, { 'Content-Type': MIME_TYPES.json });
6869
res.end(result);
6970
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@
4444
},
4545
"homepage": "https://github.com/HowProgrammingWorks/NodejsStarterKit",
4646
"engines": {
47-
"node": ">=12.5.0"
47+
"node": ">=12.9.0"
4848
},
4949
"devDependencies": {
5050
"eslint": "^7.4.0"

0 commit comments

Comments
 (0)