Skip to content
This repository was archived by the owner on Aug 7, 2023. It is now read-only.

Commit 561e1d4

Browse files
committed
bug fixes, cleanup
1 parent aba8be6 commit 561e1d4

File tree

5 files changed

+7
-11
lines changed

5 files changed

+7
-11
lines changed

android/src/main/kotlin/com/homexlabs/optimizely_dart/OptimizelyPlugin.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -89,12 +89,12 @@ class OptimizelyPlugin: FlutterPlugin, MethodCallHandler, ActivityAware {
8989
val variation = activateGetVariation(featureKey!!)
9090
result.success(variation)
9191
}
92-
"getvariation" -> {
92+
"getVariation"-> {
9393
val featureKey = call.argument<String>("feature_key")
9494
val userId = call.argument<String>("user_id")
9595
val attributes = call.argument<MutableMap<String, Any>>("attributes")
9696
val variation = getVariation(featureKey!!, userId!!, attributes!!)
97-
result.success(variation)
97+
result.success(variation?.key)
9898
}
9999
"trackEvent" -> {
100100
val featureKey = call.argument<String>("feature_key")

example/lib/main.dart

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,6 @@ class _MyAppState extends State<MyApp> {
5050
try {
5151
bool? featureEnabled = await optimizelyPlugin.isFeatureEnabled(
5252
'price_filter',
53-
'user@example.org',
54-
{'platform': platform},
5553
);
5654
priceFilterFlag = 'price_filter feature is $featureEnabled.';
5755
} on PlatformException catch (e) {
@@ -76,8 +74,6 @@ class _MyAppState extends State<MyApp> {
7674
try {
7775
variables = await optimizelyPlugin.getAllFeatureVariables(
7876
'price_filter',
79-
'user@example.org',
80-
{'platform': platform},
8177
);
8278
int? minPrice = variables['min_price'];
8379
minPriceVariable = "min_price variable is: ${minPrice.toString()}.";

ios/Classes/OptimizelyPlugin.m

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,11 @@
55
// Support project import fallback if the generated compatibility header
66
// is not copied when this plugin is created as a library.
77
// https://forums.swift.org/t/swift-static-libraries-dont-copy-generated-objective-c-header/19816
8-
#import "optimizely_plugin-Swift.h"
8+
#import "OptimizelyPlugin.h"
99
#endif
1010

1111
@implementation OptimizelyPlugin
1212
+ (void)registerWithRegistrar:(NSObject<FlutterPluginRegistrar>*)registrar {
13-
[SwiftOptimizelyPlugin registerWithRegistrar:registrar];
13+
[OptimizelyPlugin registerWithRegistrar:registrar];
1414
}
1515
@end

ios/Classes/SwiftOptimizelyPlugin.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ enum InitResult {
66
case failure(Error)
77
}
88

9-
public class SwiftOptimizelyPlugin: NSObject, FlutterPlugin {
9+
public class OptimizelyPlugin: NSObject, FlutterPlugin {
1010

1111
typealias GetFeatureItems = (featureKey: String, userId: String, attributes: OptimizelyAttributes?, eventTags: OptimizelyEventTags?)
1212
var client: OptimizelyClient?
@@ -17,7 +17,7 @@ public class SwiftOptimizelyPlugin: NSObject, FlutterPlugin {
1717
name: "optimizely_plugin",
1818
binaryMessenger: registrar.messenger()
1919
)
20-
let instance = SwiftOptimizelyPlugin()
20+
let instance = OptimizelyPlugin()
2121
registrar.addMethodCallDelegate(instance, channel: channel)
2222
}
2323

lib/optimizely_dart.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ class OptimizelyPlugin {
7979
String experimentKey,
8080
) async {
8181
final variation =
82-
await _channel.invokeMethod('getAllFeatureVariables', <String, dynamic>{
82+
await _channel.invokeMethod('activateGetVariation', <String, dynamic>{
8383
'feature_key': experimentKey,
8484
});
8585
return variation;

0 commit comments

Comments
 (0)