fix Utf8Formatter always assume invariant culture when formatting a floating-point whole number

Author: adienakhmad

Hexa.NET.Utilities.Tests/Utf8FormatterTests.cs

@@ -49,4 +49,52 @@ public unsafe void FormatDoubleTest(double value, int digit, string expected)
         // Assert
         Assert.That(Encoding.UTF8.GetString(utf8Span), Is.EqualTo(expected));
     }
+
+    [TestCase(10, 0, ".","10")]
+    [TestCase(10, 0, "\uFF0C","10")]
+    [TestCase(0.75f, 2, ".","0.75")]
+    [TestCase(0.75f, 2, "\uFF0C","0\uFF0C75")]
+    public unsafe void FormatFloatCultureTest(float value, int digit, string separator, string expected)
+    {
+        // Arrange
+        byte* buffer = stackalloc byte[128];
+        var culture = new CultureInfo( "", false )
+        {
+            NumberFormat =
+            {
+                CurrencyDecimalSeparator = separator
+            }
+        };
+
+        // Act
+        int len = Utf8Formatter.Format(value, buffer, 128, culture, digit);
+        ReadOnlySpan<byte> utf8Span = new ReadOnlySpan<byte>(buffer, len);
+
+        // Assert
+        Assert.That(Encoding.UTF8.GetString(utf8Span), Is.EqualTo(expected));
+    }
+
+    [TestCase(10, 0, ".","10")]
+    [TestCase(10, 0, "\uFF0C","10")]
+    [TestCase(0.75, 2, ".","0.75")]
+    [TestCase(0.75, 2, "\uFF0C","0\uFF0C75")]
+    public unsafe void FormatDoubleCultureTest(double value, int digit, string separator, string expected)
+    {
+        // Arrange
+        byte* buffer = stackalloc byte[128];
+        var culture = new CultureInfo( "", false )
+        {
+            NumberFormat =
+            {
+                CurrencyDecimalSeparator = separator
+            }
+        };
+
+        // Act
+        int len = Utf8Formatter.Format(value, buffer, 128, culture, digit);
+        var utf8Span = new ReadOnlySpan<byte>(buffer, len);
+
+        // Assert
+        Assert.That(Encoding.UTF8.GetString(utf8Span), Is.EqualTo(expected));
+    }
 }

Hexa.NET.Utilities/Text/Utf8Formatter.cs

@@ -326,7 +326,9 @@ public static unsafe int Format(float value, byte* buffer, int bufSize, CultureI
                 return (int)(buffer - start);
             }
 
+            byte* beforeSeparator = buffer;
             buffer += ConvertUtf16ToUtf8(format.CurrencyDecimalSeparator, buffer, (int)(end - buffer));
+            byte* afterSeparator = buffer;
 
             digits = digits >= 0 ? digits : 7;
 
@@ -340,14 +342,14 @@ public static unsafe int Format(float value, byte* buffer, int bufSize, CultureI
                 if (fraction < 1e-14) break;
             }
 
-            while (*(buffer - 1) == '0')
+            while (buffer != afterSeparator && *(buffer - 1) == '0')
             {
                 buffer--;
             }
 
-            while (*(buffer - 1) == '.')
+            if (buffer == afterSeparator)
             {
-                buffer--;
+                buffer = beforeSeparator;
             }
 
         end:
@@ -409,7 +411,9 @@ public static unsafe int Format(double value, byte* buffer, int bufSize, Culture
                 return (int)(buffer - start);
             }
 
+            byte* beforeSeparator = buffer;
             buffer += ConvertUtf16ToUtf8(format.CurrencyDecimalSeparator, buffer, (int)(end - buffer));
+            byte* afterSeparator = buffer;
 
             digits = digits >= 0 ? digits : 7;
 
@@ -423,14 +427,14 @@ public static unsafe int Format(double value, byte* buffer, int bufSize, Culture
                 if (fraction < 1e-14) break;
             }
 
-            while (*(buffer - 1) == '0')
+            while (buffer != afterSeparator && *(buffer - 1) == '0')
             {
                 buffer--;
             }
-            
-            while (*(buffer - 1) == '.')
+
+            if (buffer == afterSeparator)
             {
-                buffer--;
+                buffer = beforeSeparator;
             }
 
         end: