Skip to content

Commit ea6d028

Browse files
committed
Fix incorrect override for pop method
This method could never return None because a missing key would raise instead, which is the expected behavior of the base class.
1 parent 0db0c47 commit ea6d028

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

tcod/ecs/entity.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -553,7 +553,7 @@ def setdefault(self, __key: ComponentKey[T], __default: T, /) -> T:
553553
return __default
554554

555555
@overload
556-
def pop(self, __key: ComponentKey[T], /) -> T | None: ...
556+
def pop(self, __key: ComponentKey[T], /) -> T: ...
557557
@overload
558558
def pop(self, __key: ComponentKey[T], /, default: _T1) -> T | _T1: ...
559559

0 commit comments

Comments
 (0)