Skip to content

Commit b360a63

Browse files
committed
cleanup template packages and some code styling
1 parent 3553cc5 commit b360a63

File tree

35 files changed

+67
-179
lines changed

35 files changed

+67
-179
lines changed

META-INF/plugin.xml

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -176,10 +176,6 @@
176176
nonDefaultProject="true"
177177
/>
178178

179-
<!--
180-
<iconProvider implementation="fr.adrienbrault.idea.symfony2plugin.templating.TwigFileIconProvider" />
181-
-->
182-
183179
<psi.referenceContributor implementation="fr.adrienbrault.idea.symfony2plugin.config.SymfonyPhpReferenceContributor"/>
184180
<psi.referenceContributor implementation="fr.adrienbrault.idea.symfony2plugin.translation.TranslationReferenceContributor"/>
185181
<psi.referenceContributor implementation="fr.adrienbrault.idea.symfony2plugin.routing.PhpRouteReferenceContributor"/>
@@ -193,7 +189,7 @@
193189
<gotoDeclarationHandler implementation="fr.adrienbrault.idea.symfony2plugin.templating.TwigTemplateGoToDeclarationHandler"/>
194190
<gotoDeclarationHandler implementation="fr.adrienbrault.idea.symfony2plugin.config.yaml.YamlGoToDeclarationHandler"/>
195191
<gotoDeclarationHandler implementation="fr.adrienbrault.idea.symfony2plugin.asset.AssetGoToDeclarationHandler"/>
196-
<gotoDeclarationHandler implementation="fr.adrienbrault.idea.symfony2plugin.templating.PhpTemplateGlobalStringGoToDeclarationHandler"/>
192+
<gotoDeclarationHandler implementation="fr.adrienbrault.idea.symfony2plugin.twig.PhpTemplateGlobalStringGoToDeclarationHandler"/>
197193
<gotoDeclarationHandler implementation="fr.adrienbrault.idea.symfony2plugin.config.PhpClassServiceGotoDeclarationHandler"/>
198194
<gotoDeclarationHandler implementation="fr.adrienbrault.idea.symfony2plugin.doctrine.querybuilder.QueryBuilderGotoDeclarationHandler"/>
199195

@@ -565,9 +561,9 @@
565561
<ControllerActionGotoRelatedCollector implementation="fr.adrienbrault.idea.symfony2plugin.navigation.controller.TemplatesControllerRelatedGotoCollector"/>
566562

567563
<GotoCompletionRegistrar implementation="fr.adrienbrault.idea.symfony2plugin.form.FormOptionGotoCompletionRegistrar"/>
568-
<GotoCompletionRegistrar implementation="fr.adrienbrault.idea.symfony2plugin.templating.BlockCompletionRegistrar"/>
569-
<GotoCompletionRegistrar implementation="fr.adrienbrault.idea.symfony2plugin.templating.FilterCompletionRegistrar"/>
570-
<GotoCompletionRegistrar implementation="fr.adrienbrault.idea.symfony2plugin.templating.TranslationTagCompletionRegistrar"/>
564+
<GotoCompletionRegistrar implementation="fr.adrienbrault.idea.symfony2plugin.templating.BlockGotoCompletionRegistrar"/>
565+
<GotoCompletionRegistrar implementation="fr.adrienbrault.idea.symfony2plugin.templating.FilterGotoCompletionRegistrar"/>
566+
<GotoCompletionRegistrar implementation="fr.adrienbrault.idea.symfony2plugin.templating.TranslationTagGotoCompletionRegistrar"/>
571567
<GotoCompletionRegistrar implementation="fr.adrienbrault.idea.symfony2plugin.form.FormGotoCompletionRegistrar"/>
572568
<GotoCompletionRegistrar implementation="fr.adrienbrault.idea.symfony2plugin.config.php.PhpEventDispatcherGotoCompletionRegistrar"/>
573569
<GotoCompletionRegistrar implementation="fr.adrienbrault.idea.symfony2plugin.completion.command.PhpCommandGotoCompletionRegistrar"/>
@@ -671,7 +667,7 @@
671667
<add-to-group group-id="GenerateGroup" anchor="last" />
672668
</action>
673669

674-
<action id="Symfony.TwigTranslationGenerator" class="fr.adrienbrault.idea.symfony2plugin.templating.TwigTranslationGeneratorAction" text="Translation" icon="SymfonyIcons.Translation">
670+
<action id="Symfony.TwigTranslationGenerator" class="fr.adrienbrault.idea.symfony2plugin.twig.action.TwigTranslationGeneratorAction" text="Translation" icon="SymfonyIcons.Translation">
675671
<add-to-group group-id="GenerateGroup" anchor="last" />
676672
</action>
677673

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,10 @@
11
package fr.adrienbrault.idea.symfony2plugin.codeInsight;
22

3+
import org.jetbrains.annotations.NotNull;
4+
35
/**
46
* @author Daniel Espendiller <daniel@espendiller.net>
57
*/
68
public interface GotoCompletionRegistrar {
7-
void register(GotoCompletionRegistrarParameter registrar);
9+
void register(@NotNull GotoCompletionRegistrarParameter registrar);
810
}

src/fr/adrienbrault/idea/symfony2plugin/completion/command/ConsoleHelperGotoCompletionRegistrar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ public class ConsoleHelperGotoCompletionRegistrar implements GotoCompletionRegis
2929
};
3030

3131
@Override
32-
public void register(GotoCompletionRegistrarParameter registrar) {
32+
public void register(@NotNull GotoCompletionRegistrarParameter registrar) {
3333
registrar.register(PlatformPatterns.psiElement().withParent(StringLiteralExpression.class).withLanguage(PhpLanguage.INSTANCE), psiElement -> {
3434
PsiElement context = psiElement.getContext();
3535
if (!(context instanceof StringLiteralExpression)) {

src/fr/adrienbrault/idea/symfony2plugin/completion/command/PhpCommandGotoCompletionRegistrar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
public class PhpCommandGotoCompletionRegistrar implements GotoCompletionRegistrar {
3232

3333
@Override
34-
public void register(GotoCompletionRegistrarParameter registrar) {
34+
public void register(@NotNull GotoCompletionRegistrarParameter registrar) {
3535

3636
registrar.register(PlatformPatterns.psiElement().withParent(StringLiteralExpression.class).withLanguage(PhpLanguage.INSTANCE), psiElement -> {
3737
PsiElement context = psiElement.getContext();

src/fr/adrienbrault/idea/symfony2plugin/completion/xml/XmlGotoCompletionRegistrar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@
4646
public class XmlGotoCompletionRegistrar implements GotoCompletionRegistrar {
4747

4848
@Override
49-
public void register(GotoCompletionRegistrarParameter registrar) {
49+
public void register(@NotNull GotoCompletionRegistrarParameter registrar) {
5050
// <import resource="config_foo.xml"/>
5151
registrar.register(
5252
XmlPatterns.psiElement().withParent(XmlHelper.getImportResourcePattern()),

src/fr/adrienbrault/idea/symfony2plugin/completion/yaml/YamlGotoCompletionRegistrar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
public class YamlGotoCompletionRegistrar implements GotoCompletionRegistrar {
2020

2121
@Override
22-
public void register(GotoCompletionRegistrarParameter registrar) {
22+
public void register(@NotNull GotoCompletionRegistrarParameter registrar) {
2323
// defaults:
2424
// route: <caret>
2525
registrar.register(

src/fr/adrienbrault/idea/symfony2plugin/config/php/PhpEventDispatcherGotoCompletionRegistrar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ public class PhpEventDispatcherGotoCompletionRegistrar implements GotoCompletion
3737
* ');
3838
*
3939
*/
40-
public void register(GotoCompletionRegistrarParameter registrar) {
40+
public void register(@NotNull GotoCompletionRegistrarParameter registrar) {
4141

4242
registrar.register(PlatformPatterns.psiElement().withParent(StringLiteralExpression.class).withLanguage(PhpLanguage.INSTANCE), psiElement -> {
4343
PsiElement parent = psiElement.getParent();

src/fr/adrienbrault/idea/symfony2plugin/dic/TaggedParameterGotoCompletionRegistrar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
*/
2525
public class TaggedParameterGotoCompletionRegistrar implements GotoCompletionRegistrar {
2626
@Override
27-
public void register(GotoCompletionRegistrarParameter registrar) {
27+
public void register(@NotNull GotoCompletionRegistrarParameter registrar) {
2828
// arguments: [!tagged twig.extension]
2929
// <argument type="tagged" tag="foobar" />
3030
registrar.register(

src/fr/adrienbrault/idea/symfony2plugin/dic/registrar/DicGotoCompletionRegistrar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@
2727
public class DicGotoCompletionRegistrar implements GotoCompletionRegistrar {
2828

2929
@Override
30-
public void register(GotoCompletionRegistrarParameter registrar) {
30+
public void register(@NotNull GotoCompletionRegistrarParameter registrar) {
3131

3232
// getParameter('FOO')
3333
registrar.register(

src/fr/adrienbrault/idea/symfony2plugin/doctrine/metadata/DoctrineXmlGotoCompletionRegistrar.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
public class DoctrineXmlGotoCompletionRegistrar implements GotoCompletionRegistrar {
2424

2525
@Override
26-
public void register(GotoCompletionRegistrarParameter registrar) {
26+
public void register(@NotNull GotoCompletionRegistrarParameter registrar) {
2727

2828
registrar.register(XmlPatterns.psiElement().withParent(PlatformPatterns.or(
2929
DoctrineMetadataPattern.getXmlModelClass(),

0 commit comments

Comments
 (0)