Fixed #1575: Inspection "Container sensitivity" is not expected to be emitted for default env values

Author: adamwojs

src/main/java/fr/adrienbrault/idea/symfony2plugin/dic/inspection/CaseSensitivityServiceInspection.java

@@ -78,7 +78,7 @@ public void visitElement(PsiElement psiElement) {
         // services and parameter
         YamlHelper.processKeysAfterRoot(psiFile, yamlKeyValue -> {
             String keyText = yamlKeyValue.getKeyText();
-            if(StringUtils.isNotBlank(keyText) && !keyText.equals(keyText.toLowerCase()) && !YamlHelper.isClassServiceId(keyText)) {
+            if(StringUtils.isNotBlank(keyText) && !keyText.equals(keyText.toLowerCase()) && !YamlHelper.isClassServiceId(keyText) && !YamlHelper.isDefaultEnvValue(keyText)) {
                 PsiElement firstChild = yamlKeyValue.getFirstChild();
                 if(firstChild != null) {
                     holder.registerProblem(firstChild, SYMFONY_LOWERCASE_LETTERS_FOR_SERVICE, ProblemHighlightType.WEAK_WARNING);

src/main/java/fr/adrienbrault/idea/symfony2plugin/util/yaml/YamlHelper.java

@@ -1032,6 +1032,13 @@ public static boolean isClassServiceId(@NotNull String serviceId) {
         return PhpNameUtil.isValidNamespaceFullName(serviceId, true);
     }
 
+    /**
+     * Returns true if given parameter name is default value for ENV variable.
+     */
+    public static boolean isDefaultEnvValue(@NotNull String parameterName) {
+        return parameterName.length() > 5 && parameterName.startsWith("env(") && parameterName.endsWith(")");
+    }
+
     /**
      * service_name:
      *   class: FOOBAR