Skip to content

Commit f99de03

Browse files
committed
Rename PassThru to Direct
1 parent 240fb3c commit f99de03

File tree

4 files changed

+17
-17
lines changed

4 files changed

+17
-17
lines changed

styleguide_example/files/apis.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
from styleguide_example.files.models import File
88
from styleguide_example.files.services import (
99
FileStandardUploadService,
10-
FilePassThruUploadService
10+
FileDirectUploadService
1111
)
1212

1313
from styleguide_example.api.mixins import ApiAuthMixin
@@ -24,7 +24,7 @@ def post(self, request):
2424
return Response(data={"id": file.id}, status=status.HTTP_201_CREATED)
2525

2626

27-
class FilePassThruUploadStartApi(ApiAuthMixin, APIView):
27+
class FileDirectUploadStartApi(ApiAuthMixin, APIView):
2828
class InputSerializer(serializers.Serializer):
2929
file_name = serializers.CharField()
3030
file_type = serializers.CharField()
@@ -33,25 +33,25 @@ def post(self, request, *args, **kwargs):
3333
serializer = self.InputSerializer(data=request.data)
3434
serializer.is_valid(raise_exception=True)
3535

36-
service = FilePassThruUploadService(request.user)
36+
service = FileDirectUploadService(request.user)
3737
presigned_data = service.start(**serializer.validated_data)
3838

3939
return Response(data=presigned_data)
4040

4141

42-
class FilePassThruUploadLocalApi(ApiAuthMixin, APIView):
42+
class FileDirectUploadLocalApi(ApiAuthMixin, APIView):
4343
def post(self, request, file_id):
4444
file = get_object_or_404(File, id=file_id)
4545

4646
file_object = request.FILES["file"]
4747

48-
service = FilePassThruUploadService(request.user)
48+
service = FileDirectUploadService(request.user)
4949
file = service.upload_local(file=file, file_object=file_object)
5050

5151
return Response({"id": file.id})
5252

5353

54-
class FilePassThruUploadFinishApi(ApiAuthMixin, APIView):
54+
class FileDirectUploadFinishApi(ApiAuthMixin, APIView):
5555
class InputSerializer(serializers.Serializer):
5656
file_id = serializers.CharField()
5757

@@ -63,7 +63,7 @@ def post(self, request):
6363

6464
file = get_object_or_404(File, id=file_id)
6565

66-
service = FilePassThruUploadService(request.user)
66+
service = FileDirectUploadService(request.user)
6767
service.finish(file=file)
6868

6969
return Response({"id": file.id})

styleguide_example/files/services.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ def update(self, file: File, file_name: str = "", file_type: str = "") -> File:
8282
return file
8383

8484

85-
class FilePassThruUploadService:
85+
class FileDirectUploadService:
8686
"""
8787
This also serves as an example of a service class,
8888
which encapsulates a flow (start & finish) + one-off action (upload_local) into a namespace.

styleguide_example/files/urls.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,9 @@
33
from styleguide_example.files.apis import (
44
FileStandardUploadApi,
55

6-
FilePassThruUploadStartApi,
7-
FilePassThruUploadFinishApi,
8-
FilePassThruUploadLocalApi,
6+
FileDirectUploadStartApi,
7+
FileDirectUploadFinishApi,
8+
FileDirectUploadLocalApi,
99
)
1010

1111

@@ -19,24 +19,24 @@
1919
name="standard"
2020
),
2121
path(
22-
"pass-thru/",
22+
"direct/",
2323
include(([
2424
path(
2525
"start/",
26-
FilePassThruUploadStartApi.as_view(),
26+
FileDirectUploadStartApi.as_view(),
2727
name="start"
2828
),
2929
path(
3030
"finish/",
31-
FilePassThruUploadFinishApi.as_view(),
31+
FileDirectUploadFinishApi.as_view(),
3232
name="finish"
3333
),
3434
path(
3535
"local/<str:file_id>/",
36-
FilePassThruUploadLocalApi.as_view(),
36+
FileDirectUploadLocalApi.as_view(),
3737
name="local"
3838
)
39-
], "pass-thru"))
39+
], "direct"))
4040
)
4141
], "upload"))
4242
)

styleguide_example/files/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def file_generate_upload_path(instance, filename):
1818

1919
def file_generate_local_upload_url(*, file_id: str):
2020
url = reverse(
21-
"api:files:upload:pass-thru:local",
21+
"api:files:upload:direct:local",
2222
kwargs={"file_id": file_id}
2323
)
2424

0 commit comments

Comments
 (0)