Commit 8a8b56d
committed
minor symfony#9302 Added the name attribute to XLIFF 2 documents (javiereguiluz)
This PR was merged into the master branch.
Discussion
----------
Added the name attribute to XLIFF 2 documents
This fixes symfony#9287. It's a simple fix because we only display one XLIFF 2 document in the docs.
-----
@Nyholm I'm sure you did the right thing ... but just asking: making the `name` value the same as `source` is the best possible solution here? In Symfony's code the `source` attribute is short (https://github.com/symfony/symfony/pull/26149/files) but in real world it can be super long and super ugly (containing `CDATA`, etc.) So, don't you think this will be very verbose? Could we make the `name` value the same as the `id` attribute instead? If the XLIFF standard forces us to do this, then forget my comment and accept my apologies 😄
Commits
-------
30ee49e Added the name attribute to XLIFF 2 documents1 file changed
+1
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
438 | 438 | | |
439 | 439 | | |
440 | 440 | | |
441 | | - | |
| 441 | + | |
442 | 442 | | |
443 | 443 | | |
444 | 444 | | |
| |||
0 commit comments