Fix Enums not being cast when calling Model::toArray() (#2522)

Author: jeromegamez

src/Eloquent/Model.php

@@ -556,7 +556,7 @@ protected function addCastAttributesToArray(array $attributes, array $mutatedAtt
             }
 
             if ($this->isEnumCastable($key) && (! $castValue instanceof Arrayable)) {
-                $castValue = $castValue !== null ? $this->getStorableEnumValue($attributes[$key]) : null;
+                $castValue = $castValue !== null ? $this->getStorableEnumValue($castValue) : null;
             }
 
             if ($castValue instanceof Arrayable) {

tests/ModelTest.php

@@ -786,4 +786,19 @@ public function testFirstOrCreate(): void
         $check = User::where('name', $name)->first();
         $this->assertEquals($user->_id, $check->_id);
     }
+
+    public function testEnumCast(): void
+    {
+        $name = 'John Member';
+
+        $user = new User();
+        $user->name = $name;
+        $user->member_status = MemberStatus::Member;
+        $user->save();
+
+        /** @var User $check */
+        $check = User::where('name', $name)->first();
+        $this->assertSame(MemberStatus::Member->value, $check->getRawOriginal('member_status'));
+        $this->assertSame(MemberStatus::Member, $check->member_status);
+    }
 }

tests/models/MemberStatus.php

@@ -0,0 +1,6 @@
+<?php
+
+enum MemberStatus: string
+{
+    case Member = 'MEMBER';
+}

tests/models/User.php

@@ -24,6 +24,7 @@
  * @property \Carbon\Carbon $created_at
  * @property \Carbon\Carbon $updated_at
  * @property string $username
+ * @property MemberStatus member_status
  */
 class User extends Eloquent implements AuthenticatableContract, CanResetPasswordContract
 {
@@ -36,6 +37,7 @@ class User extends Eloquent implements AuthenticatableContract, CanResetPassword
     protected $casts = [
         'birthday' => 'datetime',
         'entry.date' => 'datetime',
+        'member_status' => MemberStatus::class,
     ];
     protected static $unguarded = true;